From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Stephen Hemminger <stephen@networkplumber.org>
Cc: Rasesh Mody <rmody@marvell.com>,
Shahed Shaikh <shshaikh@marvell.com>,
Hemant Agrawal <hemant.agrawal@nxp.com>,
Sachin Saxena <sachin.saxena@oss.nxp.com>,
Haiyue Wang <haiyue.wang@intel.com>,
"Gagandeep Singh" <g.singh@nxp.com>,
John Daley <johndale@cisco.com>,
Hyong Youb Kim <hyonkim@cisco.com>,
Beilei Xing <beilei.xing@intel.com>,
Jingjing Wu <jingjing.wu@intel.com>,
Qiming Yang <qiming.yang@intel.com>,
Qi Zhang <qi.z.zhang@intel.com>,
Shijith Thotton <sthotton@marvell.com>,
Srisivasubramanian Srinivasan <srinivasan@marvell.com>,
Zyta Szpak <zr@semihalf.com>, Liron Himi <lironh@marvell.com>,
Harman Kalra <hkalra@marvell.com>,
Xiao Wang <xiao.w.wang@intel.com>,
Thomas Monjalon <thomas@monjalon.net>, <dev@dpdk.org>,
<stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] drivers/net: remove queue xstats auto-fill flag
Date: Thu, 14 Oct 2021 23:16:49 +0100 [thread overview]
Message-ID: <d8256627-058e-572c-924a-c55dec3addd3@intel.com> (raw)
In-Reply-To: <040e1bb1-dc45-7dff-ee60-e9d82d4ae027@oktetlabs.ru>
On 9/30/2021 2:50 PM, Andrew Rybchenko wrote:
> On 9/30/21 4:45 PM, Andrew Rybchenko wrote:
>> On 9/30/21 4:00 PM, Ferruh Yigit wrote:
>>> On 9/29/2021 7:38 AM, Andrew Rybchenko wrote:
>>>> On 9/28/21 8:10 PM, Stephen Hemminger wrote:
>>>>> On Tue, 28 Sep 2021 19:48:54 +0300
>>>>> Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> wrote:
>>>>>
>>>>>> Some drivers do not provide per-queue statistics. So, there is no point
>>>>>> to have these misleading zeros in xstats.
>>>>>>
>>>>>> Fixes: f30e69b41f94 ("ethdev: add device flag to bypass auto-filled queue xstats")
>>>>>> Cc: stable@dpdk.org
>>>>>>
>>>>>> Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
>>>>> Really?
>>>>> It is useful to have zeros rather than random data there.
>>>>
>>>> I guess there is a misunderstanding here. Auto-filling xstats is
>>>> an addition of per-queue basic statistics to xstats by ethdev
>>>> layer. It makes sense to do it if and only if there is some
>>>> sensible data there.
>>>>
>>>> There is a related deprecation notice saying that per-queue
>>>> stats should be removed from basic stats since per-queue
>>>> stats should be provided by xstats API natively.
>>>>
>>>> Basically RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS means
>>>> that corresponding driver is not ready vs the deprecation notice.
>>>> So, I want to clean it up to see not yet ready drivers only.
>>>>
>>>
>>> As you said, 'RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' flag set by driver means,
>>> driver is not ready on representing queue stats in xstats and ethdev layer is
>>> filling it automatically from basic stats.
>>>
>>> First we should wait for drivers to implement it, later clean queue stats from
>>> basic stats and remove the flag.
>>>
>>> I am not sure if we can remove the deprecation notice in this release, but agree
>>> to add a deadline for the drivers, which can be 22.11.
>>>
>>
>> I'm going to cleanup deprecation. I don't touch it in the
>
> Sorry "I'm NOT going to ..."
>
OK, I see now, I thought intention was to clean the deprecation.
Agree to not add queue stats to xstats when driver doesn't have
the queue stats at all.
>> patch. I just want to cleanup list of drivers which
>> require attention/changes. Drivers covered here do not
>> provide per-queue stats in basic stats. So, there is no
>> point to set the flag to show it in xstats.
>>
>
next prev parent reply other threads:[~2021-10-14 22:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-28 14:16 [dpdk-stable] [PATCH] net/sfc: " Andrew Rybchenko
2021-09-28 16:48 ` [dpdk-stable] [PATCH v2] drivers/net: " Andrew Rybchenko
2021-09-28 17:10 ` [dpdk-stable] [dpdk-dev] " Stephen Hemminger
2021-09-29 6:38 ` Andrew Rybchenko
2021-09-30 13:00 ` Ferruh Yigit
2021-09-30 13:45 ` Andrew Rybchenko
2021-09-30 13:50 ` Andrew Rybchenko
2021-10-14 22:16 ` Ferruh Yigit [this message]
2021-10-14 22:19 ` [dpdk-stable] " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8256627-058e-572c-924a-c55dec3addd3@intel.com \
--to=ferruh.yigit@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=g.singh@nxp.com \
--cc=haiyue.wang@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=hkalra@marvell.com \
--cc=hyonkim@cisco.com \
--cc=jingjing.wu@intel.com \
--cc=johndale@cisco.com \
--cc=lironh@marvell.com \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=rmody@marvell.com \
--cc=sachin.saxena@oss.nxp.com \
--cc=shshaikh@marvell.com \
--cc=srinivasan@marvell.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=sthotton@marvell.com \
--cc=thomas@monjalon.net \
--cc=xiao.w.wang@intel.com \
--cc=zr@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).