From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Ivan Malov <ivan.malov@oktetlabs.ru>, <dev@dpdk.org>
Cc: <stable@dpdk.org>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
"Andy Moreton" <amoreton@xilinx.com>
Subject: Re: [PATCH 1/2] net/sfc: do not push fast free offload to default TxQ config
Date: Thu, 10 Feb 2022 13:33:12 +0000 [thread overview]
Message-ID: <d8412006-eb15-5400-84e7-f1b493d6b9d1@intel.com> (raw)
In-Reply-To: <20220208232648.856157-1-ivan.malov@oktetlabs.ru>
On 2/8/2022 11:26 PM, Ivan Malov wrote:
> Doing so is wrong since fast free is an adapter-wide offload.
>
> Technically, the offending commit (see "Fixes" tag) does not
> induce failures, however, such started to occur after commit
> a4996bd89c42 ("ethdev: new Rx/Tx offloads API") had shown up,
> because of the strict offload validation in the generic code.
>
> Fixes: c78d280e88ef ("net/sfc: convert to new Tx offload API")
> Cc:stable@dpdk.org
>
> Signed-off-by: Ivan Malov<ivan.malov@oktetlabs.ru>
> Reviewed-by: Andrew Rybchenko<andrew.rybchenko@oktetlabs.ru>
> Reviewed-by: Andy Moreton<amoreton@xilinx.com>
Series applied to dpdk-next-net/main, thanks.
prev parent reply other threads:[~2022-02-10 13:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-08 23:26 Ivan Malov
2022-02-08 23:26 ` [PATCH 2/2] net/sfc: demand Tx fast free offload on ef10 simple datapath Ivan Malov
2022-02-10 13:33 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8412006-eb15-5400-84e7-f1b493d6b9d1@intel.com \
--to=ferruh.yigit@intel.com \
--cc=amoreton@xilinx.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ivan.malov@oktetlabs.ru \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).