* [dpdk-stable] [PATCH 03/12] cryptodev: rename device retrieval argument [not found] <1495639634-74846-1-git-send-email-pablo.de.lara.guarch@intel.com> @ 2017-05-24 15:27 ` Pablo de Lara 2017-06-20 14:35 ` Declan Doherty [not found] ` <20170621062826.21896-1-pablo.de.lara.guarch@intel.com> 1 sibling, 1 reply; 5+ messages in thread From: Pablo de Lara @ 2017-05-24 15:27 UTC (permalink / raw) To: declan.doherty, thomas; +Cc: dev, Pablo de Lara, stable rte_cryptodev_devices_get() function was parsing a crypto device name as an argument, but the function actually returns device identifiers of devices that share the same crypto driver, so the argument should be driver name, instead. Fixes: 38227c0e3ad2 ("cryptodev: retrieve device info") CC: stable@dpdk.org Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com> --- lib/librte_cryptodev/rte_cryptodev.c | 2 +- lib/librte_cryptodev/rte_cryptodev.h | 7 ++++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/lib/librte_cryptodev/rte_cryptodev.c b/lib/librte_cryptodev/rte_cryptodev.c index a5a5c36..6880661 100644 --- a/lib/librte_cryptodev/rte_cryptodev.c +++ b/lib/librte_cryptodev/rte_cryptodev.c @@ -523,7 +523,7 @@ rte_cryptodev_count_devtype(enum rte_cryptodev_type type) } uint8_t -rte_cryptodev_devices_get(const char *dev_name, uint8_t *devices, +rte_cryptodev_devices_get(const char *driver_name, uint8_t *devices, uint8_t nb_devices) { uint8_t i, count = 0; diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h index f307b3b..89093f6 100644 --- a/lib/librte_cryptodev/rte_cryptodev.h +++ b/lib/librte_cryptodev/rte_cryptodev.h @@ -464,9 +464,10 @@ extern uint8_t rte_cryptodev_count_devtype(enum rte_cryptodev_type type); /** - * Get number and identifiers of attached crypto device. + * Get number and identifiers of attached crypto devices that + * use the same crypto driver. * - * @param dev_name device name. + * @param driver_name driver name. * @param devices output devices identifiers. * @param nb_devices maximal number of devices. * @@ -474,7 +475,7 @@ rte_cryptodev_count_devtype(enum rte_cryptodev_type type); * Returns number of attached crypto device. */ uint8_t -rte_cryptodev_devices_get(const char *dev_name, uint8_t *devices, +rte_cryptodev_devices_get(const char *driver_name, uint8_t *devices, uint8_t nb_devices); /* * Return the NUMA socket to which a device is connected -- 2.7.4 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-stable] [PATCH 03/12] cryptodev: rename device retrieval argument 2017-05-24 15:27 ` [dpdk-stable] [PATCH 03/12] cryptodev: rename device retrieval argument Pablo de Lara @ 2017-06-20 14:35 ` Declan Doherty 2017-06-20 17:28 ` De Lara Guarch, Pablo 0 siblings, 1 reply; 5+ messages in thread From: Declan Doherty @ 2017-06-20 14:35 UTC (permalink / raw) To: Pablo de Lara, thomas; +Cc: dev, stable On 24/05/2017 4:27 PM, Pablo de Lara wrote: > rte_cryptodev_devices_get() function was parsing a crypto > device name as an argument, but the function actually > returns device identifiers of devices that share the > same crypto driver, so the argument should be driver name, instead. > > Fixes: 38227c0e3ad2 ("cryptodev: retrieve device info") > CC: stable@dpdk.org > > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com> > --- > lib/librte_cryptodev/rte_cryptodev.c | 2 +- > lib/librte_cryptodev/rte_cryptodev.h | 7 ++++--- > 2 files changed, 5 insertions(+), 4 deletions(-) > > diff --git a/lib/librte_cryptodev/rte_cryptodev.c b/lib/librte_cryptodev/rte_cryptodev.c > index a5a5c36..6880661 100644 > --- a/lib/librte_cryptodev/rte_cryptodev.c > +++ b/lib/librte_cryptodev/rte_cryptodev.c > @@ -523,7 +523,7 @@ rte_cryptodev_count_devtype(enum rte_cryptodev_type type) > } > > uint8_t > -rte_cryptodev_devices_get(const char *dev_name, uint8_t *devices, > +rte_cryptodev_devices_get(const char *driver_name, uint8_t *devices, > uint8_t nb_devices) > { > uint8_t i, count = 0; Compilation breaks after this change, needs next patch to build > diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h > index f307b3b..89093f6 100644 > --- a/lib/librte_cryptodev/rte_cryptodev.h > +++ b/lib/librte_cryptodev/rte_cryptodev.h > @@ -464,9 +464,10 @@ extern uint8_t > rte_cryptodev_count_devtype(enum rte_cryptodev_type type); > > /** > - * Get number and identifiers of attached crypto device. > + * Get number and identifiers of attached crypto devices that > + * use the same crypto driver. > * > - * @param dev_name device name. > + * @param driver_name driver name. > * @param devices output devices identifiers. > * @param nb_devices maximal number of devices. > * > @@ -474,7 +475,7 @@ rte_cryptodev_count_devtype(enum rte_cryptodev_type type); > * Returns number of attached crypto device. > */ > uint8_t > -rte_cryptodev_devices_get(const char *dev_name, uint8_t *devices, > +rte_cryptodev_devices_get(const char *driver_name, uint8_t *devices, > uint8_t nb_devices); > /* > * Return the NUMA socket to which a device is connected > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-stable] [PATCH 03/12] cryptodev: rename device retrieval argument 2017-06-20 14:35 ` Declan Doherty @ 2017-06-20 17:28 ` De Lara Guarch, Pablo 0 siblings, 0 replies; 5+ messages in thread From: De Lara Guarch, Pablo @ 2017-06-20 17:28 UTC (permalink / raw) To: Doherty, Declan, thomas; +Cc: dev, stable > -----Original Message----- > From: Doherty, Declan > Sent: Tuesday, June 20, 2017 3:35 PM > To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; > thomas@monjalon.net > Cc: dev@dpdk.org; stable@dpdk.org > Subject: Re: [PATCH 03/12] cryptodev: rename device retrieval argument > > On 24/05/2017 4:27 PM, Pablo de Lara wrote: > > rte_cryptodev_devices_get() function was parsing a crypto device name > > as an argument, but the function actually returns device identifiers > > of devices that share the same crypto driver, so the argument should > > be driver name, instead. > > > > Fixes: 38227c0e3ad2 ("cryptodev: retrieve device info") > > CC: stable@dpdk.org > > > > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com> > > --- > > lib/librte_cryptodev/rte_cryptodev.c | 2 +- > > lib/librte_cryptodev/rte_cryptodev.h | 7 ++++--- > > 2 files changed, 5 insertions(+), 4 deletions(-) > > > > diff --git a/lib/librte_cryptodev/rte_cryptodev.c > > b/lib/librte_cryptodev/rte_cryptodev.c > > index a5a5c36..6880661 100644 > > --- a/lib/librte_cryptodev/rte_cryptodev.c > > +++ b/lib/librte_cryptodev/rte_cryptodev.c > > @@ -523,7 +523,7 @@ rte_cryptodev_count_devtype(enum > > rte_cryptodev_type type) } > > > > uint8_t > > -rte_cryptodev_devices_get(const char *dev_name, uint8_t *devices, > > +rte_cryptodev_devices_get(const char *driver_name, uint8_t *devices, > > uint8_t nb_devices) > > { > > uint8_t i, count = 0; > > Compilation breaks after this change, needs next patch to build Yes, I forgot to change the variable name within the implementation. I should better fix this and have it separated from the next one, though, because this patch should be backported, but the following patch changes the implementation, which requires patch 2. So, I will send a v2 with the fix for this patch. ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <20170621062826.21896-1-pablo.de.lara.guarch@intel.com>]
* [dpdk-stable] [PATCH v2 03/12] cryptodev: rename device retrieval argument [not found] ` <20170621062826.21896-1-pablo.de.lara.guarch@intel.com> @ 2017-06-21 6:28 ` Pablo de Lara 2017-06-23 12:54 ` Declan Doherty 0 siblings, 1 reply; 5+ messages in thread From: Pablo de Lara @ 2017-06-21 6:28 UTC (permalink / raw) To: declan.doherty, thomas; +Cc: dev, Pablo de Lara, stable rte_cryptodev_devices_get() function was parsing a crypto device name as an argument, but the function actually returns device identifiers of devices that share the same crypto driver, so the argument should be driver name, instead. Fixes: 38227c0e3ad2 ("cryptodev: retrieve device info") CC: stable@dpdk.org Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com> --- lib/librte_cryptodev/rte_cryptodev.c | 6 +++--- lib/librte_cryptodev/rte_cryptodev.h | 7 ++++--- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/lib/librte_cryptodev/rte_cryptodev.c b/lib/librte_cryptodev/rte_cryptodev.c index cb3e236..8875304 100644 --- a/lib/librte_cryptodev/rte_cryptodev.c +++ b/lib/librte_cryptodev/rte_cryptodev.c @@ -501,7 +501,7 @@ rte_cryptodev_count_devtype(enum rte_cryptodev_type type) } uint8_t -rte_cryptodev_devices_get(const char *dev_name, uint8_t *devices, +rte_cryptodev_devices_get(const char *driver_name, uint8_t *devices, uint8_t nb_devices) { uint8_t i, count = 0; @@ -516,10 +516,10 @@ rte_cryptodev_devices_get(const char *dev_name, uint8_t *devices, if (drv) cmp = strncmp(drv->pci_drv.driver.name, - dev_name, strlen(dev_name)); + driver_name, strlen(driver_name)); else cmp = strncmp(devs[i].data->name, - dev_name, strlen(dev_name)); + driver_name, strlen(driver_name)); if (cmp == 0) devices[count++] = devs[i].data->dev_id; diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h index f307b3b..89093f6 100644 --- a/lib/librte_cryptodev/rte_cryptodev.h +++ b/lib/librte_cryptodev/rte_cryptodev.h @@ -464,9 +464,10 @@ extern uint8_t rte_cryptodev_count_devtype(enum rte_cryptodev_type type); /** - * Get number and identifiers of attached crypto device. + * Get number and identifiers of attached crypto devices that + * use the same crypto driver. * - * @param dev_name device name. + * @param driver_name driver name. * @param devices output devices identifiers. * @param nb_devices maximal number of devices. * @@ -474,7 +475,7 @@ rte_cryptodev_count_devtype(enum rte_cryptodev_type type); * Returns number of attached crypto device. */ uint8_t -rte_cryptodev_devices_get(const char *dev_name, uint8_t *devices, +rte_cryptodev_devices_get(const char *driver_name, uint8_t *devices, uint8_t nb_devices); /* * Return the NUMA socket to which a device is connected -- 2.9.4 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-stable] [PATCH v2 03/12] cryptodev: rename device retrieval argument 2017-06-21 6:28 ` [dpdk-stable] [PATCH v2 " Pablo de Lara @ 2017-06-23 12:54 ` Declan Doherty 0 siblings, 0 replies; 5+ messages in thread From: Declan Doherty @ 2017-06-23 12:54 UTC (permalink / raw) To: Pablo de Lara, thomas; +Cc: dev, stable On 21/06/2017 7:28 AM, Pablo de Lara wrote: > rte_cryptodev_devices_get() function was parsing a crypto > device name as an argument, but the function actually > returns device identifiers of devices that share the > same crypto driver, so the argument should be driver name, instead. > > Fixes: 38227c0e3ad2 ("cryptodev: retrieve device info") > CC: stable@dpdk.org > > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com> > --- ... > Acked-by: Declan Doherty <declan.doherty@intel.com> ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-06-23 12:54 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1495639634-74846-1-git-send-email-pablo.de.lara.guarch@intel.com>
2017-05-24 15:27 ` [dpdk-stable] [PATCH 03/12] cryptodev: rename device retrieval argument Pablo de Lara
2017-06-20 14:35 ` Declan Doherty
2017-06-20 17:28 ` De Lara Guarch, Pablo
[not found] ` <20170621062826.21896-1-pablo.de.lara.guarch@intel.com>
2017-06-21 6:28 ` [dpdk-stable] [PATCH v2 " Pablo de Lara
2017-06-23 12:54 ` Declan Doherty
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).