From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <maxime.coquelin@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id EB1DE1B612;
 Thu,  9 Nov 2017 10:08:53 +0100 (CET)
Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com
 [10.5.11.11])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 4978A7EAA1;
 Thu,  9 Nov 2017 09:08:53 +0000 (UTC)
Received: from [10.36.112.47] (ovpn-112-47.ams2.redhat.com [10.36.112.47])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id A6A35649B0;
 Thu,  9 Nov 2017 09:08:51 +0000 (UTC)
To: Zhiyong Yang <zhiyong.yang@intel.com>, dev@dpdk.org
Cc: stable@dpdk.org, jianfeng.tan@intel.com, yliu@fridaylinux.org
References: <20171109044607.3327-1-zhiyong.yang@intel.com>
 <20171109085519.62567-1-zhiyong.yang@intel.com>
From: Maxime Coquelin <maxime.coquelin@redhat.com>
Message-ID: <dab5615b-c42d-a640-0591-2a99dd4e2ce5@redhat.com>
Date: Thu, 9 Nov 2017 10:08:48 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <20171109085519.62567-1-zhiyong.yang@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.28]); Thu, 09 Nov 2017 09:08:53 +0000 (UTC)
Subject: Re: [dpdk-stable] [PATCH v5] net/virtio: fix rxq intr config fails
	using vfio-pci
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/stable>,
 <mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/stable>,
 <mailto:stable-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Nov 2017 09:08:54 -0000



On 11/09/2017 09:55 AM, Zhiyong Yang wrote:
> diff --git a/drivers/net/virtio/virtio_pci.h b/drivers/net/virtio/virtio_pci.h
> index 36d452c06..28e9af6c7 100644
> --- a/drivers/net/virtio/virtio_pci.h
> +++ b/drivers/net/virtio/virtio_pci.h
> @@ -314,6 +314,12 @@ struct virtio_net_config {
>   /* The alignment to use between consumer and producer parts of vring. */
>   #define VIRTIO_PCI_VRING_ALIGN 4096
>   
> +enum VIRTIO_MSIX_STATUS {
Please change VIRTIO_MSIX_STATUS to lowercase.
Other than that, this is what I had in mind.

Thanks!
Maxime
> +	VIRTIO_MSIX_NONE = 0,
> +	VIRTIO_MSIX_DISABLED = 1,
> +	VIRTIO_MSIX_ENABLED = 2
> +};
> +