From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 330D45F1C; Tue, 23 Oct 2018 11:42:17 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7EB77308402A; Tue, 23 Oct 2018 09:42:16 +0000 (UTC) Received: from [10.36.112.43] (ovpn-112-43.ams2.redhat.com [10.36.112.43]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4D1E35DA2A; Tue, 23 Oct 2018 09:42:09 +0000 (UTC) To: Timothy Redaelli , Tiwei Bie , Zhihong Wang Cc: Fan Zhang , dev@dpdk.org, stable@dpdk.org References: <5cfae41059f6e9b52f424a1a1f6b0d3d41318e2a.1539722428.git.tredaelli@redhat.com> From: Maxime Coquelin Message-ID: Date: Tue, 23 Oct 2018 11:42:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <5cfae41059f6e9b52f424a1a1f6b0d3d41318e2a.1539722428.git.tredaelli@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Tue, 23 Oct 2018 09:42:16 +0000 (UTC) Subject: Re: [dpdk-stable] [PATCH v2] vhost/crypto: fix build without cryptodev (shared lib) X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Oct 2018 09:42:17 -0000 On 10/16/2018 10:47 PM, Timothy Redaelli wrote: > Currently it's not possible to build DPDK as shared library with > cryptodev disabled since vhost is trying to link with rte_crypto, > but rte_crypto and rte_hash are only needed when you build vhost_crypto > and so only when cryptodev is enabled. > > This patch fix this by linking rte_vhost with rte_crypto and rte_hash only > when cryptodev is enabled. > > Fixes: b4ca81298613 ("vhost/crypto: fix build without cryptodev") > Fixes: 939066d96563 ("vhost/crypto: add public function implementation") > Cc: stable@dpdk.org > > Signed-off-by: Timothy Redaelli > Reviewed-by: Maxime Coquelin > --- > v2: Fix the second 'Fixes' line. I wrongly copied that commit id from > commit b4ca81298613, but it seems it's a commit not contained in any branch > (as reported by Maxime and check-git-log.sh). > --- > lib/librte_vhost/Makefile | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied to dpdk-next-virtio/master Thanks, Maxime