* [dpdk-stable] [PATCH v5 1/2] net/bnxt: fix rx_drop_en setting
[not found] <4430e0f2-198c-3f15-90ca-30708035bec8@intel.com>
@ 2018-04-07 17:40 ` Ajit Khaparde
2018-04-09 16:53 ` Ferruh Yigit
0 siblings, 1 reply; 2+ messages in thread
From: Ajit Khaparde @ 2018-04-07 17:40 UTC (permalink / raw)
To: dev; +Cc: stable
If Rx descriptors are not available, pkts are dropped by default.
Fix rx_drop_en setting in bnxt_dev_info_get_op to reflect it.
Fixes: 0a6d2a720078 ("net/bnxt: get device infos")
Cc: stable@dpdk.org
Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
--
v1->v2: added fixes to commit message.
---
drivers/net/bnxt/bnxt_ethdev.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index 7c007c8f9..27a51048a 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -426,7 +426,8 @@ static void bnxt_dev_info_get_op(struct rte_eth_dev *eth_dev,
.wthresh = 0,
},
.rx_free_thresh = 32,
- .rx_drop_en = 0,
+ /* If no descriptors available, pkts are dropped by default */
+ .rx_drop_en = 1,
};
dev_info->default_txconf = (struct rte_eth_txconf) {
--
2.15.1 (Apple Git-101)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-stable] [PATCH v5 1/2] net/bnxt: fix rx_drop_en setting
2018-04-07 17:40 ` [dpdk-stable] [PATCH v5 1/2] net/bnxt: fix rx_drop_en setting Ajit Khaparde
@ 2018-04-09 16:53 ` Ferruh Yigit
0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2018-04-09 16:53 UTC (permalink / raw)
To: Ajit Khaparde, dev; +Cc: stable
On 4/7/2018 6:40 PM, Ajit Khaparde wrote:
> If Rx descriptors are not available, pkts are dropped by default.
> Fix rx_drop_en setting in bnxt_dev_info_get_op to reflect it.
>
> Fixes: 0a6d2a720078 ("net/bnxt: get device infos")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Series applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-04-09 16:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <4430e0f2-198c-3f15-90ca-30708035bec8@intel.com>
2018-04-07 17:40 ` [dpdk-stable] [PATCH v5 1/2] net/bnxt: fix rx_drop_en setting Ajit Khaparde
2018-04-09 16:53 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).