From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 245C3108D; Fri, 31 Mar 2017 18:24:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1490977455; x=1522513455; h=subject:to:references:cc:from:message-id:date: mime-version:in-reply-to; bh=T/RhWrXaOOmtr/8xNR8IQbuB6Gz/esT3O0viWogs4WQ=; b=LybwjmEa+QHL8HDsWYpqZXPYudcX4LrBeOjCiIdAF0nd0j9aP+UhOGgK liWUeDSTWQ6GKPm/m0cm5z8lMP3S7Q==; Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Mar 2017 09:24:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,252,1486454400"; d="scan'208,217";a="1114058933" Received: from smonroyx-mobl.ger.corp.intel.com (HELO [10.237.221.23]) ([10.237.221.23]) by orsmga001.jf.intel.com with ESMTP; 31 Mar 2017 09:24:04 -0700 To: Andrew Rybchenko References: <1490975813-6700-1-git-send-email-arybchenko@solarflare.com> Cc: Anatoly Burakov , stable@dpdk.org, dev@dpdk.org, Thomas Monjalon From: Sergio Gonzalez Monroy Message-ID: Date: Fri, 31 Mar 2017 17:24:03 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] vfio: do not use memcmp() to compare PCI address X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Mar 2017 16:24:16 -0000 On 31/03/2017 17:18, Andrew Rybchenko wrote: > On 03/31/2017 07:09 PM, Sergio Gonzalez Monroy wrote: >> On 31/03/2017 16:56, Andrew Rybchenko wrote: >>> PCI address structure has padding which may have garbage. >>> >>> Fixes: 2f4adfad0a69 ("vfio: add multiprocess support") >>> Cc: stable@dpdk.org >>> >>> Signed-off-by: Andrew Rybchenko >>> --- >>> It is a real bug which I've hit during multi-process debugging. >>> >>> lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c >>> b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c >>> index 5f478c5..7d8b9fb 100644 >>> --- a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c >>> +++ b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c >>> @@ -355,7 +355,8 @@ pci_vfio_map_resource(struct rte_pci_device *dev) >>> } else { >>> /* if we're in a secondary process, just find our tailq >>> entry */ >>> TAILQ_FOREACH(vfio_res, vfio_res_list, next) { >>> - if (memcmp(&vfio_res->pci_addr, &dev->addr, >>> sizeof(dev->addr))) >>> + if (rte_eal_compare_pci_addr(&vfio_res->pci_addr, >>> + &dev->addr)) >>> continue; >>> break; >>> } >> >> Different commit, same patch :) >> https://urldefense.proofpoint.com/v2/url?u=http-3A__dpdk.org_dev_patchwork_patch_21828_&d=DQICaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=flTOx6Av679My7o_iScb5sOlLD68bpUyE2RUtfW3SWQ&m=uvsF8SJaLsRNp3l01Ji5iD4EB1hkHVPOX_dFKqTu_mU&s=HYxvqVvNsbEzQgMJmwQuH6G7vqOkyg7vJ1PrzsxKr5c&e= > > > True, sorry, lost your patch from my view. > I'm not sure which state should be set on my patch in the patchwork. > Thomas, please, resolve it properly. > No worries. Probably the title on the other patch was a bit misleading. You could just set it to the "Not Applicable" state. Sergio > Thanks, > Andrew.