patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Xueming Li <xuemingl@nvidia.com>, dev@dpdk.org
Cc: stable@dpdk.org, Chenbo Xia <chenbo.xia@intel.com>,
	Matan Azrad <matan@mellanox.com>
Subject: Re: [PATCH] examples/vdpa: fix disabled VirtQ statistics query
Date: Fri, 22 Apr 2022 10:40:07 +0200	[thread overview]
Message-ID: <dbd81f42-e96e-6708-a648-53f8fb5d7a30@redhat.com> (raw)
In-Reply-To: <20220224132405.1939006-1-xuemingl@nvidia.com>

"examples/vdpa: fix disabled virtqueue statistics query"

On 2/24/22 14:24, Xueming Li wrote:
> Quit VirtQ statistics query instead of reporting error.
> 
> Fixes: 6505865aa8ed ("examples/vdpa: add statistics show command")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Xueming Li <xuemingl@nvidia.com>
> ---
>   examples/vdpa/main.c | 21 +++++++++++++++++++--
>   1 file changed, 19 insertions(+), 2 deletions(-)
> 
> diff --git a/examples/vdpa/main.c b/examples/vdpa/main.c
> index 5ab07655aed..bd66deca85c 100644
> --- a/examples/vdpa/main.c
> +++ b/examples/vdpa/main.c
> @@ -391,7 +391,9 @@ static void cmd_device_stats_parsed(void *parsed_result, struct cmdline *cl,
>   	struct rte_vdpa_device *vdev = rte_vdpa_find_device_by_name(res->bdf);
>   	struct vdpa_port *vport = NULL;
>   	uint32_t first, last;
> +	int vq_disabled = -1;
>   	int i;
> +	int ret;
>   
>   	if (!vdev) {
>   		RTE_LOG(ERR, VDPA, "Invalid device: %s.\n",
> @@ -449,8 +451,20 @@ static void cmd_device_stats_parsed(void *parsed_result, struct cmdline *cl,
>   	cmdline_printf(cl, "\nDevice %s:\n", res->bdf);
>   	for (; first <= last; first++) {
>   		memset(vport->stats, 0, sizeof(*vport->stats) * vport->stats_n);
> -		if (rte_vdpa_get_stats(vport->dev, (int)first, vport->stats,
> -					vport->stats_n) <= 0) {
> +		ret = rte_vdpa_get_stats(vport->dev, (int)first, vport->stats,
> +						vport->stats_n);
> +		if (ret == 0) {
> +			/* VQ disabled. */
> +			if (vq_disabled == -1)
> +				vq_disabled = (int)first;
> +			continue;
> +		}
> +		if (vq_disabled != -1) {
> +			cmdline_printf(cl, "\tVirtq %d - %d disabled\n",
> +				       vq_disabled, (int)first - 1);
> +			vq_disabled = -1;
> +		}
> +		if (ret < 0) {
>   			RTE_LOG(ERR, VDPA, "Failed to get vdpa queue statistics"
>   				" for device %s qid %d.\n", res->bdf,
>   				(int)first);
> @@ -464,6 +478,9 @@ static void cmd_device_stats_parsed(void *parsed_result, struct cmdline *cl,
>   				vport->stats[i].value);
>   		}
>   	}
> +	if (vq_disabled != -1)
> +		cmdline_printf(cl, "\tVirtq %d - %d disabled\n",
> +			       vq_disabled, (int)first - 1);
>   }
>   
>   cmdline_parse_token_string_t cmd_device_stats_ =

It is not clear to me how it is going to look like, could you paste some
logs?


      parent reply	other threads:[~2022-04-22  8:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-24 13:24 Xueming Li
2022-03-03  6:45 ` Xia, Chenbo
2022-04-22  8:40 ` Maxime Coquelin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dbd81f42-e96e-6708-a648-53f8fb5d7a30@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=chenbo.xia@intel.com \
    --cc=dev@dpdk.org \
    --cc=matan@mellanox.com \
    --cc=stable@dpdk.org \
    --cc=xuemingl@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).