From: Kevin Traynor <ktraynor@redhat.com>
To: Chaoyong He <chaoyong.he@corigine.com>, stable@dpdk.org
Cc: oss-drivers@corigine.com
Subject: Re: [PATCH 21.11] net/nfp: fix Tx descriptor free logic of NFD3
Date: Thu, 23 Nov 2023 10:47:16 +0000 [thread overview]
Message-ID: <dc0a7bed-14d7-ced5-6840-9fe8f1f99c91@redhat.com> (raw)
In-Reply-To: <20231108021914.2966142-1-chaoyong.he@corigine.com>
On 08/11/2023 02:19, Chaoyong He wrote:
> [ upstream commit e97738919c2315e07c2e98b6a9cc3912c335364a ]
>
> In the Tx descriptor free logic of nfd3, the former logic might force
> cast a negative number into a very big unsigned number, and which will
> cause potential problem in the xmit loop.
>
> The xmit loop will continue in the place where it should break, and will
> overwrite the Tx descriptor which is not free to use by the PMD.
>
> Fixes: 74a640dac864 ("net/nfp: avoid modulo operations for handling ring wrapping")
>
> Signed-off-by: Chaoyong He<chaoyong.he@corigine.com>
> ---
> drivers/net/nfp/nfp_rxtx.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
Applied to 21.11 branch. Thanks for backporting.
next prev parent reply other threads:[~2023-11-23 10:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-08 2:19 Chaoyong He
2023-11-23 10:47 ` Kevin Traynor [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-07-25 6:51 [PATCH 21.11] net/nfp: fix offloading flows Chaoyong He
2023-07-25 6:51 ` [PATCH 21.11] net/nfp: fix Tx descriptor free logic of NFD3 Chaoyong He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc0a7bed-14d7-ced5-6840-9fe8f1f99c91@redhat.com \
--to=ktraynor@redhat.com \
--cc=chaoyong.he@corigine.com \
--cc=oss-drivers@corigine.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).