From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 944C7433A7 for ; Thu, 23 Nov 2023 11:47:24 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CBA52402A6; Thu, 23 Nov 2023 11:47:22 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 6AD214026B for ; Thu, 23 Nov 2023 11:47:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700736441; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P6zDgKaWHbVoR4yAFbfwgKX1Fsh26VTehKd4cBXunlo=; b=JJxztBDC8QLjseJUExdLXWXxa+4W4XsiWhqh8ugy0y9GDAefvHUgjy+PMO2cPybRAmwSrO BeSzM7QVh6nW6ZwrYvEpgG4HLPRt/3u2c3DpWiDKr6cRF02nHbBWMG+hBp1ouuWs1SsFcK 7SlikuM5oh0FS2ZNNXRQjE6Y8/W7qMg= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-455-VBxeqjjWNI2hSgIdHHQvhw-1; Thu, 23 Nov 2023 05:47:19 -0500 X-MC-Unique: VBxeqjjWNI2hSgIdHHQvhw-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-40b346a11d9so3604485e9.3 for ; Thu, 23 Nov 2023 02:47:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700736438; x=1701341238; h=content-transfer-encoding:in-reply-to:subject:content-language :references:cc:to:from:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=P6zDgKaWHbVoR4yAFbfwgKX1Fsh26VTehKd4cBXunlo=; b=TsJb29cx/c/9swpKmknI9YJLLRIrViruk07cbY1moRfykIJib+euH/GqJjUwab1FXL 77momM/7mQwIdR+JFXHFiwmA6SmLyA7aEfCTdVjjzD1V4wrBdasygbbdBRrzmcslRsoh 3FJMtr48zI7HKMoGBjvv7EqDGC4mHBOQbiDxuQKRkl3nwvwyLukFQIJ4CdhBli+h+qyh kTKNvdXYlE3kRAPNYpRR1mRD2bDwzgVXGmlwsXbl1LRpFbVPOBXwSpYow3eYmobTW50c kpKKp2peQLCIm3MHpSWghDyBJX7Yb0iA9DcSxpENzNugyREvNyl1mYaM4U1XXZz3a8Y2 et9A== X-Gm-Message-State: AOJu0YwHFHMQOnrLmugK89KoCahGM/XHj2y75KRIC3qhmZ9MoOWC2Q5d Cy09jEM1M+fh3eU52qs3IWi3lv8xvCfbi7sVsK97Vs5zckHNidzE3biSFYKo+YUAYbOOG9l3Q1Q n2b4FEgLK7AROhfo= X-Received: by 2002:a05:600c:5487:b0:409:5580:bc9f with SMTP id iv7-20020a05600c548700b004095580bc9fmr3565580wmb.34.1700736438004; Thu, 23 Nov 2023 02:47:18 -0800 (PST) X-Google-Smtp-Source: AGHT+IF4x24Uq2ShWHo9CXbOmTMvaLpdaibHVVjRiSAu47P9dd92a4DyncFo81nL59RJ2QZLnqgmBg== X-Received: by 2002:a05:600c:5487:b0:409:5580:bc9f with SMTP id iv7-20020a05600c548700b004095580bc9fmr3565570wmb.34.1700736437666; Thu, 23 Nov 2023 02:47:17 -0800 (PST) Received: from [192.168.0.36] ([78.16.130.39]) by smtp.gmail.com with ESMTPSA id y3-20020adfee03000000b00332d3b89561sm1317491wrn.97.2023.11.23.02.47.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Nov 2023 02:47:17 -0800 (PST) Message-ID: Date: Thu, 23 Nov 2023 10:47:16 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 From: Kevin Traynor To: Chaoyong He , stable@dpdk.org Cc: oss-drivers@corigine.com References: <20231108021914.2966142-1-chaoyong.he@corigine.com> Subject: Re: [PATCH 21.11] net/nfp: fix Tx descriptor free logic of NFD3 In-Reply-To: <20231108021914.2966142-1-chaoyong.he@corigine.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 08/11/2023 02:19, Chaoyong He wrote: > [ upstream commit e97738919c2315e07c2e98b6a9cc3912c335364a ] > > In the Tx descriptor free logic of nfd3, the former logic might force > cast a negative number into a very big unsigned number, and which will > cause potential problem in the xmit loop. > > The xmit loop will continue in the place where it should break, and will > overwrite the Tx descriptor which is not free to use by the PMD. > > Fixes: 74a640dac864 ("net/nfp: avoid modulo operations for handling ring wrapping") > > Signed-off-by: Chaoyong He > --- > drivers/net/nfp/nfp_rxtx.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) Applied to 21.11 branch. Thanks for backporting.