From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 750441B6ED; Wed, 9 May 2018 17:23:56 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id D8C1578007A; Wed, 9 May 2018 15:23:53 +0000 (UTC) Received: from [192.168.239.128] (188.242.181.57) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Wed, 9 May 2018 16:23:35 +0100 To: Wei Dai , , CC: , References: <1517484102-43836-1-git-send-email-wei.dai@intel.com> <1525869126-51223-1-git-send-email-wei.dai@intel.com> From: Andrew Rybchenko Message-ID: Date: Wed, 9 May 2018 18:23:26 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <1525869126-51223-1-git-send-email-wei.dai@intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [188.242.181.57] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.100.1062-23832.003 X-TM-AS-Result: No--7.364100-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-MDID: 1525879434-SO5SiA74DTku Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] ethdev: fix comments for offload capabilities X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2018 15:23:56 -0000 On 05/09/2018 03:32 PM, Wei Dai wrote: > Indeed, rx_offload_capa or tx_offload_capa in struct rte_eth_dev_info > includes not only per port offloading features but also per queue ones. > This patch make its meaning much clearer. > > Fixes: ce17eddefc20 ("ethdev: introduce Rx queue offloads API") > Fixes: cba7f53b717d ("ethdev: introduce Tx queue offloads API") > Cc: stable@dpdk.org > > Signed-off-by: Wei Dai > > --- > v2: fix coding style issues > --- > lib/librte_ethdev/rte_ethdev.h | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h > index 7ccf4ba..98e3114 100644 > --- a/lib/librte_ethdev/rte_ethdev.h > +++ b/lib/librte_ethdev/rte_ethdev.h > @@ -1067,9 +1067,13 @@ struct rte_eth_dev_info { > uint16_t max_vfs; /**< Maximum number of VFs. */ > uint16_t max_vmdq_pools; /**< Maximum number of VMDq pools. */ > uint64_t rx_offload_capa; > - /**< Device per port RX offload capabilities. */ > + /**< Rx offload capabilities including all per port ones > + * and all per queue ones. > + */ > uint64_t tx_offload_capa; > - /**< Device per port TX offload capabilities. */ > + /**< Tx offload capabilities including all per port ones > + * and all per queue ones. > + */ > uint64_t rx_queue_offload_capa; > /**< Device per queue RX offload capabilities. */ > uint64_t tx_queue_offload_capa; Just a minor nit. May I suggest to put comments before structure member and use /**. Right now it looks very confusing. Andrew.