From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 143A64332E for ; Tue, 14 Nov 2023 19:16:33 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0C47D402E6; Tue, 14 Nov 2023 19:16:33 +0100 (CET) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2067.outbound.protection.outlook.com [40.107.92.67]) by mails.dpdk.org (Postfix) with ESMTP id A617E4027B; Tue, 14 Nov 2023 19:16:30 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dIO5BgCwBIz0BAMGKsDRIQ5ckBYd4M0Us7J0Nh80j6ubBfehWh9V6Fx+1KP+h/9A6cd3i8MI/D8z8XlsPFIXoE6ZBgjnxSccvWz7DdTRKVkvXftcfPiV9IXXL12DUld+6A/d247u+/u+y4y0KSpsMvwlAt9n5BhXxJNeGd7B62EcbDldFztLUocTY8iF2KMpP1RfAC87FnugfTy0KayalkSKcmuhTuLqACu81YXHp1T7sjxzWVmbFnERRl10oRIkG4jmQ5wROU8lSly9ZH/Y7lHrOeUN7kKNFoPDcitqxaHoJFtb4dMVMypLG6ay3hQyTPunO1F4tjXlLGXBSRkdzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EpcOfOO6ruusF52/ESLx+hax/M2HHfMxZMZzZauRdkY=; b=kxhlf6oVhj62fEQx9sUHJKudDtmpqcj9C81ahgA+7iRzyAV8z1Fd5NoUz2V3LB4PmVrpcpVl2W9jXlO2WTuES8hL71Ss0j2d3jE14ZIXBhiy+wdYuVsVR/BBiecTSEij8RWqne/+Q7t5IR8eiB0hKLqx1z7gioZa/lXkM93c5g5/ju5rCPvyClGrcqKw4AiaUPWe+dAqDKP707Kglp93J21KuLrhCsqNnvaUdYgZspRNkwf43+iOYoKaRVkiWc/KAFREYOShtJZjDI/rAT7b41rKgUod6PTxhIqZwphg0cYcGSdhpgUjScnk9kSZIuQvwYXdLjTk3cbNNYh48POP9g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EpcOfOO6ruusF52/ESLx+hax/M2HHfMxZMZzZauRdkY=; b=ngb6A2NhMLA8Kq+O1QPaQy7ltW+IWwjubV6mD45O7eLEi+STn/ROlPmbhpq57/aV4hVyat1jT6SkRD9Q+iug96kCNifeu3OD21X3c4FiQasoGYqxZtxirYiAh6MLrzk7x+fjSTjsygzD+E6vD0xKqDYrmAJD48Mm2yPAplAvVAPh7IA1Yo85tqJImA0CGJw7w/Hhl2gD1ahJ1QeLfoaRAtAbrXO9qL7h2tsabQbtC9xCAsoK0fnTFpESrSFsOrZi1s8lVF6oxzLrfNRBUZPidIhtEb+pjXNpgYtF9OgG3s6InECVwxX0sVmau+9sw7GPbCAPmuxHzvWLf8KpO3uuhQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from IA1PR12MB6332.namprd12.prod.outlook.com (2603:10b6:208:3e2::13) by DS0PR12MB7747.namprd12.prod.outlook.com (2603:10b6:8:138::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6977.31; Tue, 14 Nov 2023 18:16:27 +0000 Received: from IA1PR12MB6332.namprd12.prod.outlook.com ([fe80::43ed:468d:3105:4071]) by IA1PR12MB6332.namprd12.prod.outlook.com ([fe80::43ed:468d:3105:4071%4]) with mapi id 15.20.6977.029; Tue, 14 Nov 2023 18:16:27 +0000 Date: Tue, 14 Nov 2023 20:16:22 +0200 (IST) From: "Etelson, Gregory" To: Tyler Retzlaff cc: Gregory Etelson , dev@dpdk.org, mkashani@nvidia.com, thomas@monjalon.net, stable@dpdk.org, Dmitry Kozlyuk , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam Subject: Re: [PATCH] eal/windows: fix memory management macros usage In-Reply-To: <20231114174637.GC23774@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> Message-ID: References: <20231114170529.176665-1-getelson@nvidia.com> <20231114174637.GC23774@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> Content-Type: text/plain; charset=US-ASCII; format=flowed X-ClientProxiedBy: LO6P265CA0009.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:339::14) To IA1PR12MB6332.namprd12.prod.outlook.com (2603:10b6:208:3e2::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA1PR12MB6332:EE_|DS0PR12MB7747:EE_ X-MS-Office365-Filtering-Correlation-Id: 4b283703-c223-4633-9a85-08dbe53dd141 X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: g8uqsu8WrlWWCsWRVpOmtMnw88zWuGxKJrsJWKqGFBkBHMyCQd62K+DM54Q5GvpVasgGc51VKQ3/rwqGuzIQcxt63MFSspG9IcUHEEBBaZpTyCW2KwPyMVJeHS8R4mm+0jS3M+dMkCh11aWMADSfwDkRDjwhBX328rhtPunrkc+GbaQr5vhzV6zeLoXU6h1QNZGg9s8K2S83Y456Bwc2nb46ELCFXvYe4LCrRHmRBS5cA/ppu4Mi56sDghCqO2q535xzhgc/e+NVJFN8HdtgULyo4mVvcp5OwS+9tmT8jf/un6pTfoam32/XltH3G/P4B2S2++3w2RS+ckU4N3aakBgVqQsGSPy9cWqVZRF2bglpyclLEnXYb9PegRJz6UjS4eyVq46heOoR1T5gNfx2aSHqucAWivJ9kba4QIXuPOjjmgTVV8gDrJrffWuycmqBHAK4Zb92bAYscFqH7qoDmFO3jv5zxuMAvvTpqGSyvifUXFxJiZVn8pZBSFlehpRJ5TG9T1HG8BqwaSfbFUP9kLBPN5W2k5pt5zSe7Y2WNTIxxxE6Cxx6+6IWDqHb8lUN9x/CAWI8WTgo959liiftduaPYktZ/HyJ6TzljeaqlvL8jERa76gBMX9eKaqF31O4 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:IA1PR12MB6332.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(136003)(39860400002)(376002)(396003)(366004)(230922051799003)(451199024)(64100799003)(1800799009)(186009)(2906002)(5660300002)(4744005)(41300700001)(38100700002)(6916009)(54906003)(66476007)(31696002)(66946007)(86362001)(66556008)(316002)(36756003)(2616005)(478600001)(6512007)(6666004)(6506007)(6486002)(83380400001)(8936002)(8676002)(4326008)(31686004)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?T7oqW9P962Y+mwyS1Jyi5zRuTZ3rPRhskIEaWYr7vXfRS/dFraXvh1ZIFdh9?= =?us-ascii?Q?Z6b03raOOyJysvxBjhp5Z5XgB/zRzAIv6vTdVWO3Gr1u8V0Ob29yCy1xbr+3?= =?us-ascii?Q?e2H0hAT9ksU/qnR8NTh2kNeFMibqry+3vCSCg1pzaW+SQ0iNxaR8kzB3sWPU?= =?us-ascii?Q?MfFa28Bxu2QSM9V1JtjtUk+mFlVtphoylP6HsTTfwkkHSpU4HR07LKtd2KUb?= =?us-ascii?Q?lIKpUZbU1j5EIkW9728EFT3B+Ldul4WDfZH77FbOra1ERQ6SZxiJjiD6HY8d?= =?us-ascii?Q?JCNIHjlle+jmPdYHP17AFnmdmxLCw/xM1T+e3FgVxSSQGBMiEDW/wI4WOMHt?= =?us-ascii?Q?sb7/46wVXuTzbPgYV2ctza69oOntLl6rtX4xKpM61XPqOQsOHGRVwxqZdYxq?= =?us-ascii?Q?RzNbuinsD/k4eJEOlwcKS6umF49vce5xP1PZvzSUrhfdAOEKLfplQVg2DtPK?= =?us-ascii?Q?0iVjkw5WkMji39E8ST2QlCXY0+/g5Wo4sNAPK3+9antEQ4SkMwsPioq4k5aq?= =?us-ascii?Q?CxDlVSJ2ImPrRM74JaRAJ+Ahke9uMNDZYIQNII2c48yFmWzez7N/ZNt/xj2g?= =?us-ascii?Q?XQuc8KPfbutn7LtfUVOejctT7G6kJJbGxSl7a1BFY6pojgwVD3XrdhLaQPMG?= =?us-ascii?Q?AyTRemDCsc/+vNmhRF0SdagQOIO64K1StRux38oCixPS2qV/67hIfx+LWIeI?= =?us-ascii?Q?aBLxvm7cnogPJQP9KUrMi7XemJ+6GIooxfWbnnDbsbFmvSrTmmz5PNO844UQ?= =?us-ascii?Q?nVIMPwHmKPLHiQP6wTeQTkMeC9a0owxrmPACHh54di5VG6f8QBignW+lSzKw?= =?us-ascii?Q?7auBVgZZz6VlL48MbwwUZAcytD5UnBEcIA35U7GxUCVoWl2uiYJ5CZrLCOpk?= =?us-ascii?Q?oOMA/tj4LCYFpqfFOME7tVbqTg6Q7zC15KTn3M64b9TsZyE0aolkmG7zY8Tj?= =?us-ascii?Q?1i10xY/17+djbR/0xALHexI0Y6jADqD5Pnz4+wXynVjckTzbJJuiWTfAXRjF?= =?us-ascii?Q?EC8GbWR3opM8NqqSgCtNMctHof+Q7mBEPh9Tj2BleTPSGu3jLP5zsXx7LmTY?= =?us-ascii?Q?r/tD1AXi6yRK6bLrq0BFVCyH47Qijn8373VdmuNeAIlteCKB5H/OnBePBL+M?= =?us-ascii?Q?FQ2BJh//HJ5SZSx67iSfo0ly3xfmhyer/cU6UPZK18i7uHvdnSAY3NPD3ZxT?= =?us-ascii?Q?Grx4qOYMRTrokPiOLBIxjODnrGBhWF/EuV951lDpqguxNVaETwVb9Kg0Gd+M?= =?us-ascii?Q?t1K39oyu178UxqRoPK/fRmErPNjhi+ZTVuucERvpSnwFXSD6XCHMSeTna00+?= =?us-ascii?Q?/dyXmxMeyFwUW7foTvPE0wet7dtnQ90f84atcXrBYoM7o26ZQz+O7oCWbxN5?= =?us-ascii?Q?wulx0+G5FLpxZQj5V5joyMddaL4W+ruP1zfsimd1yBs7fBRHnGYOo3ehHqf9?= =?us-ascii?Q?Zeu+cN432nr0AHbQICFhUmmMSF7ztabnFaEozg7H8YgAacoTybRatrgPMYcl?= =?us-ascii?Q?VyGGJgQ/oyCTwHNzXChEqwsv7/brT+dronF3l0SzFIU8vShZVrmVENRkzbvq?= =?us-ascii?Q?XssG2y6qhTQxyUsT3ukimqCLTTOUSkb3L5W+tVKwT9m+9siMckeM9DZhCjFY?= =?us-ascii?Q?bfyROHAM18uV8+Bz05InpHIjCZ2M3WuK7nOxq25/I8UN?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4b283703-c223-4633-9a85-08dbe53dd141 X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB6332.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2023 18:16:27.0788 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rWdRIQ3Spsvzdh3RWJlLURrTOjrSdvMbexw/MI0Jt4R3zyhbV6eVurAE/ZXs9eHyMSMzQmrlOf3M5WcSdH03oA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7747 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hello Tyler, > > since we are duplicating something that comes from something else that > has been duplicated out of windows WDK here it might be a reasonable > safety check to verify that our duplicated values match our > expectations? MEM_COALESCE_PLACEHOLDERS, MEM_PRESERVE_PLACEHOLDER, MEM_REPLACE_PLACEHOLDER and MEM_RESERVE_PLACEHOLDER are defined in Win32 API. DPDK has no expectations about these values. DPDK needs them as parameters to the VirtualX function calls. It looks like the macros were added to EAL because they were missing in mingw. Once compiler environment was fixed, the proper order was restored. Regards, Gregory > > #ifndef MEM_COALESCE_PLACEHOLDERS > #define MEM_COALESCE_PLACEHOLDERS 0x00000001 > #else > static_assert(MEM_COALESCE_PLACEHOLDERS == 0x00000001, "...") > #endif > > either way, this is straight forward. > > Acked-by: Tyler Retzlaff > >