From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Vamsi Attunuru <vattunuru@marvell.com>, <dev@dpdk.org>
Cc: <jerinj@marvell.com>, <ndabilpuram@marvell.com>,
<yux.jiang@intel.com>, <stable@dpdk.org>,
Wei Ling <weix.ling@intel.com>,
Srikanth Yalavarthi <syalavarthi@marvell.com>
Subject: Re: [PATCH v2 1/1] common/cnxk: fix static assertion failure
Date: Thu, 3 Mar 2022 17:21:46 +0000 [thread overview]
Message-ID: <e38786ec-e2df-23e5-6b10-ae12d71a8c15@intel.com> (raw)
In-Reply-To: <20220302134654.2760076-1-vattunuru@marvell.com>
On 3/2/2022 1:46 PM, Vamsi Attunuru wrote:
> Use dynamically allocated memory for storing soft expiry
> ring base addresses which fixes the static assertion failure,
> as the size of dynamic allocation depends on RTE_MAX_ETHPORTS
> which varies based on the build config.
>
Hi Vamsi,
"fix static assertion failure" is not enough descriptive.
assertions already added to verify assumptions, and in this case
it seems it failed, but what was actually wrong?
Is it that allocated memory size for ring wrong? (this is what I got
from commit log but I am not sure)
Can you please describe what actually was wrong and fixed now?
> Bugzilla ID: 940
> Fixes: d26185716d3f ("net/cnxk: support outbound soft expiry notification")
> Cc:stable@dpdk.org
>
> Reported-by: Wei Ling<weix.ling@intel.com>
> Reported-by: Yu Jiang<yux.jiang@intel.com>
> Signed-off-by: Vamsi Attunuru<vattunuru@marvell.com>
> Signed-off-by: Srikanth Yalavarthi<syalavarthi@marvell.com>
> ---
> V2: Add bugzilla & reportee details, remove unused changes.
> ---
next prev parent reply other threads:[~2022-03-03 17:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220302120701.2749772-1-vattunuru@marvell.com>
2022-03-02 13:46 ` Vamsi Attunuru
2022-03-03 5:59 ` Jerin Jacob
2022-03-03 11:54 ` Ling, WeiX
2022-03-03 17:21 ` Ferruh Yigit [this message]
2022-03-04 10:20 ` [EXT] " Vamsi Krishna Attunuru
2022-03-04 11:15 ` Ferruh Yigit
2022-03-04 11:45 ` Vamsi Krishna Attunuru
2022-03-04 13:14 ` Ferruh Yigit
2022-03-04 13:59 ` Vamsi Krishna Attunuru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e38786ec-e2df-23e5-6b10-ae12d71a8c15@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=stable@dpdk.org \
--cc=syalavarthi@marvell.com \
--cc=vattunuru@marvell.com \
--cc=weix.ling@intel.com \
--cc=yux.jiang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).