From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3523DA04A4 for ; Thu, 3 Mar 2022 18:22:04 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2371B4278C; Thu, 3 Mar 2022 18:22:04 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 9F3A740687; Thu, 3 Mar 2022 18:22:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646328122; x=1677864122; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=UIqX9UUFIBp2erywlHKMZO+7zlCdW+pLxe+6EYvsGpc=; b=HZWK9Rx+ZzfIh58TyAAon+MbcKe2amZGHrKectg5t92o7+yVynlL/Rgp pM/HnIUMciHffMPY0bjBmAUNR0Qvlji39Kc7gPV5CP0ksKAV7mgQJ6E23 6QOclQiI5JkJ7pASeilG3l9BmvhxKeFySJLgpoN0EgS0xWyywiwkpFryR SpXqkNOZ4I8qC6HMY8h1+YDP7GlcOs4WrpbyIPLdgYPv/edu/Vew1m4H0 yWflhO4ftaXhNU6GG3P8xn0H1Chl3cCgrZ0NrONu0fRXQBudMSWFM0Cs1 WSsWULoczdFoBuSE+iBAqpDL+Vnkr4kB2tWI9agCyg5SSuq8S6rp9JjVE Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10275"; a="253934245" X-IronPort-AV: E=Sophos;i="5.90,151,1643702400"; d="scan'208";a="253934245" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Mar 2022 09:21:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,151,1643702400"; d="scan'208";a="508670568" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga002.jf.intel.com with ESMTP; 03 Mar 2022 09:21:56 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Thu, 3 Mar 2022 09:21:55 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Thu, 3 Mar 2022 09:21:55 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.176) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.21; Thu, 3 Mar 2022 09:21:55 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cdTgfNo2QPx5VtethBBEeAX28wU4swGoImu8tw2kip83o9aKeIKBme2QfhM3UDBw+4yKELzkaZECceHcCz2ecY8b/UY0SDrew5QQNgkQhQIzkgoeAyVONOQmY26Ns4fFqsI9F7rvkoARnp3KmutFqrQqsvb9am6gwTZOEYAViOimFVcsWsDy6RoxdYOl+84X4UmjdG6O9GoxU48h9Sw5ry3OLY+v1CJDXnWUZ0haPFCJm7YeDIdElW++sUNk+5GcJ7oDfK/So9voMTdsMurIi9k0idy7xuUq+ZbZathQzOLLO716J0bqH8Oh9GkhG7i3xeqcp2i3FBGgGvWGrgdQ5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yrWAXUro14Apo5YeCkp4yUhyb4hTj7y4n6YVt9KQ8fk=; b=WlhwwX2MUSrY8mZcWLUFykD8K+/lOyIvXVN+XuIQF9BBo9q78NfArfLBLbrTYJNsDns8Hq+e+7yRp7CzDMkLG6xQpKb1TueoNOX1n4SOKGzA4qNtYY6oda7AgjuEozJcgqsurR5uYf0PKCJMiCqItF7kjdsdfvC/3ravEUU1SXSkW1me0WMvAamTZTaFubJaXDhEkgAVoHbzQ7vj3y6OgUa55mjXoRZ9dl0cKSnA5zW8Eap7T9SkGify7Tqz1q1Om1qST5JcK+qgE8yE8BeSVqa+z0mZiHXgkSonX0dwkRop3Kcf0dXk05wmqOe9I0vPz+jjA2sQLG4Dhvwnqd7CFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by DM6PR11MB3212.namprd11.prod.outlook.com (2603:10b6:5:5b::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.14; Thu, 3 Mar 2022 17:21:53 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd21:6fbe:8308:2ecf]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd21:6fbe:8308:2ecf%7]) with mapi id 15.20.5038.015; Thu, 3 Mar 2022 17:21:53 +0000 Message-ID: Date: Thu, 3 Mar 2022 17:21:46 +0000 Content-Language: en-US To: Vamsi Attunuru , CC: , , , , Wei Ling , Srikanth Yalavarthi References: <20220302120701.2749772-1-vattunuru@marvell.com> <20220302134654.2760076-1-vattunuru@marvell.com> From: Ferruh Yigit Subject: Re: [PATCH v2 1/1] common/cnxk: fix static assertion failure X-User: ferruhy In-Reply-To: <20220302134654.2760076-1-vattunuru@marvell.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0274.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a1::22) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 65c9be2a-f54e-4df5-8c6b-08d9fd3a4f38 X-MS-TrafficTypeDiagnostic: DM6PR11MB3212:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: k6P7e+Rcr5sAsn4DUNZuPTVZ3dlxXoyfBf1DhLQPtTR0dJzRPejGAuE1HU9MWzhFU2L+WKsAA7B6PX1ZPRH3YWAjqYmWVXfsnyy/udj1+E9JZV5Su1Nr4P6WMnTP2CnxKE7YrNvyL9+X5OTtQ/lQqF2bJX9TZ+i1Dmvgm2ytQh+U3/SoNl2QE1PHLfL47F9QR5gXaCkYPhFg0024qItvRnaJ+nix0UIdflJGzVSRRV+W/jQLDV939q9WHTv8a9upt5yMiEgokEkGUdStrwXVelvnkvO2qg4Dcg5wqkDDofsAhIDSWYW5kT1nJRbo/46MeL+6v11TfuMd+lPeIq2Q1Vo1abqdZECOG9q/2nLSjCQdrvGcjIRg2kBZDtm4IksCh7Jr/xSSYpoC5wRFx5nQS3BGeNzuNZYSsXFIdzL/disvOUgxFTFaloIwGmKAKcFUGz06KwbKfRy3bwCx3Jwg7kOe89dYH4PnFpNEEbg4Er2ksN8SCYyWv7YkE2X+lZ/SFejeQ7V5eTZeYyXM3MgsNCAsRXNVl+fCnveBkzW5e3pdnwVuFDkf8lVKmaBHZJNmwX8l0gvT9N2PbLV4i39bYHj4nT35bMGb6kAS2a+p8vlPxkYLx94KqgzMPqZuA9Njmt0ITvDVfTq+XFluAyoD6MvvdUwn6+xsJATpqzrVbOt9yZ0ttPhFUFuAmRGpy0J1a3s4JyeDBh8wcqmZZ+0w6g== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(508600001)(6666004)(186003)(83380400001)(66946007)(4326008)(8676002)(66476007)(6486002)(66556008)(5660300002)(8936002)(54906003)(31686004)(316002)(44832011)(2906002)(36756003)(2616005)(26005)(53546011)(6506007)(38100700002)(6512007)(82960400001)(31696002)(86362001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QXpSelU1aTNWTE1PbERWTWU4RndRekZuOUZaYTZaVW9LYnJEY1ZMVmU3aUpn?= =?utf-8?B?bk9UcGhER3EyaDltL2FpNk9uaW9GaTEyUElNc1duZmswMGRaUzZqQmV6dHVN?= =?utf-8?B?TzZ2RWwrS1pYOG1ZSHdaNGNxOE1xUDZwRFBadGZMZFNCLzdlMmZSYXdadzZF?= =?utf-8?B?MVRheCtFaDV0OFgyN1hCNnRjU3Y5LzdQZDZiazdlblFpcTUxbzZCSE5jdFdy?= =?utf-8?B?aDU0bTlvYmxZeis5WDBuSFhmd3l5TkZtdkRPcFJrUDgzdSsvbnJ6eWxVaTI0?= =?utf-8?B?am0wWTQ3NDlqY1RuZHQ4bFVZck1lSzRNek1pcjBQSUtxV0ovSHp1WlRib2I1?= =?utf-8?B?K3VJTEVnMG85WjlyYi8zaTluSTRTNVZNQ3JZSUFPeWRzV05TSUVPNUhpQkhl?= =?utf-8?B?dXhFS0RFUGZRcldXN1A1QnVIN3pxWUY0dzVUWFNaYm9ZMzB3SERaOGM0elY4?= =?utf-8?B?ajBnb216OUl1ZnhQRjNNZkMvdzRVaGNpSTFvMzhjUHd4dlNkRDFzSUxodDgr?= =?utf-8?B?cldxTTNJRVdjaG0vbjRUeGhtbXJaNjkvVWlIZDBISzlNSytrbWhXT0FDUE81?= =?utf-8?B?dGpTK1J5WUQxbFFDUnh6Z2Q4bnNDdFVDWUFraFZCNnB5TkYxdWI0S3ZGdFZo?= =?utf-8?B?cmZ0RHdpZmltRkc0ODNiZ0hzTjh0MHE2TGZGVlY2N1Z6K0dLVlRhNHp4WFN6?= =?utf-8?B?UWg4THNSZFpEMkZka0tKT3lnTVNBYm5oR0cya3ZGS3hqV1NTZ1lMZVFtM2lz?= =?utf-8?B?WDV3OW1HNkphdXJRODJHbzZKRlZybWtiL05VeWxuSGYzT3JvaWE4dzN1bExy?= =?utf-8?B?VVc2S3M4MmZ6SGQ5NTdRUHNDVWpKTk9KUG9OcEJtZ05aWjhsMFVzSWxIWDRE?= =?utf-8?B?UzhKckFIUlhoWVVkN1BIRWZVdWpKbnhkaUcya3cvZUpXd2V3enpLRm12VXBF?= =?utf-8?B?K0loY1V2K3hDK2ttS2ZFRnpMMzVkWGJGR3VocjBldXNIa2dDSG83aTdKMkwr?= =?utf-8?B?LzJwZ1dmSEFzS05US3dXMFJNaUo5b3laS2o4RDEzbVZaQUlBRjlVVDB2R2VR?= =?utf-8?B?MnFCTXVUbFJOZ2hrMk9RL1d4TzZ5WWoyWjRkaTZQOXV5WkI2aEsvdVBDc1A1?= =?utf-8?B?ZmhyUW1hUm85MW5JejdvNElyc2U3ZEVsOTJURmMzMlRkVWZ0akgvakpEd0FP?= =?utf-8?B?N0R3eDE2ZFR6LzNMcHluZ0k0ZHY3N0xVWGxMQ2E4N01tcy9tUFhuSUxuMVRR?= =?utf-8?B?c29odG9OQUNjRmpjNmFBSUZZK0JnZkxiaEtXT0tZd09XRURPSExmMEpXZmVq?= =?utf-8?B?QWJ1SEI1OVAxMUt6VTJHTzF6d3MyUWZGVTV2cWUxRlpyK3ZTWTlmcTFXT2VO?= =?utf-8?B?Yk1kYWZ2Z3JiU0ZSa2Rub3hTVlU2NTh2RUVpbXRnUEw0ZHgydC90SHpxS3dL?= =?utf-8?B?enhnSkQ4NDFZU2JOd1EzQVFjcUxxelJkcDJtMVMrbnVKMlY4TzIvMXRMQlhY?= =?utf-8?B?UDR0SlMrNnFQZElOQU9qZVloS2hpQUFyZUxzeUFFallIYnhhZjdXNklSS0J1?= =?utf-8?B?MERxTWVCa0pzRmN4T0NEK1VxYjhLcC9wN0ZPU00yM0ZSY2U5eVNNNHJyTHFE?= =?utf-8?B?VDRoQU9IWEdBT0NSOVB5S2xxcU1IUlVtUjc0Ym42WmNTRk9MNWpJVG1qUlhj?= =?utf-8?B?aDN4SWticUxFZTI0VzA5TE11OVA5SmtRRVRBMmpBa1VaWGx1WTlUUEtKOWx2?= =?utf-8?B?eTBuZG5wZVRIS1lBT21kWG9vVjNYQW91cU1HNGxOMUNvbWxmWGMvUlRKZEFo?= =?utf-8?B?N2RmdTg4YzgxQkNVNFdWcHFUaCtYZXRlcTRaUSs4SDRWZXpZYXhNMElsRXRo?= =?utf-8?B?RVZyKzFsTXZFWFZCdUtUVXoweUdYZ1g5WVFuL3NkRUxudWY1MmoxRm5nU1Jn?= =?utf-8?B?RzlMN2QxR1ZabC9DUUN4Rmx2UUgwanQrSDNqUzRUTEpVUjRwRzhXMFZVbkkv?= =?utf-8?B?VkwyWC90bGpaMlgvbk80Y1FNQlpCVDlkWWFkZlkwR0RMd3ZYOHFLS1EzUCtN?= =?utf-8?B?clQyb1IvbnhtVXE1MlVTUUJOc1Jtc2c1Qi9oVmVFMnB4aHkweGxQVXY2NnRF?= =?utf-8?B?L2YrdzREcVpjaStYOFg0NUpIMTZuTC9GbjJCd2wxNTQ4WjZJaDlUMDRGK1Zx?= =?utf-8?Q?TiuRMD464ov90Ib5VT6gpGs=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 65c9be2a-f54e-4df5-8c6b-08d9fd3a4f38 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2022 17:21:53.2265 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nOAGMEOWhscpjyiGgYIEWStKPE0nCt4upOrdFO0bf6UtLLCoe23OpFt9IPrhvLjNwJDHLo30LcZfuhWVt9d7MQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3212 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 3/2/2022 1:46 PM, Vamsi Attunuru wrote: > Use dynamically allocated memory for storing soft expiry > ring base addresses which fixes the static assertion failure, > as the size of dynamic allocation depends on RTE_MAX_ETHPORTS > which varies based on the build config. > Hi Vamsi, "fix static assertion failure" is not enough descriptive. assertions already added to verify assumptions, and in this case it seems it failed, but what was actually wrong? Is it that allocated memory size for ring wrong? (this is what I got from commit log but I am not sure) Can you please describe what actually was wrong and fixed now? > Bugzilla ID: 940 > Fixes: d26185716d3f ("net/cnxk: support outbound soft expiry notification") > Cc:stable@dpdk.org > > Reported-by: Wei Ling > Reported-by: Yu Jiang > Signed-off-by: Vamsi Attunuru > Signed-off-by: Srikanth Yalavarthi > --- > V2: Add bugzilla & reportee details, remove unused changes. > ---