From: Kevin Traynor <ktraynor@redhat.com>
To: Long Li <longli@linuxonhyperv.com>,
Stephen Hemminger <sthemmin@microsoft.com>
Cc: "Dey, Souvik" <sodey@rbbn.com>, Long Li <longli@microsoft.com>,
stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH] net/netvsc: fix rndis packet addresses
Date: Thu, 24 Sep 2020 11:03:51 +0100 [thread overview]
Message-ID: <e46c9567-2d24-2c55-7924-f24d86a5ed12@redhat.com> (raw)
In-Reply-To: <1600455227-3709-1-git-send-email-longli@linuxonhyperv.com>
On 18/09/2020 19:53, Long Li wrote:
> From: Long Li <longli@microsoft.com>
>
> The address should be calculated before type cast, not after.
>
> Fixes: cc02518 ("net/netvsc: split send buffers from Tx descriptors")
> Cc: stable@dpdk.org
>
> Reported-by: Souvik Dey <sodey@rbbn.com>
> Signed-off-by: Long Li <longli@microsoft.com>
> ---
> drivers/net/netvsc/hn_rxtx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/netvsc/hn_rxtx.c b/drivers/net/netvsc/hn_rxtx.c
> index 813f8c3cc..70f8b8332 100644
> --- a/drivers/net/netvsc/hn_rxtx.c
> +++ b/drivers/net/netvsc/hn_rxtx.c
> @@ -160,8 +160,8 @@ static void hn_txd_init(struct rte_mempool *mp __rte_unused,
>
> txd->queue_id = txq->queue_id;
> txd->chim_index = NVS_CHIM_IDX_INVALID;
> - txd->rndis_pkt = (struct rndis_packet_msg *)(char *)txq->tx_rndis
> - + idx * HN_RNDIS_PKT_ALIGNED;
> + txd->rndis_pkt = (struct rndis_packet_msg *)((char *)txq->tx_rndis
> + + idx * HN_RNDIS_PKT_ALIGNED);
> }
>
> int
>
Applied to 18.11 branch (to be part of 18.11.10), Thanks.
prev parent reply other threads:[~2020-09-24 10:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 18:53 Long Li
2020-09-21 13:50 ` Ferruh Yigit
2020-09-21 16:04 ` [dpdk-stable] [dpdk-dev] " Kevin Traynor
2020-09-21 16:06 ` Kevin Traynor
2020-09-21 16:19 ` Kevin Traynor
2020-09-21 19:09 ` Long Li
2020-09-24 10:03 ` Kevin Traynor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e46c9567-2d24-2c55-7924-f24d86a5ed12@redhat.com \
--to=ktraynor@redhat.com \
--cc=longli@linuxonhyperv.com \
--cc=longli@microsoft.com \
--cc=sodey@rbbn.com \
--cc=stable@dpdk.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).