From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (xvm-189-124.dc0.ghst.net [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4C791A052A for ; Thu, 7 Jan 2021 16:33:38 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 40B4B140FE9; Thu, 7 Jan 2021 16:33:38 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 2EC66140FE0; Thu, 7 Jan 2021 16:33:36 +0100 (CET) IronPort-SDR: iBLmYTjH86gGVWhjwehvHVI0JBOGnqsMrRpsSpjQKNJ3JGoxLw8wlX6QkVHHCNX1DTMV+KaKJ/ upe4AxhNS1Hg== X-IronPort-AV: E=McAfee;i="6000,8403,9857"; a="177539157" X-IronPort-AV: E=Sophos;i="5.79,329,1602572400"; d="scan'208";a="177539157" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jan 2021 07:33:35 -0800 IronPort-SDR: 5b1FHxhS+m2DMQXfeOHQJRndDHWPvwvslWUvcTQR6GcxzOYTo8Eq7fxfOVn7Juo1M03ijgoxqa C6cLMVr6lkkA== X-IronPort-AV: E=Sophos;i="5.79,329,1602572400"; d="scan'208";a="362002181" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.29.165]) ([10.252.29.165]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jan 2021 07:33:33 -0800 To: Lance Richardson Cc: Lance Richardson , Ajit Khaparde , Somnath Kotur , Venkat Duvvuru , dev@dpdk.org, stable@dpdk.org References: <20201214185352.252477-1-lance.richardson@broadcom.com> From: Ferruh Yigit Message-ID: Date: Thu, 7 Jan 2021 15:33:29 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/bnxt: limit per-poll Rx representor pkts X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 1/6/2021 8:54 PM, Lance Richardson wrote: > On Wed, Jan 6, 2021 at 4:27 AM Ferruh Yigit wrote: >> >> On 12/14/2020 6:53 PM, Lance Richardson wrote: >>> Limit number of representor packets transferred per poll >>> to requested burst size. >>> >> >> Hi Lance, >> >> Can you please describe the impact of the change? Since it has a fixes line, it >> seems it is fixing something but it is not clear what is fixed. >> > Hi Ferruh, > > How does this look: > > Without some limit on the number of packets transferred from the > hw ring to the representor ring per burst receive call, an entire ring's > worth of packets can be transferred. This can break assumptions > about ring indices (index on return could be identical to the index > on entry, which is assumed to mean that no packets were processed), > and can result in representor packets being dropped unnecessarily > due to representor ring overflow. > > Fix by limiting the number of representor packets transferred per > poll to requested burst size. > Thank you, updated the commit log in next-net.