From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 024CDA0505 for ; Thu, 24 Mar 2022 09:52:28 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EC85342818; Thu, 24 Mar 2022 09:52:27 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 858DF40141; Thu, 24 Mar 2022 09:52:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1648111945; x=1679647945; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=GvI0MX7yj4PIqAZA/2WPd092T5A2T868NyT1sfG7zho=; b=dHlJM2rwk7Jce7EM3oiro39/6Fx5xFoqJqD8zRRTpjOYx6JhFmEU35LD qCbKkmsPDVh76UwmJ4JhVMC1GH2AmcDooan6ibx0kKT554ZB9h20TpfES jORnC1bBrMBnppmS65jmImmVHXbX20aE1YvxwUkgbJ0vxUjamAux1rFI8 NedAKa0GlRBfDYHu9vS1tW+L9bHBok3Bcgk5AMdl33JiiYptRGcllU6JR MjbsmkEz4aJThnaqj8blvYpPnrdP6KHEFF5Yffgk+3iaBPn998Zgz2Rmo 8PW8F5+oehfy8CU6H1zy3o6FfCEGqGq0w5K5bI6EXlPEf4ijzoQOyHjoR g==; X-IronPort-AV: E=McAfee;i="6200,9189,10295"; a="238923459" X-IronPort-AV: E=Sophos;i="5.90,206,1643702400"; d="scan'208";a="238923459" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Mar 2022 01:52:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,206,1643702400"; d="scan'208";a="544555976" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga007.jf.intel.com with ESMTP; 24 Mar 2022 01:52:23 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 24 Mar 2022 01:52:23 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX601.ccr.corp.intel.com (10.109.6.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Thu, 24 Mar 2022 16:52:21 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.2308.021; Thu, 24 Mar 2022 16:52:21 +0800 From: "Zhang, Qi Z" To: "Xing, Beilei" , "Yang, SteveX" , "dev@dpdk.org" CC: "Wu, Jingjing" , "stable@dpdk.org" Subject: RE: [PATCH v1] net/iavf: fix select wrong scan hw ring by rxdid Thread-Topic: [PATCH v1] net/iavf: fix select wrong scan hw ring by rxdid Thread-Index: AQHYN4dahl0rsd5jWk28+jHLv/kJ3azBJbqAgA0kGIA= Date: Thu, 24 Mar 2022 08:52:21 +0000 Message-ID: References: <20220314093146.697256-1-stevex.yang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.401.20 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org > -----Original Message----- > From: Xing, Beilei > Sent: Wednesday, March 16, 2022 4:12 PM > To: Yang, SteveX ; dev@dpdk.org > Cc: Wu, Jingjing ; Zhang, Qi Z > ; stable@dpdk.org > Subject: RE: [PATCH v1] net/iavf: fix select wrong scan hw ring by rxdid >=20 >=20 >=20 > > -----Original Message----- > > From: Yang, SteveX > > Sent: Monday, March 14, 2022 5:32 PM > > To: dev@dpdk.org > > Cc: Wu, Jingjing ; Xing, Beilei > > ; Zhang, Qi Z ; Yang, > > SteveX ; stable@dpdk.org > > Subject: [PATCH v1] net/iavf: fix select wrong scan hw ring by rxdid > > > > When setup RX queue, the rxdid would be changed if it's > > "IAVF_RXDID_LEGACY_0/1", that caused the scan hw ring used the wrong > > function 'iavf_rx_scan_hw_ring_flex_rxd()'. > > > > Ignore the rxdid changed when equals "IAVF_RXDID_LEGACY_0/1". > > > > Fixes: 0ed16e01313e ("net/iavf: fix function pointer in > > multi-process") > > Cc: stable@dpdk.org > > > > Signed-off-by: Steve Yang > > --- > > drivers/net/iavf/iavf_rxtx.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/net/iavf/iavf_rxtx.c > > b/drivers/net/iavf/iavf_rxtx.c index 16e8d021f9..3b16609f7d 100644 > > --- a/drivers/net/iavf/iavf_rxtx.c > > +++ b/drivers/net/iavf/iavf_rxtx.c > > @@ -477,6 +477,8 @@ iavf_rxd_to_pkt_fields_by_comms_aux_v2(struct > > iavf_rx_queue *rxq, > > > > static const > > iavf_rxd_to_pkt_fields_t rxd_to_pkt_fields_ops[IAVF_RXDID_LAST + 1] = =3D > > { > > + [IAVF_RXDID_LEGACY_0] =3D iavf_rxd_to_pkt_fields_by_comms_ovs, > > + [IAVF_RXDID_LEGACY_1] =3D iavf_rxd_to_pkt_fields_by_comms_ovs, > > [IAVF_RXDID_COMMS_AUX_VLAN] =3D > > iavf_rxd_to_pkt_fields_by_comms_aux_v1, > > [IAVF_RXDID_COMMS_AUX_IPV4] =3D > > iavf_rxd_to_pkt_fields_by_comms_aux_v1, > > [IAVF_RXDID_COMMS_AUX_IPV6] =3D > > iavf_rxd_to_pkt_fields_by_comms_aux_v1, > > @@ -521,6 +523,8 @@ iavf_select_rxd_to_pkt_fields_handler(struct > > iavf_rx_queue *rxq, uint32_t rxdid) > > > > rte_pmd_ifd_dynflag_proto_xtr_ipsec_crypto_said_mask; > > break; > > case IAVF_RXDID_COMMS_OVS_1: > > + case IAVF_RXDID_LEGACY_0: > > + case IAVF_RXDID_LEGACY_1: > > break; > > default: > > /* update this according to the RXDID for FLEX_DESC_NONE > */ > > -- > > 2.27.0 >=20 > Acked-by: Beilei Xing Applied to dpdk-next-net-intel. Thanks Qi