From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ED0C3A0C4E for ; Thu, 7 Oct 2021 06:24:19 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DB11A41161; Thu, 7 Oct 2021 06:24:19 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 76CB74067A; Thu, 7 Oct 2021 06:24:17 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10129"; a="224933406" X-IronPort-AV: E=Sophos;i="5.85,352,1624345200"; d="scan'208";a="224933406" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2021 21:24:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,352,1624345200"; d="scan'208";a="715031298" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga005.fm.intel.com with ESMTP; 06 Oct 2021 21:24:03 -0700 Received: from shsmsx602.ccr.corp.intel.com (10.109.6.142) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 6 Oct 2021 21:24:02 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX602.ccr.corp.intel.com (10.109.6.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 7 Oct 2021 12:24:00 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.2242.012; Thu, 7 Oct 2021 12:24:00 +0800 From: "Zhang, Qi Z" To: "Guo, Junfeng" , "Wu, Jingjing" , "Xing, Beilei" CC: "dev@dpdk.org" , "stable@dpdk.org" , "Yigit, Ferruh" , "Liu, Lingyu" Thread-Topic: [PATCH v2] net/iavf: fix QFI field bit check for GTPU EH Thread-Index: AQHXtOy/skbbmTsMaUi1ruOhQ4RHz6vG/Amw Date: Thu, 7 Oct 2021 04:24:00 +0000 Message-ID: References: <20210929111307.422672-1-junfeng.guo@intel.com> <20210929123134.1465507-1-junfeng.guo@intel.com> In-Reply-To: <20210929123134.1465507-1-junfeng.guo@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH v2] net/iavf: fix QFI field bit check for GTPU EH X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > -----Original Message----- > From: Guo, Junfeng > Sent: Wednesday, September 29, 2021 8:32 PM > To: Zhang, Qi Z ; Wu, Jingjing ; > Xing, Beilei > Cc: dev@dpdk.org; stable@dpdk.org; Yigit, Ferruh = ; > Guo, Junfeng ; Liu, Lingyu > Subject: [PATCH v2] net/iavf: fix QFI field bit check for GTPU EH >=20 > If GTPU Extionsion header has no pdu_type setting, the parsed value of > gtp_psc_spec->pdu_type will be 0, which is same as IAVF_GTPU_EH_DWLINK. > Thus, for this case, we should check gtp_psc_mask->pdu_type instead, to s= et > QFI field bit of GTPU_EH first. >=20 > Fixes: 45cc3a5435fc ("net/iavf: fix QFI fields of GTPU UL/DL for FDIR") > Cc: stable@dpdk.org >=20 > Signed-off-by: Junfeng Guo The patch can't be applied due to below commit commit 16b8e92d49b87705fffbedd9c3241204d9a584a6 Author: Raslan Darawsheh Date: Mon Aug 23 13:55:39 2021 +0300 ethdev: use extension header for GTP PSC item This updates the gtp_psc flow item to use the net header definition of the gtp_psc to be based on RFC 38415-g30 Signed-off-by: Raslan Darawsheh Acked-by: Ferruh Yigit Could you rebase? Thanks Qi > --- > drivers/net/iavf/iavf_fdir.c | 12 +++++------- > 1 file changed, 5 insertions(+), 7 deletions(-) >=20 > diff --git a/drivers/net/iavf/iavf_fdir.c b/drivers/net/iavf/iavf_fdir.c = index > 560589a496..227a089ce0 100644 > --- a/drivers/net/iavf/iavf_fdir.c > +++ b/drivers/net/iavf/iavf_fdir.c > @@ -1171,17 +1171,15 @@ iavf_fdir_parse_pattern(__rte_unused struct > iavf_adapter *ad, > if (gtp_psc_spec && gtp_psc_mask) { > if (gtp_psc_mask->qfi =3D=3D UINT8_MAX) { > input_set |=3D IAVF_INSET_GTPU_QFI; > - if (gtp_psc_spec->pdu_type =3D=3D > - IAVF_GTPU_EH_UPLINK) > + if (!gtp_psc_mask->pdu_type) > VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr, > - GTPU_UP, QFI); > - else if (gtp_psc_spec->pdu_type =3D=3D > - IAVF_GTPU_EH_DWLINK) > + GTPU_EH, QFI); > + else if (gtp_psc_spec->pdu_type =3D=3D > IAVF_GTPU_EH_DWLINK) > VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr, > GTPU_DWN, QFI); > - else > + else if (gtp_psc_spec->pdu_type =3D=3D > IAVF_GTPU_EH_UPLINK) > VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr, > - GTPU_EH, QFI); > + GTPU_UP, QFI); > } >=20 > rte_memcpy(hdr->buffer, gtp_psc_spec, > -- > 2.25.1