From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 6690E23D; Tue, 30 Oct 2018 11:32:01 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Oct 2018 03:32:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,444,1534834800"; d="scan'208";a="103735689" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.72]) ([10.237.220.72]) by fmsmga001.fm.intel.com with ESMTP; 30 Oct 2018 03:31:59 -0700 To: Thomas Monjalon Cc: stable@dpdk.org, dev@dpdk.org, stephen@networkplumber.org, Stephen Hemminger References: <20180725182019.31518-4-stephen@networkplumber.org> <7632620e2d7fbf772965b2d15b8187df6648a375.1540565496.git.anatoly.burakov@intel.com> <4092104.WkhJc3HfzQ@xps> From: "Burakov, Anatoly" Message-ID: Date: Tue, 30 Oct 2018 10:31:58 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <4092104.WkhJc3HfzQ@xps> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-stable] [PATCH] eal/mp: remove rte_panic and profanity X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Oct 2018 10:32:02 -0000 On 26-Oct-18 9:41 PM, Thomas Monjalon wrote: > 26/10/2018 16:55, Anatoly Burakov: >> --- a/lib/librte_eal/common/eal_common_proc.c >> +++ b/lib/librte_eal/common/eal_common_proc.c >> + /* >> + * set the alarm before sending message. there are two possible error >> + * scenarios to consider here: >> + * >> + * - if the alarm set fails, we free the memory right there >> + * - if the alarm set succeeds but sending message fails, then the alarm >> + * will trigger and clean up the memory >> + * >> + * Even if the alarm triggers too early (i.e. immediately), we're still >> + * holding the lock to pending requests queue, so the interrupt thread >> + * will just spin until we release the lock, and either release the >> + * memory, or doesn't find any pending requests in the queue because we >> + * never added any due to send message failure. >> + */ >> + if (rte_eal_alarm_set(ts->tv_sec * 1000000 + ts->tv_nsec / 1000, >> + async_reply_handle, pending_req) < 0) { >> + RTE_LOG(ERR, EAL, "Fail to set alarm for request %s:%s\n", >> + dst, req->name); >> + goto fail; >> + } > > ret variable is not set and not initialized. > Oh, right. Apologies. Will send a v2. -- Thanks, Anatoly