Re: 21.11.3 patches review and test

[Kevin Traynor <ktraynor@redhat.com>]

On 15/12/2022 03:44, Jiang, YuX wrote:
> Hi All,
> 

Hi Yu Jiang. Thanks for testing this. Some comments below.

> Update the test status for Intel part. dpdk21.11.3-rc1 validation test is almost finished, no critical issue is found.
> Total find 3 bugs, 2 bugs are fixed on latest stable 21.11.
> BUG1: vf_interrupt_pmd/nic_interrupt_VF_vfio_pci: l3fwd-power Wake up failed on X722 37d0
> 	- Find on DPDK22.11, it has fix patch: https://patchwork.dpdk.org/project/dpdk/patch/20221117065726.277672-1-kaisenx.you@intel.com/
> 	- This patch still have comment, need Intel dev continue to investigate.

This does not look resolved or ready for being applied into DPDK main 
branch. I should not take it into 21.11 until that is the case, so as it 
is not critical issue regression, it seems it will have to be fixed in 
21.11.4.

That patch is listed as a fix for other patch [1] that has just been 
backported to 21.11.3-rc1, so I will revert that for 21.11.3, and we 
will have same behaviour in 21.11.3 as 21.11/21.11.1/21.11.2. Corrected 
fixes can be applied for 21.11.4.

[1]
commit cb5c1b91f76f436724cd09f26c7432b2775b519c
Author: Yiding Zhou <yidingx.zhou@intel.com>
Date:   Thu Oct 20 13:00:22 2022 +0800

     net/iavf: add thread for event callbacks

     All callbacks registered for ethdev events are called in
     eal-intr-thread, and some of them execute virtchnl commands.
     Because interrupts are disabled in the intr thread, no response
     will be received for these commands. So all callbacks should
     be called in a new context.

     When the device is bonded, the bond pmd registers a callback for
     the LSC event to execute virtchnl commands to reinitialize the
     device, and it would also raise the above issue.

     This commit adds a new thread to call all event callbacks.

     Fixes: 48de41ca11f0 ("net/avf: enable link status update")
     Fixes: 84108425054a ("net/iavf: support asynchronous virtual 
channel message")
     Cc: stable@dpdk.org

     Signed-off-by: Yiding Zhou <yidingx.zhou@intel.com>
     Acked-by: Qi Zhang <qi.z.zhang@intel.com>

thanks,
Kevin.


> # Basic Intel(R) NIC testing
> * Build&CFLAG compile: cover the build test combination with latest GCC/Clang version and the popular OS revision such as Ubuntu20.04&22.04, Fedora36, RHEL8.4, etc.
>    - All test passed.
> * PF(i40e, ixgbe): test scenarios including RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
>    - All test done. No new dpdk issue is found.
> * VF(i40e, ixgbe): test scenarios including VF-RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.		
>    - All test done. Only find one bug as the above BUG1.
> * PF/VF(ice): test scenarios including Switch features/Package Management/Flow Director/Advanced Tx/Advanced RSS/ACL/DCF/Flexible Descriptor, etc.
>    - All test done. No new dpdk issue is found.
> * Intel NIC single core/NIC performance: test scenarios including PF/VF single core performance test, etc.
>    - All test done. No big performance drop.
> * IPsec: test scenarios including ipsec/ipsec-gw/ipsec library basic test - QAT&SW/FIB library, etc.
>    - All test done.
> * Power: test scenarios including bi-direction/Telemetry/Empty Poll Lib/Priority Base Frequency, etc.
>    - All test passed.	
> # Basic cryptodev and virtio testing
> * Virtio: both function and performance test are covered. Such as PVP/Virtio_loopback/virtio-user loopback/virtio-net VM2VM perf testing/VMAWARE ESXI 7.0u3, etc.
>      - All test done.
> * Cryptodev:
>    *Function test: test scenarios including Cryptodev API testing/CompressDev ISA-L/QAT/ZLIB PMD Testing/FIPS, etc.
>      - All test done.
>    *Performance test: test scenarios including Thoughput Performance /Cryptodev Latency, etc.
>      - All test done. No big performance drop.
> 
> Best regards,
> Yu Jiang
> 
>> -----Original Message-----
>> From: Kevin Traynor <ktraynor@redhat.com>
>> Sent: Tuesday, December 6, 2022 7:30 PM
>> To: stable@dpdk.org
>> Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>;
>> Ali Alnubani <alialnu@nvidia.com>; Walker, Benjamin
>> <benjamin.walker@intel.com>; David Christensen <drc@linux.vnet.ibm.com>;
>> Hemant Agrawal <hemant.agrawal@nxp.com>; Stokes, Ian
>> <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; Mcnamara, John
>> <john.mcnamara@intel.com>; Ju-Hyoung Lee <juhlee@microsoft.com>; Kevin
>> Traynor <ktraynor@redhat.com>; Luca Boccassi <bluca@debian.org>; Pei
>> Zhang <pezhang@redhat.com>; Xu, Qian Q <qian.q.xu@intel.com>; Raslan
>> Darawsheh <rasland@nvidia.com>; Thomas Monjalon
>> <thomas@monjalon.net>; yanghliu@redhat.com; Peng, Yuan
>> <yuan.peng@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>
>> Subject: 21.11.3 patches review and test
>>
>> Hi all,
>>
>> Here is a list of patches targeted for stable release 21.11.3.
>>
>> The planned date for the final release is 19th December.
>>
>> Please help with testing and validation of your use cases and report any
>> issues/results with reply-all to this mail. For the final release the fixes and
>> reported validations will be added to the release notes.
>>
>> A release candidate tarball can be found at:
>>
>>      https://dpdk.org/browse/dpdk-stable/tag/?id=v21.11.3-rc1
>>
>> These patches are located at branch 21.11 of dpdk-stable repo:
>>      https://dpdk.org/browse/dpdk-stable/
>>
>> Thanks.
>>
>> Kevin
>>
>> ---
>