From: Pallavi Kadam <pallavi.kadam@intel.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
David Marchand <david.marchand@redhat.com>,
dev@dpdk.org
Cc: thomas@monjalon.net, stable@dpdk.org,
Wenzhuo Lu <wenzhuo.lu@intel.com>,
Jingjing Wu <jingjing.wu@intel.com>,
Bernard Iremonger <bernard.iremonger@intel.com>,
Anatoly Burakov <anatoly.burakov@intel.com>,
Ranjit Menon <ranjit.menon@intel.com>
Subject: Re: [dpdk-stable] [PATCH v2] app/testpmd: report invalid command line parameter
Date: Tue, 19 Nov 2019 11:18:40 -0800 [thread overview]
Message-ID: <e88aa6d0-9387-7c9a-b04c-31ec3ecf334c@intel.com> (raw)
In-Reply-To: <6d3650f1-4b00-9e58-c31b-cfb57d21bf60@intel.com>
On 11/18/2019 8:18 AM, Ferruh Yigit wrote:
> On 11/18/2019 3:37 PM, David Marchand wrote:
>> We currently do not check that a non option string has been passed to
>> testpmd.
>>
>> Example:
>> $ ./master/app/testpmd --no-huge -m 512 --vdev net_null0 \
>> --vdev net_null1 -- -i nb-cores=2 --total-num-mbuf 2048
>> [...]
>> testpmd> show config fwd
>> io packet forwarding - ports=2 - cores=1 - streams=2 - NUMA support
>> enabled, MP allocation mode: native
>> Logical Core 1 (socket 0) forwards packets on 2 streams:
>> RX P=0/Q=0 (socket 0) -> TX P=1/Q=0 (socket 0) peer=02:00:00:00:00:01
>> RX P=1/Q=0 (socket 0) -> TX P=0/Q=0 (socket 0) peer=02:00:00:00:00:00
>>
>> Here nb-cores=2 is just ignored, while the (probably sleepy) user did not
>> notice this.
>>
>> Validate that all strings passed to testpmd are part of a known option.
>>
>> After this patch:
>> $ ./master/app/testpmd --no-huge -m 512 --vdev net_null0 \
>> --vdev net_null1 -- -i nb-cores=2 --total-num-mbuf 2048
>> [...]
>> Invalid parameter: nb-cores=2
>> EAL: Error - exiting with code: 1
>> Cause: Command line incorrect
>>
>> While at it, when passing an unknown option, print the string that gets
>> refused by getopt_long to help the user.
>>
>> Fixes: af75078fece3 ("first public release")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: David Marchand <david.marchand@redhat.com>
>> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> ---
>> This seems a bit dangerous to take this kind of change this late.
>> Some "working fine" scripts might now report failures from testpmd because
>> of garbage in the command line.
>>
>> Sending the patch anyway to see what others think about it.
>>
>> Changelog since v1:
>> - fixed example in commitlog,
>>
>> ---
>> app/test-pmd/parameters.c | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
>> index deca7a6828..2e7a504415 100644
>> --- a/app/test-pmd/parameters.c
>> +++ b/app/test-pmd/parameters.c
>> @@ -1363,12 +1363,19 @@ launch_args_parse(int argc, char** argv)
>> break;
>> default:
>> usage(argv[0]);
>> + printf("Invalid option: %s\n", argv[optind]);
>> rte_exit(EXIT_FAILURE,
>> "Command line is incomplete or incorrect\n");
>> break;
>> }
>> }
>>
>> + if (optind != argc) {
> I hope 'optind' works as expected [1] in Windows too (Anatoly verified the
> FreeBSD one).
>
> @Pallavi, @Ranjit, Can you please confirm it?
>
> [1]
> https://linux.die.net/man/3/optind
> "
> If there are no more option characters, getopt() returns -1. Then optind is the
> index in argv of the first argv-element that is not an option.
> "
Verified on Windows. So far this change does not affect Windows code.
Also, Windows does not support testpmd app yet.
next prev parent reply other threads:[~2019-11-19 19:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-17 17:10 [dpdk-stable] [PATCH] " David Marchand
2019-11-17 17:12 ` David Marchand
2019-11-18 10:37 ` Ferruh Yigit
2019-11-18 15:37 ` [dpdk-stable] [PATCH v2] " David Marchand
2019-11-18 16:18 ` Ferruh Yigit
2019-11-19 19:18 ` Pallavi Kadam [this message]
2019-11-20 12:18 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e88aa6d0-9387-7c9a-b04c-31ec3ecf334c@intel.com \
--to=pallavi.kadam@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jingjing.wu@intel.com \
--cc=ranjit.menon@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).