From: Luca Boccassi <bluca@debian.org>
To: Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org
Cc: stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] igb_uio: fix build on Linux 5.3 for implicit fall through
Date: Tue, 24 Sep 2019 19:25:08 +0100 [thread overview]
Message-ID: <e8ea6d4e5c8b4424dc88cedb1dff79d9af022d41.camel@debian.org> (raw)
In-Reply-To: <20190729123216.64601-1-ferruh.yigit@intel.com>
On Mon, 2019-07-29 at 13:32 +0100, Ferruh Yigit wrote:
> build error:
> .../dpdk/build/build/kernel/linux/igb_uio/igb_uio.c:
> In function ‘igbuio_pci_enable_interrupts’:
> .../dpdk/build/build/kernel/linux/igb_uio/igb_uio.c:230:6:
> error: this statement may fall through
> [-Werror=implicit-fallthrough=]
> 230 | if (pci_alloc_irq_vectors(udev->pdev, 1, 1, ....
> .../dpdk/build/build/kernel/linux/igb_uio/igb_uio.c:240:2:
> note: here
> 240 | case RTE_INTR_MODE_MSI:
> | ^~~~
>
> The build error is caused by Linux kernel commit in 5.3 that enables
> the
> "-Wimplicit-fallthrough=3" gcc flag.
> Commit a035d552a93b ("Makefile: Globally enable fall-through
> warning")
>
> To fix the error, either a gcc attribute can be provided [1] or a
> code
> comment with some defined syntax need to be provided [2], since there
> is
> already comments, updated them slightly to match the required syntax
> to
> fix the build error.
>
> [1]
> "__attribute__ ((fallthrough));"
>
> [2]
> [ \t.!]*([Ee]lse,? |[Ii]ntentional(ly)? )?
> fall(s | |-)?thr(ough|u)[ \t.!]*(-[^\n\r]*)?
>
> Cc:
> stable@dpdk.org
>
>
> Signed-off-by: Ferruh Yigit <
> ferruh.yigit@intel.com
> >
> ---
> kernel/linux/igb_uio/igb_uio.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Ferruh I'm including this in 17.11.7 since it fixes the build on a
number of new distros and it seems simple enough as it just updates the
comment for the compiler's benefit.
Let me know if there are any objections.
--
Kind regards,
Luca Boccassi
next prev parent reply other threads:[~2019-09-24 18:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 12:32 [dpdk-stable] " Ferruh Yigit
2019-07-29 20:01 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2019-09-24 18:25 ` Luca Boccassi [this message]
2019-09-26 7:56 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8ea6d4e5c8b4424dc88cedb1dff79d9af022d41.camel@debian.org \
--to=bluca@debian.org \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).