patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Xiao Wang <xiao.w.wang@intel.com>
Cc: dev@dpdk.org, zhihong.wang@intel.com, chenbo.xia@intel.com,
	stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH] net/virtio-user: fix virtio net status management
Date: Tue, 28 Jul 2020 17:54:40 +0200	[thread overview]
Message-ID: <e9fb18bd-c7ca-cf53-158e-88730db20dd2@redhat.com> (raw)
In-Reply-To: <20200728065212.16703-1-xiao.w.wang@intel.com>



On 7/28/20 8:52 AM, Xiao Wang wrote:
> Apart from the virtio status, there should be also a network related
> status for link status management, current implementation mixes up these
> two statuses.
> 
> One issue caused by this mixup is when virtio-user running in server mode
> and vhost as a client connects to it, a RARP packet will be generated by
> virtio-user due to VIRTIO_NET_S_ANNOUNCE bit is detected in the "status"
> in interrupt handler.
> 
> VIRTIO_NET_S_LINK_UP and VIRTIO_NET_S_ANNOUNCE should be managed by a
> separated field. This patch adds a "net_status" field for this purpose.
> 
> Fixes: e9efa4d93821 ("net/virtio-user: add new virtual PCI driver")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
> ---
>  drivers/net/virtio/virtio_user/virtio_user_dev.h |  1 +
>  drivers/net/virtio/virtio_user_ethdev.c          | 10 +++++-----
>  2 files changed, 6 insertions(+), 5 deletions(-)

Applied to dpdk-next-virtio/master

Thanks,
Maxime


      parent reply	other threads:[~2020-07-28 15:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-28  6:52 Xiao Wang
2020-07-28  7:45 ` Xia, Chenbo
2020-07-28 13:59 ` Maxime Coquelin
2020-07-28 15:54 ` Maxime Coquelin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e9fb18bd-c7ca-cf53-158e-88730db20dd2@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=chenbo.xia@intel.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    --cc=xiao.w.wang@intel.com \
    --cc=zhihong.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).