patches for DPDK stable branches
 help / color / Atom feed
From: Igor Ryzhov <iryzhov@nfware.com>
To: Kevin Traynor <ktraynor@redhat.com>
Cc: Bruce Richardson <bruce.richardson@intel.com>,
	dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-stable] patch 'kernel/linux: fix modules install path' has been queued to LTS release 18.11.3
Date: Fri, 23 Aug 2019 13:04:30 +0300
Message-ID: <e9fde847-548b-432b-8537-0ec8db346d67@Spark> (raw)
In-Reply-To: <20190823094336.12078-6-ktraynor@redhat.com>

Rebased version looks fine.

Best regards,
Igor
On 23 Aug 2019, 12:44 +0300, Kevin Traynor <ktraynor@redhat.com>, wrote:
> Hi,
>
> FYI, your patch has been queued to LTS release 18.11.3
>
> Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
> It will be pushed if I get no objections before 08/28/19. So please
> shout if anyone has objections.
>
> Also note that after the patch there's a diff of the upstream commit vs the
> patch applied to the branch. This will indicate if there was any rebasing
> needed to apply to the stable branch. If there were code changes for rebasing
> (ie: not only metadata diffs), please double check that the rebase was
> correctly done.
>
> Queued patches are on a temporary branch at:
> https://github.com/kevintraynor/dpdk-stable-queue
>
> This queued commit can be viewed at:
> https://github.com/kevintraynor/dpdk-stable-queue/commit/15a14f6d5bc6fb4df53e8b3cb3fb53e504f838c9
>
> Thanks.
>
> Kevin Traynor
>
> ---
> From 15a14f6d5bc6fb4df53e8b3cb3fb53e504f838c9 Mon Sep 17 00:00:00 2001
> From: Igor Ryzhov <iryzhov@nfware.com>
> Date: Tue, 11 Jun 2019 11:49:34 +0300
> Subject: [PATCH] kernel/linux: fix modules install path
>
> [ upstream commit 317832f97c165cd4f327567935dfbd6af92b4159 ]
>
> Currently kernel modules are installed into /usr/src instead of
> /lib/modules when meson build system is used. This patch fixes that.
>
> Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> kernel/linux/igb_uio/meson.build | 4 ++--
> kernel/linux/kni/meson.build | 4 ++--
> kernel/linux/meson.build | 4 ++--
> meson_options.txt | 2 +-
> 4 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/kernel/linux/igb_uio/meson.build b/kernel/linux/igb_uio/meson.build
> index f5a9d5ccf..fac404f07 100644
> --- a/kernel/linux/igb_uio/meson.build
> +++ b/kernel/linux/igb_uio/meson.build
> @@ -9,5 +9,5 @@ custom_target('igb_uio',
> input: ['igb_uio.c', 'Kbuild'],
> output: 'igb_uio.ko',
> - command: ['make', '-C', kernel_dir,
> + command: ['make', '-C', kernel_dir + '/build',
> 'M=' + meson.current_build_dir(),
> 'src=' + meson.current_source_dir(),
> @@ -17,4 +17,4 @@ custom_target('igb_uio',
> depends: mkfile,
> install: true,
> - install_dir: kernel_dir + '/../extra/dpdk',
> + install_dir: kernel_dir + '/extra/dpdk',
> build_by_default: get_option('enable_kmods'))
> diff --git a/kernel/linux/kni/meson.build b/kernel/linux/kni/meson.build
> index a09af5aa5..e6822f49c 100644
> --- a/kernel/linux/kni/meson.build
> +++ b/kernel/linux/kni/meson.build
> @@ -17,5 +17,5 @@ custom_target('rte_kni',
> input: kni_sources + kni_igb_sources + kni_ixgbe_sources,
> output: 'rte_kni.ko',
> - command: ['make', '-j4', '-C', kernel_dir,
> + command: ['make', '-j4', '-C', kernel_dir + '/build',
> 'M=' + meson.current_build_dir(),
> 'src=' + meson.current_source_dir(),
> @@ -31,4 +31,4 @@ custom_target('rte_kni',
> console: true,
> install: true,
> - install_dir: kernel_dir + '/../extra/dpdk',
> + install_dir: kernel_dir + '/extra/dpdk',
> build_by_default: get_option('enable_kmods'))
> diff --git a/kernel/linux/meson.build b/kernel/linux/meson.build
> index 5b7ec06e1..c5bcc1f38 100644
> --- a/kernel/linux/meson.build
> +++ b/kernel/linux/meson.build
> @@ -21,9 +21,9 @@ else
> # use default path for native builds
> kernel_version = run_command('uname', '-r').stdout().strip()
> - kernel_dir = '/lib/modules/' + kernel_version + '/build'
> + kernel_dir = '/lib/modules/' + kernel_version
> endif
>
> # test running make in kernel directory, using "make kernelversion"
> - make_returncode = run_command('make', '-sC', kernel_dir,
> + make_returncode = run_command('make', '-sC', kernel_dir + '/build',
> 'kernelversion').returncode()
> if make_returncode != 0
> diff --git a/meson_options.txt b/meson_options.txt
> index 10b541615..91b0449a1 100644
> --- a/meson_options.txt
> +++ b/meson_options.txt
> @@ -14,5 +14,5 @@ option('include_subdir_arch', type: 'string', value: '',
> description: 'subdirectory where to install arch-dependent headers')
> option('kernel_dir', type: 'string', value: '',
> - description: 'path to the kernel for building kernel modules, they will be installed in $DEST_DIR/$kernel_dir/../extra/dpdk')
> + description: 'Path to the kernel for building kernel modules. Headers must be in $kernel_dir/build. Modules will be installed in $DEST_DIR/$kernel_dir/extra/dpdk.')
> option('lib_musdk_dir', type: 'string', value: '',
> description: 'path to the MUSDK library installation directory')
> --
> 2.20.1
>
> ---
> Diff of the applied patch vs upstream commit (please double-check if non-empty:
> ---
> --- - 2019-08-22 19:38:20.876697935 +0100
> +++ 0006-kernel-linux-fix-modules-install-path.patch 2019-08-22 19:38:20.397027833 +0100
> @@ -1 +1 @@
> -From 317832f97c165cd4f327567935dfbd6af92b4159 Mon Sep 17 00:00:00 2001
> +From 15a14f6d5bc6fb4df53e8b3cb3fb53e504f838c9 Mon Sep 17 00:00:00 2001
> @@ -5,0 +6,2 @@
> +[ upstream commit 317832f97c165cd4f327567935dfbd6af92b4159 ]
> +
> @@ -9,2 +10,0 @@
> -Cc: stable@dpdk.org
> -
> @@ -38 +38 @@
> -index a9f48b0e6..955eec949 100644
> +index a09af5aa5..e6822f49c 100644
> @@ -41,2 +41,2 @@
> -@@ -14,5 +14,5 @@ custom_target('rte_kni',
> - input: kni_sources,
> +@@ -17,5 +17,5 @@ custom_target('rte_kni',
> + input: kni_sources + kni_igb_sources + kni_ixgbe_sources,
> @@ -48 +48 @@
> -@@ -26,4 +26,4 @@ custom_target('rte_kni',
> +@@ -31,4 +31,4 @@ custom_target('rte_kni',
> @@ -55 +55 @@
> -index a37c95752..1796cc686 100644
> +index 5b7ec06e1..c5bcc1f38 100644
> @@ -58,6 +58,6 @@
> -@@ -14,9 +14,9 @@ if kernel_dir == ''
> - # use default path for native builds
> - kernel_version = run_command('uname', '-r').stdout().strip()
> -- kernel_dir = '/lib/modules/' + kernel_version + '/build'
> -+ kernel_dir = '/lib/modules/' + kernel_version
> - endif
> +@@ -21,9 +21,9 @@ else
> + # use default path for native builds
> + kernel_version = run_command('uname', '-r').stdout().strip()
> +- kernel_dir = '/lib/modules/' + kernel_version + '/build'
> ++ kernel_dir = '/lib/modules/' + kernel_version
> + endif
> @@ -65,5 +65,5 @@
> - # test running make in kernel directory, using "make kernelversion"
> --make_returncode = run_command('make', '-sC', kernel_dir,
> -+make_returncode = run_command('make', '-sC', kernel_dir + '/build',
> - 'kernelversion').returncode()
> - if make_returncode != 0
> + # test running make in kernel directory, using "make kernelversion"
> +- make_returncode = run_command('make', '-sC', kernel_dir,
> ++ make_returncode = run_command('make', '-sC', kernel_dir + '/build',
> + 'kernelversion').returncode()
> + if make_returncode != 0
> @@ -71 +71 @@
> -index 16d9f92c6..5302b9c68 100644
> +index 10b541615..91b0449a1 100644
> @@ -74 +74 @@
> -@@ -16,5 +16,5 @@ option('include_subdir_arch', type: 'string', value: '',
> +@@ -14,5 +14,5 @@ option('include_subdir_arch', type: 'string', value: '',

  reply index

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-23  9:42 [dpdk-stable] patch 'net/bnx2x: fix warnings from invalid assert' " Kevin Traynor
2019-08-23  9:42 ` [dpdk-stable] patch 'net/qede: " Kevin Traynor
2019-08-23  9:42 ` [dpdk-stable] patch 'eal: correct log for alarm error' " Kevin Traynor
2019-08-23  9:42 ` [dpdk-stable] patch 'eal/linux: fix return after alarm registration failure' " Kevin Traynor
2019-08-23  9:42 ` [dpdk-stable] patch 'kernel/freebsd: fix module build on latest head' " Kevin Traynor
2019-08-23  9:42 ` [dpdk-stable] patch 'kernel/linux: fix modules install path' " Kevin Traynor
2019-08-23 10:04   ` Igor Ryzhov [this message]
2019-08-23  9:42 ` [dpdk-stable] patch 'ip_frag: fix IPv6 fragment size calculation' " Kevin Traynor
2019-08-23  9:42 ` [dpdk-stable] patch 'test/hash: fix off-by-one check on core count' " Kevin Traynor
2019-08-23  9:42 ` [dpdk-stable] patch 'test/hash: rectify slave id to point to valid cores' " Kevin Traynor
2019-08-23  9:43 ` [dpdk-stable] patch 'bus/vmbus: skip non-network devices' " Kevin Traynor
2019-08-23  9:43 ` [dpdk-stable] patch 'bpf: fix check array size' " Kevin Traynor
2019-08-23  9:43 ` [dpdk-stable] patch 'eal: hide internal hotplug function' " Kevin Traynor
2019-08-23  9:43 ` [dpdk-stable] patch 'vfio: remove incorrect experimental tag' " Kevin Traynor
2019-08-23  9:43 ` [dpdk-stable] patch 'mem: remove incorrect experimental tag on static symbol' " Kevin Traynor
2019-08-23  9:43 ` [dpdk-stable] patch 'telemetry: add missing header include' " Kevin Traynor
2019-08-23  9:43 ` [dpdk-stable] patch 'eal: fix positive error codes from probe/remove' " Kevin Traynor
2019-08-23  9:43 ` [dpdk-stable] patch 'net/bnx2x: fix invalid free on unplug' " Kevin Traynor
2019-08-23  9:43 ` [dpdk-stable] patch 'drivers/net: fix double free on init failure' " Kevin Traynor
2019-08-23  9:43 ` [dpdk-stable] patch 'net: fix encapsulation markers for inner L3 offset' " Kevin Traynor
2019-08-23  9:43 ` [dpdk-stable] patch 'net/mlx5: fix 32-bit build' " Kevin Traynor
2019-08-23  9:43 ` [dpdk-stable] patch 'net/netvsc: fix RSS offload settings' " Kevin Traynor
2019-08-23  9:43 ` [dpdk-stable] patch 'net/netvsc: fix xstats id' " Kevin Traynor
2019-08-23  9:43 ` [dpdk-stable] patch 'net/netvsc: fix xstats for VF device' " Kevin Traynor
2019-08-23  9:43 ` [dpdk-stable] patch 'doc: fix typos in flow API guide' " Kevin Traynor
2019-08-23  9:43 ` [dpdk-stable] patch 'net: fix how L4 checksum choice is tested' " Kevin Traynor
2019-08-23  9:43 ` [dpdk-stable] patch 'eal/freebsd: fix init completion' " Kevin Traynor
2019-08-23  9:43 ` [dpdk-stable] patch 'raw/skeleton: fix test of attribute set/get' " Kevin Traynor
2019-08-23  9:43 ` [dpdk-stable] patch 'examples/l3fwd-vf: remove unused Rx/Tx configuration' " Kevin Traynor
2019-08-23  9:43 ` [dpdk-stable] patch 'doc: remove useless Rx configuration in l2fwd guide' " Kevin Traynor
2019-08-23  9:43 ` [dpdk-stable] patch 'test: add rawdev autotest to meson' " Kevin Traynor
2019-08-23  9:43 ` [dpdk-stable] patch 'event/dpaa2: fix timeout ticks' " Kevin Traynor
2019-08-23  9:43 ` [dpdk-stable] patch 'eventdev: fix doxygen comment' " Kevin Traynor
2019-08-23  9:43 ` [dpdk-stable] patch 'app/eventdev: fix order test port creation' " Kevin Traynor
2019-08-23  9:43 ` [dpdk-stable] patch 'test/eventdev: fix producer core validity checks' " Kevin Traynor
2019-08-23  9:43 ` [dpdk-stable] patch 'net/mvneta: fix ierror statistics' " Kevin Traynor
2019-08-25 11:41   ` [dpdk-stable] [EXT] " Liron Himi
2019-08-23  9:43 ` [dpdk-stable] patch 'net: fix definition of IPv6 traffic class mask' " Kevin Traynor
2019-08-23  9:43 ` [dpdk-stable] patch 'examples: fix pkg-config detection with older make' " Kevin Traynor
2019-08-23  9:43 ` [dpdk-stable] patch 'bpf: fix validate for function return value' " Kevin Traynor
2019-08-23  9:43 ` [dpdk-stable] patch 'raw/ifpga/base: fix use of untrusted scalar " Kevin Traynor
2019-08-23  9:43 ` [dpdk-stable] patch 'raw/ifpga/base: fix physical address info' " Kevin Traynor
2019-08-23  9:43 ` [dpdk-stable] patch 'usertools: fix refresh binding infos' " Kevin Traynor
2019-08-23  9:43 ` [dpdk-stable] patch 'doc: add a note for multi-process in mempool guide' " Kevin Traynor
2019-08-23  9:43 ` [dpdk-stable] patch 'table: fix crash in LPM IPv6' " Kevin Traynor
2019-08-23  9:43 ` [dpdk-stable] patch 'test: fix autotest crash' " Kevin Traynor
2019-08-23  9:43 ` [dpdk-stable] patch 'telemetry: fix build' " Kevin Traynor
2019-08-23  9:43 ` [dpdk-stable] patch 'app/testpmd: fix offloads config' " Kevin Traynor
2019-08-23  9:59   ` Kevin Traynor
2019-09-04 17:44     ` Kevin Traynor
2019-09-05  2:14       ` Zhao1, Wei
2019-09-11 14:46         ` Kevin Traynor
2019-09-13  9:27           ` Iremonger, Bernard

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e9fde847-548b-432b-8537-0ec8db346d67@Spark \
    --to=iryzhov@nfware.com \
    --cc=bruce.richardson@intel.com \
    --cc=ktraynor@redhat.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/ public-inbox