From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 813571B7E3; Thu, 8 Feb 2018 14:30:46 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Feb 2018 05:30:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,478,1511856000"; d="scan'208";a="25855571" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.91]) ([10.237.220.91]) by FMSMGA003.fm.intel.com with ESMTP; 08 Feb 2018 05:30:44 -0800 To: Olivier Matz , dev@dpdk.org, Ajit Khaparde , Somnath Kotur Cc: stable@dpdk.org References: <20180206170758.1148-1-olivier.matz@6wind.com> <20180208082417.22626-1-olivier.matz@6wind.com> From: Ferruh Yigit Message-ID: Date: Thu, 8 Feb 2018 13:30:43 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180208082417.22626-1-olivier.matz@6wind.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-stable] [PATCH v2] net/bnxt: fix packet type X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Feb 2018 13:30:47 -0000 On 2/8/2018 8:24 AM, Olivier Matz wrote: > The hw flags are not read correctly: the defines > RX_PKT_CMPL_FLAGS_ITYPE_* are not bits but values, so the should not be > tested with if (value & X) but with if ((value & MASK) == X). > This was resulting in a wrong packet type. > > For instance, an IPv4/ICMP packet was returning a value of 7 for > the layer 4, which is undefined. > > This patch rework the way packet types are processed, to ensure > that only valid packet types will be advertised. > > Fixes: 3d2a6644eb05 ("net/bnxt: support getting ptypes") > Cc: stable@dpdk.org > > Signed-off-by: Olivier Matz > Acked-by: Ajit Khaparde Applied to dpdk-next-net/master, thanks.