From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8DD8C48B60 for ; Fri, 21 Nov 2025 15:41:00 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 688EB40267; Fri, 21 Nov 2025 15:41:00 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 8253440267 for ; Fri, 21 Nov 2025 15:40:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763736057; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ATUhWyx9bdZ4xN5bjyV3Xi/ao/3n2zk0OzpSdsMpERw=; b=ZY8n8BchYdQxE+zo1W7QDA3iC/fUHF0jUYwusvxcAZJobgr/lqwijVL8D66/jOxUtML8IY qt1MwM6xdaEQifpcLlPWHRFFNwNYXeIE5CWHNgwKosCcw+0KijBFroUIAKsdz/zLjrXgI6 NK2GRftWnAY6QRbvSMX0LD2mVV1aedE= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-548-_Euug7OSMwyG87uDGFI9AQ-1; Fri, 21 Nov 2025 09:40:54 -0500 X-MC-Unique: _Euug7OSMwyG87uDGFI9AQ-1 X-Mimecast-MFC-AGG-ID: _Euug7OSMwyG87uDGFI9AQ_1763736053 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-477a0ddd1d4so26409325e9.0 for ; Fri, 21 Nov 2025 06:40:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763736053; x=1764340853; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ATUhWyx9bdZ4xN5bjyV3Xi/ao/3n2zk0OzpSdsMpERw=; b=PK2An+eZfNeV2xZ+sYMMcW7O20B0dmhiLen3it4ECy0+nSDT++i5tglPfIsFxT2N7R 1xrJCjo3GsMTBtUWf/8vzITF9WpGlRucGV9Pn9fw5MbXgTw8j9xzM+Kq6kpp6omdsDLA VW2WqIvePVnwJ3ojB6dLLu+nlycxQ/3cBUfKA2Tg7XDwF4ts5rFgNSVjc75Tpj2xLoRn kzhBi2XIe1qen+1ZRVzSiAyIzaCH1KUakIthLgzspYqHVLVjO/9MgloHktgdPPMZXfX8 V0qtjMqel5lHyhVA+cGFwacISyxWYTLSwIQ47ne+ElEPZZvnp0ZQmdl7pv9GRYgOt2eE ClpA== X-Forwarded-Encrypted: i=1; AJvYcCWHQ0yEhDK0bjwvT9nn4eCdJdcbhvd5vS3xW74pbYjSGJ0iSr2NHBEF5O1NMbEeZC9xMvTuQk8=@dpdk.org X-Gm-Message-State: AOJu0Yyy1TaH8frJhju+RekKWIohiY7uqZejiEoA6fd3g+ExB/xi2aT1 6HskAoNCvdJd1CcqIuTPi36rLs1eVK8Efx3UTdNyck9YHLeU24mQI4nsblSZON0EVqD/mDmaWhC oJkUeO2Y2ZO2gEw6itlTjkRsYrwkmXj+fQkJU4TgaQp990dlt X-Gm-Gg: ASbGncscpUxRP1XM3vc+K6IukjRzK6eazwkcmqbF5SOQVJDdWVu+2cOIOAgf/nmJirm LylnEiFVYIfZ5jNWPRyU0AL+jTITefro7SUCHKnddG2xGu9nRBuqaA+lHU04bruw61kTinKUYUT 9tZ0Rr3/4tLdVfeSdcL5kN68ybBr2/TuB6v2PBx6GSc1i423+/jSP9UeBybDR1OK0tKLgUO4I3c eIGqe29Gcnn4k7Uheqb5ohBUajVWKSGlOFtEfEVd1idRxOAyBfyQ/Px8X6dJJWe/70C4iM/Zyns bUgPrPDiEDoW3vlFl8kPLWhxWSeEBamvtjesYtpiR67seTMbHn8/dSxzdmbGld6CI35OEe2wmjw otwD+UQ8YJ1PJ X-Received: by 2002:a05:600c:3ba4:b0:477:95a0:fe95 with SMTP id 5b1f17b1804b1-477c1123ae7mr35867185e9.24.1763736053346; Fri, 21 Nov 2025 06:40:53 -0800 (PST) X-Google-Smtp-Source: AGHT+IGkLlr8vhSQrQBStuu4Q93Phmd44sZCo1QJjI10XnSzphr72m+y7M8r0VOqdjz+y427osClcg== X-Received: by 2002:a05:600c:3ba4:b0:477:95a0:fe95 with SMTP id 5b1f17b1804b1-477c1123ae7mr35866875e9.24.1763736052902; Fri, 21 Nov 2025 06:40:52 -0800 (PST) Received: from [192.168.0.56] ([78.16.128.110]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477bf355933sm50098665e9.2.2025.11.21.06.40.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Nov 2025 06:40:52 -0800 (PST) Message-ID: Date: Fri, 21 Nov 2025 14:40:51 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 24.11] net/mlx5: fix Tx metadata pattern template mismatch To: Shani Peretz , stable@dpdk.org Cc: Dariusz Sosnowski , Viacheslav Ovsiienko , Bing Zhao , Ori Kam , Suanming Mou , Matan Azrad , Michael Baum References: <20251120105106.50721-1-shperetz@nvidia.com> From: Kevin Traynor Autocrypt: addr=ktraynor@redhat.com; keydata= xsFNBF2J2awBEADUEPNhgNI+nJNgiTAUcw4YIgVXEoHlsNPyyzG1BEXkWXALy0Y3fNTiw6+r ltWDkF9jzL9kfkecgQ67itGfk1OaBXgSGKuw1PUpxAwX2Bi76LAR6M5OsyGM9TSVVQwARalz hMwRBIZPzPc7or6Pw7jAOJ8SQGJ1Zlp1YJCjrvpe87V1tH/LY8Wnxn/EuoseFmWILAQZAtYS tGjcrAgYn3SPMLR1B0BP5bTBY06vWQjiufH8drenfDnMJAzuBdG1mqjnTqCjULZ3Hunv4xqZ aMnkvL/K5Tj1c12Oe4930EE53LrXIBUltRg5mBudSWHnC7twjH0082HH9f963Z/2UI63SFIT iUvRvAzJYytgy7XnWLQ0+goZBADKYfolOuC0H8VgCaux8u8KFF28Dy+N6TV2KI58jTlyg1Zu l7QwykZpnOkJFiy37Gfbu3YEOzO72cP/S7/A+zvuqkxi63jyEkd+FY99vLt/HN2MUZwRmKDw UPbLkmrs8WU01/POVsqDcfvz7vu2St8hqqTiSIdQGS2zyTKB2/DvPSM3jws3udkIYSuhn+X4 QBiV6lkVZ7DSE6a065gnAauAql+b32Eymy+xnG5jCt1tR+0Cp2VZYCR9OU2gmomUKBDoX/He pSgED01CqYPNjN+TddirwmQX7ep4DtXc8FWvv2g/pq9WZFQk2QARAQABzSNLZXZpbiBUcmF5 bm9yIDxrdHJheW5vckByZWRoYXQuY29tPsLBjgQTAQgAOBYhBAoiOaH51tHF7VYtEI9CINER a+yJBQJdidmsAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEI9CINERa+yJoxIP/3VF 2TIgW4ckxhRFCvFu/606bnvCPie88ake4uWVWMAWwcMc4fKEltRWRCpkSVOwgqoMHnyHxK5r kOKzx2CLJMX5TgTMfKzPuaBDHngHLUzl2DStpBzrod0cVg5TShdmmfjY61uxRJKz+DlSkwgJ riADdVF5PPosQXTkKSGf2ombpTGpx/pue9ocjnr3x4SDpRLlnooM6Jf/3Y3Ib4jX6HPEyWuY b+owIIk9y2nRRGPQ6jbqAhsrXd9V+77UL0QuGWloMuKMZFbNg8hbu7X5aFijAbfxj4YUgojS ba7gfGZQan8h32A9KGQWrmsCBc3j2GqEPsX0r05X7cn7WL6IOPgQJ5EiQ7PlazQYVLrvZg9B n0GKK0k6895mLG0ZZ5v/qajOPF52etSmvFD1WUPb4OqaHqGA9ZtMpaKFRt7Y6rpXqKNU1xzW F5KjbTPtTb9WF3An8dciVv+AYUI7totkZYkWvQtgss8lfaX3NKUvXLVxqK0z3dQyr7rF/tYz PneTKypSksjCgaEBLSrsRmM5zKfe7tSNF/fDntfIq/029Jtcw29TcWEP57peNu6TtejewQD9 sTI+oqiXvW2D5l7LNUDYG8eMJp2oT7I0ZSBRvwcbmjH0DtN/bXCCFfCvk8Yic68F3tV1ctix wQARVKDBhT30uCxycRWojCYqTgNJJS71zsFNBF2J2awBEADP57PR2IpSYBeNSrsAjeIcsahE N4SQP2C4s50S8QEWAUhqMRI7WNv5cfeef0nDvcl1IUA6oz5SokbcsbMa+mRgaNF4N5KikWTO LPYxq2YVJoXwJ+tKmNzyOLFUIfFJ4NBJZple5dTfWzD00Dbb19Mri1hy1mWMqNTPGBee1+hw Qcp6n3mmGECvajs8G5A7NyXbwL8ihN7HX9D01ucD62b4G03yKe2g/hvKgcdUVmhCldJlF27I 2fSR9tDxH9pZqRODY4rjbFZEey/vWKXqjE+DQ8AtMSEaDfFe5D+i4Aw6erWQ3Wr+DwZt1/7G dIAElGA/q90T1ENVwJX9y7fsQssawKYYdDqURHCl5JuDXI+VXUypExipUUT5SPycMmbLsx0D iKEqPPDQWKxkIDVKqj2+EhamSuJznZUwBLJKn0h4zrIWiXWUy07lRwtVuhaDXhF3GfW+5W/x wAg7Qg3w00ASsb/XTHBIhMnenKDfS7ihtQA8SacwX8ySdxb+15XPyiplM979qBQ0mhnilulm MIJzEf/JxoYR5huuj4f1PFqqrsP06Dl+YGB7dQZp3IKggS5c3/TAynARRg9N89UsDXNtp7X0 tgIPFF5k6fnHE0J5O64GYHeTqN/1aE6dAEOV9WrGzQAJxU9ipikb8jKAWXzLewRIKGmoPcRZ WdB0NmIjmQARAQABwsF2BBgBCAAgFiEECiI5ofnW0cXtVi0Qj0Ig0RFr7IkFAl2J2awCGwwA CgkQj0Ig0RFr7IkkORAAl/NbX93WK5MEoRw7/DaPTo/Lo6Pj1XMeSqGyACigHK/452UDvlEH NjNJMzYYrNIjMtEmN9VVCfjT38CSca7mpGQVwchc0mC7QSPAETLCS+UacVf/Kwxz5FfkEUUw UT7A+uyVOIgW3d9ldlRzkHA2czonSSgTQU+i2g6DM4ha+BuQb4byAXH6HQHt/Zh1J64z0ohH v6iGsCzCY/sMWF8+LEGSnzMGRCLiiwSF0vJBHbzWK68fANaF4gBV0Z/+6tQRFN7YMhj/INmk qgvHj1ZzHFNtirjMGPRxoZs51YoLQM/aBPxKrnmXThx1ufH+0L6sGmFTugiDt0XSEkC5reH7 a+VhQ1VTFFQrClA8NmDSPzFeuhru4ryaaDHO+uEB16cNHxHrQtlP/2hts2JM5lwkZRWJ5A57 h8eDEIK5be47T85NVHfuTaboNRmgg1HygVejhGUtt69u/0MVRg/roUTa0FyEbNsvz4qAecyW yWzMcVrcGJDQLC9JLKEpoyUF6gdTKaiDL2Vao4+XRIA3Y57b6MO35a3HuzAv7+i5Z0mnDEJO XxXqTOmKYpMIGexzM/PtuA0712sT1abG9tAJ17ao/B7cqMW5IkKkalemFbWfI2unns4Papvo tk9igVqyp6EJDU98z5TJioCVojwK2laDaoIjTJk9YYv3iwCsqPd5feU= In-Reply-To: <20251120105106.50721-1-shperetz@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 1YxwlWT6rm8L7UZUt3cp22Xva0BjGbXcdl7nMrkq1I8_1763736053 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 20/11/2025 10:51, Shani Peretz wrote: > When representor matching is disabled with dv_xmeta_en=4, the Tx metadata > copy flows use SQ (send queue) pattern matching, but the pattern template > was still configured to use ETH match-all pattern. This mismatch causes > hardware to reject the flows with error CQEs during port configuration. > > This patch fixes the issue by using SQ-based pattern template > (flow_hw_create_tx_repr_sq_pattern_tmpl) instead of the ETH match-all > template (flow_hw_create_tx_default_mreg_copy_pattern_template). > > Fixes: 593fb3fdfa10 ("net/mlx5: fix multi process Tx default rules") Hi Shani, About the Fixed commit, is it this one from main branch ? 2f1bb792ad51 ("net/mlx5: fix multi-process Tx default rules") > > Signed-off-by: Shani Peretz > Acked-by: Dariusz Sosnowski > --- > drivers/net/mlx5/mlx5_flow_hw.c | 42 +-------------------------------- > 1 file changed, 1 insertion(+), 41 deletions(-) > > diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c > index 208f50fbfd..b64ba9b46b 100644 > --- a/drivers/net/mlx5/mlx5_flow_hw.c > +++ b/drivers/net/mlx5/mlx5_flow_hw.c > @@ -10185,46 +10185,6 @@ flow_hw_create_ctrl_port_pattern_template(struct rte_eth_dev *dev, > return flow_hw_pattern_template_create(dev, &attr, items, error); > } > > -/* > - * Creating a flow pattern template with all ETH packets matching. > - * This template is used to set up a table for default Tx copy (Tx metadata > - * to REG_C_1) flow rule usage. > - * > - * @param dev > - * Pointer to Ethernet device. > - * @param error > - * Pointer to error structure. > - * > - * @return > - * Pointer to flow pattern template on success, NULL otherwise. > - */ > -static struct rte_flow_pattern_template * > -flow_hw_create_tx_default_mreg_copy_pattern_template(struct rte_eth_dev *dev, > - struct rte_flow_error *error) > -{ > - struct rte_flow_pattern_template_attr tx_pa_attr = { > - .relaxed_matching = 0, > - .egress = 1, > - }; > - struct rte_flow_item_eth promisc = { > - .hdr.dst_addr.addr_bytes = { 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 }, > - .hdr.src_addr.addr_bytes = { 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 }, > - .hdr.ether_type = 0, > - }; > - struct rte_flow_item eth_all[] = { > - [0] = { > - .type = RTE_FLOW_ITEM_TYPE_ETH, > - .spec = &promisc, > - .mask = &promisc, > - }, > - [1] = { > - .type = RTE_FLOW_ITEM_TYPE_END, > - }, > - }; > - > - return flow_hw_pattern_template_create(dev, &tx_pa_attr, eth_all, error); > -} > - > /* > * Creating a flow pattern template with all LACP packets matching, only for NIC > * ingress domain. > @@ -10930,7 +10890,7 @@ flow_hw_create_fdb_ctrl_tables(struct rte_eth_dev *dev, struct rte_flow_error *e > /* Create templates and table for default Tx metadata copy flow rule. */ > if (!repr_matching && xmeta == MLX5_XMETA_MODE_META32_HWS) { > hw_ctrl_fdb->tx_meta_items_tmpl = > - flow_hw_create_tx_default_mreg_copy_pattern_template(dev, error); > + flow_hw_create_tx_repr_sq_pattern_tmpl(dev, error); > if (!hw_ctrl_fdb->tx_meta_items_tmpl) { > DRV_LOG(ERR, "port %u failed to Tx metadata copy pattern" > " template for control flows", dev->data->port_id);