From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 73E44A0557 for ; Tue, 28 Jun 2022 14:35:02 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6EC0D410EE; Tue, 28 Jun 2022 14:35:02 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 8B21D400D7; Tue, 28 Jun 2022 14:34:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656419699; x=1687955699; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=buZi6ts9IFZe9DxzOFNTTn/UWHbOtsRV5R/HR7jnU5M=; b=BhR1ymjnELGZv9jNgdfdza4DUgqkProTsxIlwcGoDC1WHUNu0fjPY+pX ipKgigB7hSbx/X/3JL8e7uyA7baiAW1tgNE1bgBTtKironeBxa/bWjrY1 SL7t00NNlUDPHtr1NR2McG24w8wHCbyAcFzADrMXzxNJmBNXyOds6/1u8 +zLxUkwQ6yWD0tC3JVn7OI0OgfE+ud1Qb/4DbDbXYye8xrqgS8Z7T+i66 E0uY6r7qR0/fQdRBWF62CXNQxzbxU+F98zieC+bya3v/cIcwCe6EAOLxN VwuJFM6R8cB7vIHnpRg37V0MfUzHX6GjbDXz02AAjxU8L4DQmeBS8eYPj w==; X-IronPort-AV: E=McAfee;i="6400,9594,10391"; a="281765682" X-IronPort-AV: E=Sophos;i="5.92,227,1650956400"; d="scan'208";a="281765682" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jun 2022 05:34:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,227,1650956400"; d="scan'208";a="540473328" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga003.jf.intel.com with ESMTP; 28 Jun 2022 05:34:58 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 28 Jun 2022 05:34:57 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 28 Jun 2022 05:34:57 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 28 Jun 2022 05:34:57 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.171) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 28 Jun 2022 05:34:57 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZidoOrrc6OUWCR/UfAGvNNlllXPloI0r4Im8iGkiOgkl1kcOkNGt5Dej4n0fn3ykttm1LFK9OXcUJeXyoH0EqUf7sRlfsSpL/dUOipmishNksHemSBNHa4Y4zKcAfcK0UGw9LD5JOyTGSnBVJYLVB8isYcoGWqPjBbfn/DsCGGvWFpAyaJtCpinTLekCQMHVS2ZI6rVh/kPcREU6nQdkEQTPszHKB1/q9//YGrPiXj4ABkgRSk0EsJ+WnFHPaQJR6wRnHhOdKy+YclHVZ0VevODsKH8SyEpATUl0XwbV01slTlaEVCGcGC9etPNVcqBOr1Fmopr3VesF//3Fg7W7bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5ZTz1sYmFGE2zPyc4E6NjtCgxBeaB3gREs90vD272mw=; b=crfkAPPEprtzSupH5jK4J7b2Ocq2mSXMNJ4ugJfY7ceiTYMxPJoU9KUuH2tyBlwb+cl987nKRc8/029ujoRSxXcWbyOvwQM5lhfixyWDEu3kX+JLmSszDGpd35jwLM9MpjWAlhZFfgRDtZXfIRBLpcRUgwOqwnxVb473Rar9xTYiAgd2XZXG88S63R2GynanE++2SoyZq4AcMdthrmrOjM8Zr58vaiqa7Zlbsv5Eb59z4cDSbn2k9CAbWSYH8nTku02i63rfpU191naKSfatvaxlzv8Wem3RNlxSCZMQvfqZSzCC8DwwexdPnviskC+NVUam1xdHwprpitk+aXDwRQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from BN8PR11MB3795.namprd11.prod.outlook.com (2603:10b6:408:82::31) by DM5PR11MB1675.namprd11.prod.outlook.com (2603:10b6:4:d::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.17; Tue, 28 Jun 2022 12:34:55 +0000 Received: from BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::f164:8102:8731:c20a]) by BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::f164:8102:8731:c20a%7]) with mapi id 15.20.5373.018; Tue, 28 Jun 2022 12:34:54 +0000 Message-ID: Date: Tue, 28 Jun 2022 13:34:50 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH] examples/distributor: update dynamic configuration Content-Language: en-US To: Omer Yamac CC: , References: <20220621201517.76991-1-omer.yamac@ceng.metu.edu.tr> <1316cb8ca17a15f61db96dae18e99856@ceng.metu.edu.tr> From: "Hunt, David" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0322.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:197::21) To BN8PR11MB3795.namprd11.prod.outlook.com (2603:10b6:408:82::31) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 830c145e-9554-4b5a-8df5-08da59029a62 X-MS-TrafficTypeDiagnostic: DM5PR11MB1675:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XUKwTuEO9+vUvIXq+C66VsWG6ZJmWl6BFtufHqkvKqvBEu9TaPqZOM46l180ksj4GoxxhZjWwlpkVgchh+uVSv0nhGdMyT+v5Li68u4b3bo2WAvfy1W30xAEX/zrpDqDbv0jxcsTBKh7trFYEII+C7/1dFtf7SnTNJ2Zv+Wl2dA+IuMN42Wef53Mv8zrUi2uoRBgi+NiFCj7KniWuPFm0NVhuxxpL4IPRdGwQ+5aXtPlOOfXGF+Mf+dMyjYWMrwp4mD28F/R8a45Q31B5slK6tHYR5N16oM95vG7soCQCubRoBdcMJPchICL5OFwgQ6rV6iFZ39N1F6fWvq1dgmuLUJzY9/5ZpFu+0/rTz/cgYlis0tGQiuVmTl+47hyNiFiFvcvTs4x1kXXM7ZY5qqp9tCqYR1HzfCh/MQieuFArDyzgYaQdF4rc9hWOBTnGxafmlfUv1hgGyUiT6fGjVenz1pU9GzOjisxVi2y8vO+BmPMnwwo6xhHHq1JvaSJ6qGEdGXpSE6bbQth1IhpUr7evMduAqXVfjmMi/uH+tdX+QNCIy+97UgbLsCh6rYY6JrX7f8zQe0HFRWVIhxOZKOPP0d1u/fqVpLKB47pIj/WnlrrccGwB2WLjjKRL7mAPaURAqAt8DKOMqCPn/+X2B7L2fXI1tFC33oa4wycGkTLsuOkn1bsQuBcn7/5GKsFEyDrN+EVz6VYiFxGQ1aT896f6z76RCTXsjjv9zMAXjToLo07jYSM1DCfnqQ6gCCSxmt++Q1IYhEtol0xYvhbwzhxt+/OdfGjOqh8Xs9eBphvoCR8bRcx9GwzSz6AaERZRr6kF0wgRdZGVjqoSNLOXAYSKg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR11MB3795.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(366004)(346002)(136003)(376002)(396003)(39860400002)(41300700001)(53546011)(478600001)(86362001)(6512007)(6916009)(26005)(31696002)(38100700002)(6666004)(186003)(2616005)(6506007)(82960400001)(66556008)(8676002)(66574015)(66476007)(36756003)(4744005)(2906002)(4326008)(31686004)(316002)(6486002)(5660300002)(8936002)(66946007)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ODFDYmlvdEY3QTNUN1VvMUlQN201NU9TK01xZnU1RUMvSUlNc1VpYXNxMFA2?= =?utf-8?B?RzBMTGlNSkcwSXFUNytTcnpsalVHeTN2aCszMTFHWnBKaEIxR0pQSkxKVmZN?= =?utf-8?B?WThTRlV0WVRQTGpnUU95YVlhbFVnUzRSOGkyNkhQRE1NKzhWVXpzcEcxMzZ1?= =?utf-8?B?YURqUGNxZktEN2pTMm5WbzZmMldOZ08veldOWk5vZENtQ3Y5U2RvYTdNaUNo?= =?utf-8?B?ejlCMVpkNlIwSy91RnVVeVBueVltb0FuK1Y5WVhLcEt6RUIraE9jeG9GeDNa?= =?utf-8?B?SmprSmhmWkVIQ0xNK29mUXdjb0VNS2J6TnZLNm5yZHhCVm9VMU5VREtaOFJO?= =?utf-8?B?UUppWkFDcitnRTBEQit6Mkg4RWhRS3JvNWpmUHRFUi9MWDVjS3FPVVFCY0JE?= =?utf-8?B?cDdxbTVTQW40KzFjN0I1RGtGZ2pDODEwMHpNbmdYTTVnZ21PODYwV3ZHTDBt?= =?utf-8?B?T0VTbHgxRDcvdE9BY3h1RjJ5OTg5SEQ0K3NxMVlBUHhaWWpiY0x6KytCLzRB?= =?utf-8?B?NUR5TmpSamJFcmdGNmdxNHZURXFJV1RsNWlKaWl0WWpMZURmb0pVV3gyVjRT?= =?utf-8?B?OUNPRElwNEVCZ0RVMkdnUDlmYmIweGRtRDQzNi9EQytPbkFHV0M4ZEpOeko5?= =?utf-8?B?bjdWZUZHcHo0YXZNRmwxSEY4VjNobk50T01qSms3bXdXVlU3Qk9RNDRrY0lx?= =?utf-8?B?ZUlkaWJaQUwrTnN6K2R2bzQrTms4NWd0NURkdDFTajd4MlF1aEN5dDNRMWNo?= =?utf-8?B?WE5EVHZNemJlS3FjZlIzbWxjNVVIS3JlazkweHBPaVM4NyswbFZzL1RZQWxo?= =?utf-8?B?TWszNVVId0ZZb0VQaWlBS2xTME1PYWd6aU9kOFZZU3REdDEySkxGbUxIL3pD?= =?utf-8?B?c1YzREdINElkK3dyRDlOaDMxUU5OcnZydXJuTHdXVFBjdEdkNFdTRklhOUp5?= =?utf-8?B?cjZyL0g4UmJoQ1RsMjFBNXA2aC8vYnBwRytsY0huWXkxUmFqdnB0a3dNNk9m?= =?utf-8?B?bHdCSWx6ZW9acnRxcjJqeTBnVE45d3kzTkNoV1ZMa3BxWk9pWS9lSkkyY3ZK?= =?utf-8?B?Q003a25HdlJBdXM1OFk2QnhhWjl3QWxpSDJacFUyaGtXNjFnb09CQzNRdlRX?= =?utf-8?B?VDZaR0cxT0tiYTk3K0JIQ0kyRzQ5TlNSQnNoVTlmSENtTVlDbCtJMGVmdHVk?= =?utf-8?B?akZoNXpFSjJad3l3d2s3VGtHSVM4MUxReTljZU1JbHRURGg1Ni8zTmsrYi9I?= =?utf-8?B?Q3paNDVvOHViWGJXRjNTczN5aStwenJFU3hmZlYvUm4rZjFuWFJMaDFYNnZ3?= =?utf-8?B?SUFaUk1tUFZtdlhXOTdpNDNiNGVIeWNqUnhFeEhrZVVxZ05YZzVsb1N0a3pY?= =?utf-8?B?OXluODMxY3ZHTW1vMi9FTXlpL2pOQmNWRDkzR0VWSjIvZDFrTnlqVW9PeG4r?= =?utf-8?B?Y01DcEJaajl1SStMS3owZmJVU1NrU0paYzZDbVJOdFNEbXc5S25BSFE5b3Jl?= =?utf-8?B?TnFyOElWZ1hsS3VtU2JwczRPdzFSTUV3TmJCYUhzNmUyei85ZDRuZ1F3SENZ?= =?utf-8?B?eVZ1ZTh0dmRWSGhoVTJHK2VybjluMTB0dm1ZSm9qSWg4UWV0SGtxVzBEVlNY?= =?utf-8?B?RGFaNk9DOG5PR21uNGUyZlN2aE4xMUxCRC8rMnNLbXFtdTBJQjJUWUo2N09U?= =?utf-8?B?L0RHdTRWeU9URzVnY2FQSVF6ditTVlNpNzArQjdQYmVrRSt2d1N0eTRTSjJD?= =?utf-8?B?WlZJR3ZobGlVNVg2djBBdHhQSTdKTnhlS0MxQ3BuZjFmbVpCWGhzYkdGT1RO?= =?utf-8?B?T29aQ2dvZkFWcFM5emhqM2EzYXQxYjZLbG42SVZYSkZiTHJVNmhBVzRuZ2w2?= =?utf-8?B?RWpFK0RWY0RJdkUvdmJ1dGc4YzFKc2krZzh5S0NQbUZIWnlIRjhmSmFLMEI4?= =?utf-8?B?c1hROVlCa1g0WllsY1pzbHcwS1FFU3pTZzRZTFYyMFZ6MHpqRlNlaFYwakxO?= =?utf-8?B?bkJaNURQRWI5d0ZqUXZHaUdGcFF0emtWM1BQMFo5bzFWVUdxT0Y5K3JtcDN4?= =?utf-8?B?WHJ3aFliVFVLcFpGU1FEeWRJNjdMZ0ZTZDZGWEJpamkzSGFUNjVyVWR5ZXhi?= =?utf-8?B?TlZkQ0x5ZVcxOVJXSUVoNVFYS3RDWXpVYnN0Z2ZIYXltclJEQXVJMkp4Z2JQ?= =?utf-8?B?MGc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 830c145e-9554-4b5a-8df5-08da59029a62 X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3795.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2022 12:34:54.7552 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UErkT55L+b9AWcmjZmOL8vmqFSBzX6Z6KZPUcpelzIuvkY9FgRcZEM6QttW3j1ldUClCuqawbXDY8o4RgljAzA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1675 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 28/06/2022 13:06, Omer Yamac wrote: > Hi, > Here is the final version. If it is ok, I will test the code and publish. > > if (enable_lcore_rx_distributor){ > // rx and distributor combined, 3 fixed function cores (stat, TX, at > least 1 worker) >     min_cores = 4; >     num_workers = rte_lcore_count() - 3; > } > else{ > // separate rx and distributor, 3 fixed function cores (stat, TX, at > least 1 worker) >     min_cores = 5; >     num_workers = rte_lcore_count() - 4; > } > Hi Ömer, Please use standard comment formatting (look elsewhere for examples). I'm not sure you need min_cores any more. Rgds, Dave. --snip--