From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CAD53A0351 for ; Thu, 6 Aug 2020 12:00:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C2D5D1C1A5; Thu, 6 Aug 2020 12:00:39 +0200 (CEST) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by dpdk.org (Postfix) with ESMTP id 9D2711C1A5 for ; Thu, 6 Aug 2020 12:00:38 +0200 (CEST) Received: by mail-wr1-f68.google.com with SMTP id z18so39835504wrm.12 for ; Thu, 06 Aug 2020 03:00:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=pgj2UvFvhtqJXwkWyNMDF68Fay6yMfBR75bvH3U816I=; b=swygeDy0m0f8JLi3enazxwXeW5GZ3Xc2oXg87t221Cy0o1JZtQUqtyKgRXgw+v8R1n ryDu8H86DKpV4a8FxKBBg1k4sH0K+8KNLhxlp4FOA8Fq24QQokjIvExd10r32IT5TvNI rVzMAXmKxNcRf+YiX8PW1YuY1cwmGFufUTemt/qKitKc4kVB5b6AA/HdHwQIEp6Wxlrm uJLHyhhBL3KZ84j8O1nLViRT0KIK4n2ihh9WL7sBpFbDNbI1HpcPixjFsKpGPvEVSjVu /9Mxcu0ctteQqmHakxEkADdZJ3Umrh5RwDJSo8DF1KUJbUr2GLtdIrK9K/FLUu8npjk5 lRSQ== X-Gm-Message-State: AOAM533EdK1msqrhwRTHI0TSsqPO4lrO2e3b9D85iP513bVE/9dx2L9B y9hHqRB1BWW6Hot06yE8Mv0= X-Google-Smtp-Source: ABdhPJyIjmKRPFupgk95xfqagfyKdW4N6gxHu8SgAstzYbch8iEBFRRUDciNyK+K74OCr2oZHu1HxA== X-Received: by 2002:adf:e94a:: with SMTP id m10mr7261345wrn.249.1596708038347; Thu, 06 Aug 2020 03:00:38 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id h7sm5957830wmf.43.2020.08.06.03.00.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Aug 2020 03:00:37 -0700 (PDT) Message-ID: From: Luca Boccassi To: Kalesh A P , stable@dpdk.org Cc: ajit.khaparde@broadcom.com Date: Thu, 06 Aug 2020 11:00:37 +0100 In-Reply-To: <20200729132142.15290-1-kalesh-anakkur.purayil@broadcom.com> References: <20200729132142.15290-1-kalesh-anakkur.purayil@broadcom.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH 19.11] net/bnxt: fix logical AND in if condition X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Wed, 2020-07-29 at 18:51 +0530, Kalesh A P wrote: > From: Kalesh AP >=20 > [ upstream commit 90c957ef3b11f361dd8e6519d9e195f01295b23e ] >=20 > The if condition in bnxt_restore_mac_filters needs to check for > the result of logical AND. But it was not doing it resulting in > an incorrect check. >=20 > Fixes: b02f1573cd07 ("net/bnxt: restore MAC filters during reset recovery= ") >=20 > Signed-off-by: Ajit Khaparde > Signed-off-by: Kalesh AP > --- > drivers/net/bnxt/bnxt_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethde= v.c > index f1bd575..4c64525 100644 > --- a/drivers/net/bnxt/bnxt_ethdev.c > +++ b/drivers/net/bnxt/bnxt_ethdev.c > @@ -3950,7 +3950,7 @@ static int bnxt_restore_mac_filters(struct bnxt *bp= ) > uint16_t i; > int rc; > =20 > - if (BNXT_VF(bp) & !BNXT_VF_IS_TRUSTED(bp)) > + if (BNXT_VF(bp) && !BNXT_VF_IS_TRUSTED(bp)) > return 0; > =20 > rc =3D bnxt_dev_info_get_op(dev, &dev_info); Thanks, applied and pushed. --=20 Kind regards, Luca Boccassi