From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 21637A0C46 for ; Tue, 14 Sep 2021 10:38:17 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0DFD74003C; Tue, 14 Sep 2021 10:38:17 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id A96664003C for ; Tue, 14 Sep 2021 10:38:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631608694; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cp+0NPo9GUSDhS8S2LLKarAkuklGr8q9hCH1QaDW0Fw=; b=PMxI9FQyXnROknsdMt54pPV8AqGJymt3xfSlcFCz62e/szPYq7qQ8zssmfV5MJHBaQehqA 12OFcBpKwj388YoUxrQg6s7DDCA2XzW8WjK38ZXHSmKd/KsM1IJ6Cadda4/PX+OQwjgJYn 3m3QhMnvPqjyvSR22D4Yuz9fwyvFlD8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-503-irHjSrDUP5SgzbyiwjoFBg-1; Tue, 14 Sep 2021 04:38:14 -0400 X-MC-Unique: irHjSrDUP5SgzbyiwjoFBg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C379B1835AD5; Tue, 14 Sep 2021 08:36:14 +0000 (UTC) Received: from [10.39.208.12] (unknown [10.39.208.12]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 524BA5C1D1; Tue, 14 Sep 2021 08:36:13 +0000 (UTC) To: David Marchand , dev@dpdk.org Cc: stable@dpdk.org, Chenbo Xia , Jianfeng Tan , Yuanhan Liu References: <20210830151313.25481-1-david.marchand@redhat.com> <20210831155411.17672-1-david.marchand@redhat.com> <20210831155411.17672-2-david.marchand@redhat.com> From: Maxime Coquelin Message-ID: Date: Tue, 14 Sep 2021 10:36:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210831155411.17672-2-david.marchand@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-stable] [PATCH v2 1/2] net/virtio: reconfigure LSC handler when required X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 8/31/21 5:54 PM, David Marchand wrote: > There is no reason to re-register a interrupt handler for LSC if this > feature was not requested in the first place. > A simple usecase is when asking for Rx interrupts without LSC interrupt. > > Fixes: 26b683b4f7d0 ("net/virtio: setup Rx queue interrupts") > Cc: stable@dpdk.org > > Signed-off-by: David Marchand > --- > drivers/net/virtio/virtio_ethdev.c | 16 +++++++++------- > 1 file changed, 9 insertions(+), 7 deletions(-) > > diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c > index e58085a2c9..314a291e8c 100644 > --- a/drivers/net/virtio/virtio_ethdev.c > +++ b/drivers/net/virtio/virtio_ethdev.c > @@ -1684,13 +1684,15 @@ virtio_configure_intr(struct rte_eth_dev *dev) > } > } > > - /* Re-register callback to update max_intr */ > - rte_intr_callback_unregister(dev->intr_handle, > - virtio_interrupt_handler, > - dev); > - rte_intr_callback_register(dev->intr_handle, > - virtio_interrupt_handler, > - dev); > + if (dev->data->dev_flags & RTE_ETH_DEV_INTR_LSC) { > + /* Re-register callback to update max_intr */ > + rte_intr_callback_unregister(dev->intr_handle, > + virtio_interrupt_handler, > + dev); > + rte_intr_callback_register(dev->intr_handle, > + virtio_interrupt_handler, > + dev); > + } > > /* DO NOT try to remove this! This function will enable msix, or QEMU > * will encounter SIGSEGV when DRIVER_OK is sent. > Reviewed-by: Maxime Coquelin Thanks, Maxime