From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Jakub Grajciar -X (jgrajcia - PANTHEON TECH SRO at Cisco)"
<jgrajcia@cisco.com>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
"dev@dpdk.org" <dev@dpdk.org>, Phil Yang <Phil.Yang@arm.com>
Cc: nd <nd@arm.com>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH v2 1/8] net/memif: do not update local copy of tail in tx function
Date: Fri, 9 Oct 2020 16:59:03 +0100 [thread overview]
Message-ID: <eebace72-10d9-cdbe-a0ef-8a5716fd59b8@intel.com> (raw)
In-Reply-To: <BN8PR11MB3572E3634BFD479200B6A38BDF080@BN8PR11MB3572.namprd11.prod.outlook.com>
On 10/9/2020 12:23 PM, Jakub Grajciar -X (jgrajcia - PANTHEON TECH SRO at Cisco)
wrote:
>>> -----Original Message-----
>>> From: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
>>> Sent: Monday, September 28, 2020 2:03 PM
>>> To: dev@dpdk.org; Honnappa Nagarahalli
>> <Honnappa.Nagarahalli@arm.com>;
>>> Phil Yang <Phil.Yang@arm.com>; jgrajcia@cisco.com;
>>> ferruh.yigit@intel.com
>>> Cc: nd <nd@arm.com>; stable@dpdk.org
>>> Subject: [PATCH v2 1/8] net/memif: do not update local copy of tail in
>>> tx function
>>>
>>> In the case of S2M queues, the receiver synchronizes with the sender (i.e.
>>> informs of the packets it has received) using ring->tail.
>>> Hence, the sender does not need to update last_tail.
>>>
>>> In the case of M2S queues, the receiver uses last_tail to keep track
>>> of the descriptors it has received. The sender is not required to update the
>> last_tail.
>>> Updating the last_tail makes it a shared variable between the
>>> transmitter and receiver affecting the performance.
>
> Hi Honnappa,
>
> The patch series is looking good.
>
> Reviewed-by: Jakub Grajciar <jgrajcia@cisco.com>
>
Series applied to dpdk-next-net/main, thanks.
prev parent reply other threads:[~2020-10-09 15:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-21 19:22 [dpdk-stable] [PATCH 1/4] " Honnappa Nagarahalli
2020-09-21 19:22 ` [dpdk-stable] [PATCH 2/4] net/memif: relax the load of ring tail pointer for M2S ring Honnappa Nagarahalli
2020-09-21 19:22 ` [dpdk-stable] [PATCH 3/4] net/memif: relax the load of ring head pointer for S2M ring Honnappa Nagarahalli
2020-09-21 19:22 ` [dpdk-stable] [PATCH 4/4] net/memif: relax the load of ring head pointer for M2S ring Honnappa Nagarahalli
2020-09-28 19:03 ` [dpdk-stable] [PATCH v2 1/8] net/memif: do not update local copy of tail in tx function Honnappa Nagarahalli
2020-09-28 19:03 ` [dpdk-stable] [PATCH v2 2/8] net/memif: relax the load of ring tail pointer for M2S ring Honnappa Nagarahalli
2020-09-28 19:03 ` [dpdk-stable] [PATCH v2 3/8] net/memif: relax the load of ring head " Honnappa Nagarahalli
2020-09-28 19:03 ` [dpdk-stable] [PATCH v2 4/8] net/memif: relax the load of ring head pointer for S2M ring Honnappa Nagarahalli
2020-09-28 20:53 ` [dpdk-stable] [dpdk-dev] [PATCH v2 1/8] net/memif: do not update local copy of tail in tx function Stephen Hemminger
2020-09-29 5:24 ` Honnappa Nagarahalli
2020-10-07 17:08 ` [dpdk-stable] " Honnappa Nagarahalli
2020-10-09 11:23 ` Jakub Grajciar -X (jgrajcia - PANTHEON TECH SRO at Cisco)
2020-10-09 15:59 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eebace72-10d9-cdbe-a0ef-8a5716fd59b8@intel.com \
--to=ferruh.yigit@intel.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=Phil.Yang@arm.com \
--cc=dev@dpdk.org \
--cc=jgrajcia@cisco.com \
--cc=nd@arm.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).