Re: [dpdk-stable] please help backporting some patches to stable release 19.11.3

Re: [dpdk-stable] please help backporting some patches to stable release 19.11.3

[Wei Hu (Xavier)]

Hi,  Luca Boccassi

On 2020/5/27 18:14, luca.boccassi@gmail.com wrote:
> Hi commit authors (and maintainers),
>
> I didn't apply following commits from DPDK master to 19.11
> stable branch, as conflicts or build errors occur.
>
> Can authors check your patches in the following list and either:
>      - Backport your patches to the 19.11 branch, or
>      - Indicate that the patch should not be backported
>
> Please do either of the above by June the 3rd.
>
>
> Some notes on stable backports:
>
> A backport should contain a reference to the DPDK master branch commit
> in it's commit message in the following fashion:
>      [ upstream commit <commit's dpdk master branch SHA-1 checksum> ]
>
> For example:
>      https://git.dpdk.org/dpdk-stable/commit/?h=18.11&id=d90e6ae6f936ecdc2fd3811ff9f26aec7f3c06eb
>
> When sending the backported patch, please indicate the target branch in the
> subject line, as we have multiple branches, for example:
>      [PATCH 19.11] foo/bar: fix baz
>
> With git format-patch, this can be achieved by appending the parameter:
>      --subject-prefix='PATCH 19.11'
>
> Send the backported patch to "stable@dpdk.org" but not "dev@dpdk.org".
>
> FYI, branch 19.11 is located at tree:
>     https://git.dpdk.org/dpdk-stable
>
> Thanks.
>
> Luca Boccassi
>
> ---
> 96477b5dd5  Ajit Khaparde    net/bnxt: fix allocation of COS queue info
> 205b742952  Ajit Khaparde    net/bnxt: fix allocation of LED config info
> 986fa3ba83  Ajit Khaparde    net/bnxt: fix allocation of link info struct
> e8fe0e067b  Ajit Khaparde    net/bnxt: fix allocation of PF info struct
> 29fdc5bf45  Apeksha Gupta    test/crypto: fix statistics case
> fb94f35948  Chengchang Tang  net/hns3: fix adding multicast MAC address
DPDK19.11 is the first version of the hns3 driver integrated into the DPDK.
In this version, the features based on hns3 network engine are not complete,
we prefer to recommend users to use the updated version.

"fb94f35948 Chengchang Tang net/hns3: fix adding multicast MAC address"
For the above patch, we think that it will have little effect if this patch
does not merged into the 19.11.x version.
> a4e6ea97a5  Dekel Peled      common/mlx5: fix RSS key copy to TIR context
> 1db72630da  Dmitry Kozlyuk   eal/windows: do not expose private facilities
> 867b49d17a  Ferruh Yigit     ring: fix build for gcc O1 optimization
> 48f9faddc6  Kalesh AP        net/bnxt: fix MAC address setting when port is stopped
> 10d6982008  Kalesh AP        net/bnxt: fix recovery alarm race condition in port close
> 920be799db  Lijun Ou         net/hns3: fix RSS indirection table configuration
"920be799db Lijun Ou net/hns3: fix RSS indirection table configuration"
This patch depends on the following patch:
     "a951c1ed3 net/hns3: support different numbers of Rx and Tx queues",
but the patch was accepted in dpdk20.02.0, not merged in dpdk 19.11.x.
Can you give some suggestions?
Thanks.

   Regards
Xavier
> 5af61440dd  Matan Azrad      net/mlx5: fix flow counter container resize
> 6e585db689  Michal Krawczyk  net/ena/base: fix testing for supported hash function
> f5bf02df31  Ori Kam          eal/ppc: fix bool type after altivec include
> dede694cd5  Pablo de Lara    doc: add NASM installation steps
> 0aa1ab2fb4  Qi Zhang         net/ice/base: fix a couple of casting
> a7b645debc  Qi Zhang         net/ice/base: fix DCF switch rule
> a1f5c1c27c  Qi Zhang         net/ice/base: fix removing MAC rule
> 3ccf61bc1e  Qi Zhang         net/ice/base: fix tunnel type match word handling
> a60704d1ac  Rasesh Mody      net/qede: fix assignment of Rx/Tx handlers
> 4448a202b6  Thomas Monjalon  eal: remove useless makefiles
> .

Re: [dpdk-stable] please help backporting some patches to stable release 19.11.3

[Luca Boccassi]

On Thu, 2020-05-28 at 17:29 +0800, Wei Hu (Xavier) wrote:
> Hi,  Luca Boccassi
> 
> On 2020/5/27 18:14, luca.boccassi@gmail.com wrote:
> > Hi commit authors (and maintainers),
> > 
> > I didn't apply following commits from DPDK master to 19.11
> > stable branch, as conflicts or build errors occur.
> > 
> > Can authors check your patches in the following list and either:
> >      - Backport your patches to the 19.11 branch, or
> >      - Indicate that the patch should not be backported
> > 
> > Please do either of the above by June the 3rd.
> > 
> > 
> > Some notes on stable backports:
> > 
> > A backport should contain a reference to the DPDK master branch commit
> > in it's commit message in the following fashion:
> >      [ upstream commit <commit's dpdk master branch SHA-1 checksum> ]
> > 
> > For example:
> >      https://git.dpdk.org/dpdk-stable/commit/?h=18.11&id=d90e6ae6f936ecdc2fd3811ff9f26aec7f3c06eb
> > 
> > When sending the backported patch, please indicate the target branch in the
> > subject line, as we have multiple branches, for example:
> >      [PATCH 19.11] foo/bar: fix baz
> > 
> > With git format-patch, this can be achieved by appending the parameter:
> >      --subject-prefix='PATCH 19.11'
> > 
> > Send the backported patch to "stable@dpdk.org" but not "dev@dpdk.org".
> > 
> > FYI, branch 19.11 is located at tree:
> >     https://git.dpdk.org/dpdk-stable
> > 
> > Thanks.
> > 
> > Luca Boccassi
> > 
> > ---
> > 96477b5dd5  Ajit Khaparde    net/bnxt: fix allocation of COS queue info
> > 205b742952  Ajit Khaparde    net/bnxt: fix allocation of LED config info
> > 986fa3ba83  Ajit Khaparde    net/bnxt: fix allocation of link info struct
> > e8fe0e067b  Ajit Khaparde    net/bnxt: fix allocation of PF info struct
> > 29fdc5bf45  Apeksha Gupta    test/crypto: fix statistics case
> > fb94f35948  Chengchang Tang  net/hns3: fix adding multicast MAC address
> DPDK19.11 is the first version of the hns3 driver integrated into the DPDK.
> In this version, the features based on hns3 network engine are not complete,
> we prefer to recommend users to use the updated version.
> 
> "fb94f35948 Chengchang Tang net/hns3: fix adding multicast MAC address"
> For the above patch, we think that it will have little effect if this patch
> does not merged into the 19.11.x version.
> > a4e6ea97a5  Dekel Peled      common/mlx5: fix RSS key copy to TIR context
> > 1db72630da  Dmitry Kozlyuk   eal/windows: do not expose private facilities
> > 867b49d17a  Ferruh Yigit     ring: fix build for gcc O1 optimization
> > 48f9faddc6  Kalesh AP        net/bnxt: fix MAC address setting when port is stopped
> > 10d6982008  Kalesh AP        net/bnxt: fix recovery alarm race condition in port close
> > 920be799db  Lijun Ou         net/hns3: fix RSS indirection table configuration
> "920be799db Lijun Ou net/hns3: fix RSS indirection table configuration"
> This patch depends on the following patch:
>      "a951c1ed3 net/hns3: support different numbers of Rx and Tx queues",
> but the patch was accepted in dpdk20.02.0, not merged in dpdk 19.11.x.
> Can you give some suggestions?

a951c1ed3 does not apply cleanly either. If you'd like to have both in
19.11.3, please backport them both on top of dpdk-stable/19.11 and send
them to stable@dpdk.org. If you don't think it's worth having them,
that's fine too.

Re: [dpdk-stable] please help backporting some patches to stable release 19.11.3

[Wei Hu (Xavier)]

Hi,  Luca Boccassi


On 2020/5/29 0:35, Luca Boccassi wrote:
> On Thu, 2020-05-28 at 17:29 +0800, Wei Hu (Xavier) wrote:
>> Hi,  Luca Boccassi
>>
>> On 2020/5/27 18:14, luca.boccassi@gmail.com wrote:
>>> Hi commit authors (and maintainers),
>>>
>>> I didn't apply following commits from DPDK master to 19.11
>>> stable branch, as conflicts or build errors occur.
>>>
>>> Can authors check your patches in the following list and either:
>>>       - Backport your patches to the 19.11 branch, or
>>>       - Indicate that the patch should not be backported
>>>
>>> Please do either of the above by June the 3rd.
>>>
>>>
>>> Some notes on stable backports:
>>>
>>> A backport should contain a reference to the DPDK master branch commit
>>> in it's commit message in the following fashion:
>>>       [ upstream commit <commit's dpdk master branch SHA-1 checksum> ]
>>>
>>> For example:
>>>       https://git.dpdk.org/dpdk-stable/commit/?h=18.11&id=d90e6ae6f936ecdc2fd3811ff9f26aec7f3c06eb
>>>
>>> When sending the backported patch, please indicate the target branch in the
>>> subject line, as we have multiple branches, for example:
>>>       [PATCH 19.11] foo/bar: fix baz
>>>
>>> With git format-patch, this can be achieved by appending the parameter:
>>>       --subject-prefix='PATCH 19.11'
>>>
>>> Send the backported patch to "stable@dpdk.org" but not "dev@dpdk.org".
>>>
>>> FYI, branch 19.11 is located at tree:
>>>      https://git.dpdk.org/dpdk-stable
>>>
>>> Thanks.
>>>
>>> Luca Boccassi
>>>
>>> ---
>>> 96477b5dd5  Ajit Khaparde    net/bnxt: fix allocation of COS queue info
>>> 205b742952  Ajit Khaparde    net/bnxt: fix allocation of LED config info
>>> 986fa3ba83  Ajit Khaparde    net/bnxt: fix allocation of link info struct
>>> e8fe0e067b  Ajit Khaparde    net/bnxt: fix allocation of PF info struct
>>> 29fdc5bf45  Apeksha Gupta    test/crypto: fix statistics case
>>> fb94f35948  Chengchang Tang  net/hns3: fix adding multicast MAC address
>> DPDK19.11 is the first version of the hns3 driver integrated into the DPDK.
>> In this version, the features based on hns3 network engine are not complete,
>> we prefer to recommend users to use the updated version.
>>
>> "fb94f35948 Chengchang Tang net/hns3: fix adding multicast MAC address"
>> For the above patch, we think that it will have little effect if this patch
>> does not merged into the 19.11.x version.
>>> a4e6ea97a5  Dekel Peled      common/mlx5: fix RSS key copy to TIR context
>>> 1db72630da  Dmitry Kozlyuk   eal/windows: do not expose private facilities
>>> 867b49d17a  Ferruh Yigit     ring: fix build for gcc O1 optimization
>>> 48f9faddc6  Kalesh AP        net/bnxt: fix MAC address setting when port is stopped
>>> 10d6982008  Kalesh AP        net/bnxt: fix recovery alarm race condition in port close
>>> 920be799db  Lijun Ou         net/hns3: fix RSS indirection table configuration
>> "920be799db Lijun Ou net/hns3: fix RSS indirection table configuration"
>> This patch depends on the following patch:
>>       "a951c1ed3 net/hns3: support different numbers of Rx and Tx queues",
>> but the patch was accepted in dpdk20.02.0, not merged in dpdk 19.11.x.
>> Can you give some suggestions?
> a951c1ed3 does not apply cleanly either. If you'd like to have both in
> 19.11.3, please backport them both on top of dpdk-stable/19.11 and send
> them to stable@dpdk.org. If you don't think it's worth having them,
> that's fine too.
> .
Thanks. I will send the related patches as soon as possible.

     Regards
Xavier
>

Re: [dpdk-stable] please help backporting some patches to stable release 19.11.3

[Ferruh Yigit]

On 5/27/2020 11:14 AM, luca.boccassi@gmail.com wrote:
> Hi commit authors (and maintainers),
> 
> I didn't apply following commits from DPDK master to 19.11
> stable branch, as conflicts or build errors occur.
> 
> Can authors check your patches in the following list and either:
>     - Backport your patches to the 19.11 branch, or
>     - Indicate that the patch should not be backported
> 
> Please do either of the above by June the 3rd.
> 
> 
> Some notes on stable backports:
> 
> A backport should contain a reference to the DPDK master branch commit
> in it's commit message in the following fashion:
>     [ upstream commit <commit's dpdk master branch SHA-1 checksum> ]
> 
> For example:
>     https://git.dpdk.org/dpdk-stable/commit/?h=18.11&id=d90e6ae6f936ecdc2fd3811ff9f26aec7f3c06eb
> 
> When sending the backported patch, please indicate the target branch in the
> subject line, as we have multiple branches, for example:
>     [PATCH 19.11] foo/bar: fix baz
> 
> With git format-patch, this can be achieved by appending the parameter:
>     --subject-prefix='PATCH 19.11'
> 
> Send the backported patch to "stable@dpdk.org" but not "dev@dpdk.org".
> 
> FYI, branch 19.11 is located at tree:
>    https://git.dpdk.org/dpdk-stable
> 
> Thanks.
> 
> Luca Boccassi
> 

<...>

> 867b49d17a  Ferruh Yigit     ring: fix build for gcc O1 optimization

Hi Luca,

The fix is not applicable for 19.11, we can ignore it.

'lib/librte_ring/rte_ring_peek.h' has been added for 20.05 and this patch fixes it.

[dpdk-stable] please help backporting some patches to stable release 19.11.3

[Luca Boccassi]

Hi commit authors (and maintainers),

I didn't apply following commits from DPDK master to 19.11
stable branch, as conflicts or build errors occur.

Can authors check your patches in the following list and either:
    - Backport your patches to the 19.11 branch, or
    - Indicate that the patch should not be backported

Please do either of the above by June the 3rd.


Some notes on stable backports:

A backport should contain a reference to the DPDK master branch commit
in it's commit message in the following fashion:
    [ upstream commit <commit's dpdk master branch SHA-1 checksum> ]

For example:
    https://git.dpdk.org/dpdk-stable/commit/?h=18.11&id=d90e6ae6f936ecdc2fd3811ff9f26aec7f3c06eb

When sending the backported patch, please indicate the target branch in the
subject line, as we have multiple branches, for example:
    [PATCH 19.11] foo/bar: fix baz

With git format-patch, this can be achieved by appending the parameter:
    --subject-prefix='PATCH 19.11'

Send the backported patch to "stable@dpdk.org" but not "dev@dpdk.org".

FYI, branch 19.11 is located at tree:
   https://git.dpdk.org/dpdk-stable

Thanks.

Luca Boccassi

---
96477b5dd5  Ajit Khaparde    net/bnxt: fix allocation of COS queue info
205b742952  Ajit Khaparde    net/bnxt: fix allocation of LED config info
986fa3ba83  Ajit Khaparde    net/bnxt: fix allocation of link info struct
e8fe0e067b  Ajit Khaparde    net/bnxt: fix allocation of PF info struct
29fdc5bf45  Apeksha Gupta    test/crypto: fix statistics case
fb94f35948  Chengchang Tang  net/hns3: fix adding multicast MAC address
a4e6ea97a5  Dekel Peled      common/mlx5: fix RSS key copy to TIR context
1db72630da  Dmitry Kozlyuk   eal/windows: do not expose private facilities
867b49d17a  Ferruh Yigit     ring: fix build for gcc O1 optimization
48f9faddc6  Kalesh AP        net/bnxt: fix MAC address setting when port is stopped
10d6982008  Kalesh AP        net/bnxt: fix recovery alarm race condition in port close
920be799db  Lijun Ou         net/hns3: fix RSS indirection table configuration
5af61440dd  Matan Azrad      net/mlx5: fix flow counter container resize
6e585db689  Michal Krawczyk  net/ena/base: fix testing for supported hash function
f5bf02df31  Ori Kam          eal/ppc: fix bool type after altivec include
dede694cd5  Pablo de Lara    doc: add NASM installation steps
0aa1ab2fb4  Qi Zhang         net/ice/base: fix a couple of casting
a7b645debc  Qi Zhang         net/ice/base: fix DCF switch rule
a1f5c1c27c  Qi Zhang         net/ice/base: fix removing MAC rule
3ccf61bc1e  Qi Zhang         net/ice/base: fix tunnel type match word handling
a60704d1ac  Rasesh Mody      net/qede: fix assignment of Rx/Tx handlers
4448a202b6  Thomas Monjalon  eal: remove useless makefiles

Re: [dpdk-stable] please help backporting some patches to stable release 19.11.3

[Luca Boccassi]

On Wed, 2020-05-27 at 17:10 +0100, Luca Boccassi wrote:
> Hi commit authors (and maintainers),
> 
> I didn't apply following commits from DPDK master to 19.11
> stable branch, as conflicts or build errors occur.
> 
> Can authors check your patches in the following list and either:
>     - Backport your patches to the 19.11 branch, or
>     - Indicate that the patch should not be backported
> 
> Please do either of the above by June the 3rd.
> 
> 
> Some notes on stable backports:
> 
> A backport should contain a reference to the DPDK master branch commit
> in it's commit message in the following fashion:
>     [ upstream commit <commit's dpdk master branch SHA-1 checksum> ]
> 
> For example:
>     https://git.dpdk.org/dpdk-stable/commit/?h=18.11&id=d90e6ae6f936ecdc2fd3811ff9f26aec7f3c06eb
> 
> When sending the backported patch, please indicate the target branch in the
> subject line, as we have multiple branches, for example:
>     [PATCH 19.11] foo/bar: fix baz
> 
> With git format-patch, this can be achieved by appending the parameter:
>     --subject-prefix='PATCH 19.11'
> 
> Send the backported patch to "stable@dpdk.org" but not "dev@dpdk.org".
> 
> FYI, branch 19.11 is located at tree:
>    https://git.dpdk.org/dpdk-stable
> 
> Thanks.
> 
> Luca Boccassi
> 
> ---
> 96477b5dd5  Ajit Khaparde    net/bnxt: fix allocation of COS queue info
> 205b742952  Ajit Khaparde    net/bnxt: fix allocation of LED config info
> 986fa3ba83  Ajit Khaparde    net/bnxt: fix allocation of link info struct
> e8fe0e067b  Ajit Khaparde    net/bnxt: fix allocation of PF info struct
> 29fdc5bf45  Apeksha Gupta    test/crypto: fix statistics case
> fb94f35948  Chengchang Tang  net/hns3: fix adding multicast MAC address
> a4e6ea97a5  Dekel Peled      common/mlx5: fix RSS key copy to TIR context
> 1db72630da  Dmitry Kozlyuk   eal/windows: do not expose private facilities
> 867b49d17a  Ferruh Yigit     ring: fix build for gcc O1 optimization
> 48f9faddc6  Kalesh AP        net/bnxt: fix MAC address setting when port is stopped
> 10d6982008  Kalesh AP        net/bnxt: fix recovery alarm race condition in port close
> 920be799db  Lijun Ou         net/hns3: fix RSS indirection table configuration
> 5af61440dd  Matan Azrad      net/mlx5: fix flow counter container resize
> 6e585db689  Michal Krawczyk  net/ena/base: fix testing for supported hash function
> f5bf02df31  Ori Kam          eal/ppc: fix bool type after altivec include
> dede694cd5  Pablo de Lara    doc: add NASM installation steps
> 0aa1ab2fb4  Qi Zhang         net/ice/base: fix a couple of casting
> a7b645debc  Qi Zhang         net/ice/base: fix DCF switch rule
> a1f5c1c27c  Qi Zhang         net/ice/base: fix removing MAC rule
> 3ccf61bc1e  Qi Zhang         net/ice/base: fix tunnel type match word handling
> a60704d1ac  Rasesh Mody      net/qede: fix assignment of Rx/Tx handlers
> 4448a202b6  Thomas Monjalon  eal: remove useless makefiles

Thanks to those who sent out backports.

Last chance for letting me know if you intend to provide more backports
for any of the above - I will be tagging rc1 this evening.

-- 
Kind regards,
Luca Boccassi