patches for DPDK stable branches
 help / color / mirror / Atom feed
* [PATCH] net/bonding: fix forward packets failed
@ 2023-03-10  4:41 Kaiwen Deng
  2023-03-10 21:11 ` Ferruh Yigit
  0 siblings, 1 reply; 2+ messages in thread
From: Kaiwen Deng @ 2023-03-10  4:41 UTC (permalink / raw)
  To: dev
  Cc: stable, qiming.yang, yidingx.zhou, Kaiwen Deng, Chas Williams,
	Min Hu (Connor),
	Tomasz Kulasek, Declan Doherty

The bond port is failed to forward packets in Link Aggregation
802.3AD(4) mode. Because bond devices get LACP packets from 
rx_ring instead of tx_ring.

This commit will get LACP packets from tx_ring instead.

Fixes: 112891cd27e5 ("net/bonding: add dedicated HW queues for LACP control")
Cc: stable@dpdk.org

Signed-off-by: Kaiwen Deng <kaiwenx.deng@intel.com>
---
 drivers/net/bonding/rte_eth_bond_8023ad.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c
index 4a266bb2ca..b585752b00 100644
--- a/drivers/net/bonding/rte_eth_bond_8023ad.c
+++ b/drivers/net/bonding/rte_eth_bond_8023ad.c
@@ -941,7 +941,7 @@ bond_mode_8023ad_periodic_cb(void *arg)
 			/* Find LACP packet to this port. Do not check subtype,
 			 * it is done in function that queued packet
 			 */
-			int retval = rte_ring_dequeue(port->rx_ring,
+			int retval = rte_ring_dequeue(port->tx_ring,
 					(void **)&lacp_pkt);
 
 			if (retval != 0)
-- 
2.34.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] net/bonding: fix forward packets failed
  2023-03-10  4:41 [PATCH] net/bonding: fix forward packets failed Kaiwen Deng
@ 2023-03-10 21:11 ` Ferruh Yigit
  0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2023-03-10 21:11 UTC (permalink / raw)
  To: Kaiwen Deng, dev, Chas Williams, Min Hu (Connor)
  Cc: stable, qiming.yang, yidingx.zhou, Declan Doherty,
	Tomasz Kulasek, Thomas Monjalon

On 3/10/2023 4:41 AM, Kaiwen Deng wrote:
> The bond port is failed to forward packets in Link Aggregation
> 802.3AD(4) mode. Because bond devices get LACP packets from 
> rx_ring instead of tx_ring.
> 
> This commit will get LACP packets from tx_ring instead.
> 
> Fixes: 112891cd27e5 ("net/bonding: add dedicated HW queues for LACP control")
> Cc: stable@dpdk.org
> 

Fixes commit is from 2017, was 802.3AD mode broken since that time?
Or is this for a specific use case?

> Signed-off-by: Kaiwen Deng <kaiwenx.deng@intel.com>
> ---
>  drivers/net/bonding/rte_eth_bond_8023ad.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c
> index 4a266bb2ca..b585752b00 100644
> --- a/drivers/net/bonding/rte_eth_bond_8023ad.c
> +++ b/drivers/net/bonding/rte_eth_bond_8023ad.c
> @@ -941,7 +941,7 @@ bond_mode_8023ad_periodic_cb(void *arg)
>  			/* Find LACP packet to this port. Do not check subtype,
>  			 * it is done in function that queued packet
>  			 */
> -			int retval = rte_ring_dequeue(port->rx_ring,
> +			int retval = rte_ring_dequeue(port->tx_ring,
>  					(void **)&lacp_pkt);
>  
>  			if (retval != 0)


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-03-10 21:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-10  4:41 [PATCH] net/bonding: fix forward packets failed Kaiwen Deng
2023-03-10 21:11 ` Ferruh Yigit

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).