From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 87A4E46B05 for ; Fri, 4 Jul 2025 14:01:19 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6CF3740267; Fri, 4 Jul 2025 14:01:19 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 42D5140267 for ; Fri, 4 Jul 2025 14:01:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751630477; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Rx6rCHqUno2iu/cz/3GeNciEcG1b/g6WGEvUPlXNuUA=; b=ZXVLYgH8u8qn7KTD5Z7A238E7kbIyaK3YzeNxNC1wuF7pyDdq4JenX0iipZZDgAevK4BLz kjokUI8CLM2uKWclNfiCdmWDhvBCyHcKs8JpguFF+aexAVG5HjAdfAzmcu3TkMpYEtWSvg /7D0jvOkbSVfKN0y+LS0TGKzHyvv54E= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-157-dzcPWFGcNouh1WFNuvb0Rg-1; Fri, 04 Jul 2025 08:01:14 -0400 X-MC-Unique: dzcPWFGcNouh1WFNuvb0Rg-1 X-Mimecast-MFC-AGG-ID: dzcPWFGcNouh1WFNuvb0Rg_1751630473 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1220118002E4; Fri, 4 Jul 2025 12:01:13 +0000 (UTC) Received: from [10.44.22.8] (unknown [10.44.22.8]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4930319560A7; Fri, 4 Jul 2025 12:01:11 +0000 (UTC) Message-ID: Date: Fri, 4 Jul 2025 14:01:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: patch 'net/virtio: fix check of threshold for Tx freeing' has been queued to stable release 22.11.9 To: luca.boccassi@gmail.com, Hengqi Chen Cc: Baoyuan Li , dpdk stable References: <20250612210733.2506558-72-luca.boccassi@gmail.com> <20250630122556.1133654-1-luca.boccassi@gmail.com> <20250630122556.1133654-9-luca.boccassi@gmail.com> From: Maxime Coquelin Autocrypt: addr=maxime.coquelin@redhat.com; keydata= xsFNBFOEQQIBEADjNLYZZqghYuWv1nlLisptPJp+TSxE/KuP7x47e1Gr5/oMDJ1OKNG8rlNg kLgBQUki3voWhUbMb69ybqdMUHOl21DGCj0BTU3lXwapYXOAnsh8q6RRM+deUpasyT+Jvf3a gU35dgZcomRh5HPmKMU4KfeA38cVUebsFec1HuJAWzOb/UdtQkYyZR4rbzw8SbsOemtMtwOx YdXodneQD7KuRU9IhJKiEfipwqk2pufm2VSGl570l5ANyWMA/XADNhcEXhpkZ1Iwj3TWO7XR uH4xfvPl8nBsLo/EbEI7fbuUULcAnHfowQslPUm6/yaGv6cT5160SPXT1t8U9QDO6aTSo59N jH519JS8oeKZB1n1eLDslCfBpIpWkW8ZElGkOGWAN0vmpLfdyiqBNNyS3eGAfMkJ6b1A24un /TKc6j2QxM0QK4yZGfAxDxtvDv9LFXec8ENJYsbiR6WHRHq7wXl/n8guyh5AuBNQ3LIK44x0 KjGXP1FJkUhUuruGyZsMrDLBRHYi+hhDAgRjqHgoXi5XGETA1PAiNBNnQwMf5aubt+mE2Q5r qLNTgwSo2dpTU3+mJ3y3KlsIfoaxYI7XNsPRXGnZi4hbxmeb2NSXgdCXhX3nELUNYm4ArKBP LugOIT/zRwk0H0+RVwL2zHdMO1Tht1UOFGfOZpvuBF60jhMzbQARAQABzSxNYXhpbWUgQ29x dWVsaW4gPG1heGltZS5jb3F1ZWxpbkByZWRoYXQuY29tPsLBeAQTAQIAIgUCV3u/5QIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQyjiNKEaHD4ma2g/+P+Hg9WkONPaY1J4AR7Uf kBneosS4NO3CRy0x4WYmUSLYMLx1I3VH6SVjqZ6uBoYy6Fs6TbF6SHNc7QbB6Qjo3neqnQR1 71Ua1MFvIob8vUEl3jAR/+oaE1UJKrxjWztpppQTukIk4oJOmXbL0nj3d8dA2QgHdTyttZ1H xzZJWWz6vqxCrUqHU7RSH9iWg9R2iuTzii4/vk1oi4Qz7y/q8ONOq6ffOy/t5xSZOMtZCspu Mll2Szzpc/trFO0pLH4LZZfz/nXh2uuUbk8qRIJBIjZH3ZQfACffgfNefLe2PxMqJZ8mFJXc RQO0ONZvwoOoHL6CcnFZp2i0P5ddduzwPdGsPq1bnIXnZqJSl3dUfh3xG5ArkliZ/++zGF1O wvpGvpIuOgLqjyCNNRoR7cP7y8F24gWE/HqJBXs1qzdj/5Hr68NVPV1Tu/l2D1KMOcL5sOrz 2jLXauqDWn1Okk9hkXAP7+0Cmi6QwAPuBT3i6t2e8UdtMtCE4sLesWS/XohnSFFscZR6Vaf3 gKdWiJ/fW64L6b9gjkWtHd4jAJBAIAx1JM6xcA1xMbAFsD8gA2oDBWogHGYcScY/4riDNKXi lw92d6IEHnSf6y7KJCKq8F+Jrj2BwRJiFKTJ6ChbOpyyR6nGTckzsLgday2KxBIyuh4w+hMq TGDSp2rmWGJjASrOwU0EVPSbkwEQAMkaNc084Qvql+XW+wcUIY+Dn9A2D1gMr2BVwdSfVDN7 0ZYxo9PvSkzh6eQmnZNQtl8WSHl3VG3IEDQzsMQ2ftZn2sxjcCadexrQQv3Lu60Tgj7YVYRM H+fLYt9W5YuWduJ+FPLbjIKynBf6JCRMWr75QAOhhhaI0tsie3eDsKQBA0w7WCuPiZiheJaL 4MDe9hcH4rM3ybnRW7K2dLszWNhHVoYSFlZGYh+MGpuODeQKDS035+4H2rEWgg+iaOwqD7bg CQXwTZ1kSrm8NxIRVD3MBtzp9SZdUHLfmBl/tLVwDSZvHZhhvJHC6Lj6VL4jPXF5K2+Nn/Su CQmEBisOmwnXZhhu8ulAZ7S2tcl94DCo60ReheDoPBU8PR2TLg8rS5f9w6mLYarvQWL7cDtT d2eX3Z6TggfNINr/RTFrrAd7NHl5h3OnlXj7PQ1f0kfufduOeCQddJN4gsQfxo/qvWVB7PaE 1WTIggPmWS+Xxijk7xG6x9McTdmGhYaPZBpAxewK8ypl5+yubVsE9yOOhKMVo9DoVCjh5To5 aph7CQWfQsV7cd9PfSJjI2lXI0dhEXhQ7lRCFpf3V3mD6CyrhpcJpV6XVGjxJvGUale7+IOp sQIbPKUHpB2F+ZUPWds9yyVxGwDxD8WLqKKy0WLIjkkSsOb9UBNzgRyzrEC9lgQ/ABEBAAHC wV8EGAECAAkFAlT0m5MCGwwACgkQyjiNKEaHD4nU8hAAtt0xFJAy0sOWqSmyxTc7FUcX+pbD KVyPlpl6urKKMk1XtVMUPuae/+UwvIt0urk1mXi6DnrAN50TmQqvdjcPTQ6uoZ8zjgGeASZg jj0/bJGhgUr9U7oG7Hh2F8vzpOqZrdd65MRkxmc7bWj1k81tOU2woR/Gy8xLzi0k0KUa8ueB iYOcZcIGTcs9CssVwQjYaXRoeT65LJnTxYZif2pfNxfINFzCGw42s3EtZFteczClKcVSJ1+L +QUY/J24x0/ocQX/M1PwtZbB4c/2Pg/t5FS+s6UB1Ce08xsJDcwyOPIH6O3tccZuriHgvqKP yKz/Ble76+NFlTK1mpUlfM7PVhD5XzrDUEHWRTeTJSvJ8TIPL4uyfzhjHhlkCU0mw7Pscyxn DE8G0UYMEaNgaZap8dcGMYH/96EfE5s/nTX0M6MXV0yots7U2BDb4soLCxLOJz4tAFDtNFtA wLBhXRSvWhdBJZiig/9CG3dXmKfi2H+wdUCSvEFHRpgo7GK8/Kh3vGhgKmnnxhl8ACBaGy9n fxjSxjSO6rj4/MeenmlJw1yebzkX8ZmaSi8BHe+n6jTGEFNrbiOdWpJgc5yHIZZnwXaW54QT UhhSjDL1rV2B4F28w30jYmlRmm2RdN7iCZfbyP3dvFQTzQ4ySquuPkIGcOOHrvZzxbRjzMx1 Mwqu3GQ= In-Reply-To: <20250630122556.1133654-9-luca.boccassi@gmail.com> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: q2FYThcMkrcMNjR_V4MZOA249PB15JBXgY5MUM6Ui00_1751630473 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi Luca, This patch introduces a performance regression, could you make sure it is not applied to the v22.11 LTS ? Thanks, Maxime On 6/30/25 2:25 PM, luca.boccassi@gmail.com wrote: > Hi, > > FYI, your patch has been queued to stable release 22.11.9 > > Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. > It will be pushed if I get no objections before 07/02/25. So please > shout if anyone has objections. > > Also note that after the patch there's a diff of the upstream commit vs the > patch applied to the branch. This will indicate if there was any rebasing > needed to apply to the stable branch. If there were code changes for rebasing > (ie: not only metadata diffs), please double check that the rebase was > correctly done. > > Queued patches are on a temporary branch at: > https://github.com/bluca/dpdk-stable > > This queued commit can be viewed at: > https://github.com/bluca/dpdk-stable/commit/4863a82ac7db22f67294808bc5077b848e057a40 > > Thanks. > > Luca Boccassi > > --- > From 4863a82ac7db22f67294808bc5077b848e057a40 Mon Sep 17 00:00:00 2001 > From: Hengqi Chen > Date: Mon, 9 Jun 2025 07:23:47 +0000 > Subject: [PATCH] net/virtio: fix check of threshold for Tx freeing > > [ upstream commit 3e3c7f3fa5ac3f2748a4463d87e73eb28024b401 ] > > Like most drivers, make the fast path of virtio_xmit_cleanup() behave as > described by the comments of rte_eth_txconf::tx_free_thresh ([0]): > Start freeing Tx buffers if there are > less free descriptors than this value. > > The rationale behind this change is that: > * vq->vq_nentries is set during device probe > with the queue size specified by vhost backend, > this value does not reflect the real nb_tx_desc > * the real available tx desc is set to vq->vq_free_cnt > via the nb_tx_desc param of rte_eth_tx_queue_setup() API > * so `nb_used > vq->vq_nentries - vq->vq_free_thresh` could never be true > if say nb_tx_desc=2048, vq->vq_nentries=4096, vq->vq_free_thresh=32, > see bug report 1716 ([1]) for details. > > [0]: https://github.com/DPDK/dpdk/commit/72514b5d5543 > [1]: https://bugs.dpdk.org/show_bug.cgi?id=1716 > > Bugzilla ID: 1716 > Fixes: 72514b5d5543 ("ethdev: fix check of threshold for Tx freeing") > > Signed-off-by: Baoyuan Li > Signed-off-by: Hengqi Chen > Reviewed-by: Maxime Coquelin > --- > .mailmap | 3 +++ > drivers/net/virtio/virtio_rxtx.c | 2 +- > 2 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/.mailmap b/.mailmap > index f53fdf0d85..bda591c1cf 100644 > --- a/.mailmap > +++ b/.mailmap > @@ -150,6 +150,8 @@ Balakrishna Bhamidipati > Balasubramanian Manoharan > Balazs Nemeth > Bao-Long Tran > +Baoyuan Li > +Bar Neuman > Barak Enat > Barry Cao > Bartosz Staszewski > @@ -504,6 +506,7 @@ Hemant Agrawal > Heng Ding > Hengjian Zhang > Heng Jiang > +Hengqi Chen > Heng Wang > Henning Schild > Henry Cai > diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c > index c3e686cf0c..66aaeb3c65 100644 > --- a/drivers/net/virtio/virtio_rxtx.c > +++ b/drivers/net/virtio/virtio_rxtx.c > @@ -1870,7 +1870,7 @@ virtio_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) > > nb_used = virtqueue_nused(vq); > > - if (likely(nb_used > vq->vq_nentries - vq->vq_free_thresh)) > + if (likely(vq->vq_free_cnt < vq->vq_free_thresh)) > virtio_xmit_cleanup(vq, nb_used); > > for (nb_tx = 0; nb_tx < nb_pkts; nb_tx++) {