From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5596842608 for ; Tue, 19 Sep 2023 13:27:33 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4F312406B4; Tue, 19 Sep 2023 13:27:33 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2050.outbound.protection.outlook.com [40.107.220.50]) by mails.dpdk.org (Postfix) with ESMTP id B3A4640276; Tue, 19 Sep 2023 13:27:29 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gASNrNTQGuiKVnfZ/A2sQ9NCM9h70HR3xFVYdA3I3vlGFLqlpEeCkacim9MiVqarQ0b4C0v8p7xe6jIzewUD/SaA6cMZ3jMi/hxVaBK7qN9nCUcDA/MFqr5nWLFFEsIbKFO7uCQB+hDdLbbPMaZFY1/kyhcMtkTF4Y33Br0gVlaNcWr19uOy6ouxaCrsU0q6KqytpVxJd5umD4iYyfkdB7/EmE8meKnkrvM2UNRlsLGkTZ36LPKxw4ONL9m9V+wfC1AOt3GDklAlR5Llf6JQIdwnbqzcD4dA8uPzgiRA829Ytmw2rmi45pU7mJoXWN16KROl0mKF+d5C2+y767u1hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QMPcRmrFkau2t35H7sV8qsEndWIa3//HDcOguCMl7WY=; b=iJ5tYPHSd6PYEw+wAkeebXyE1JD+SJY+AqXYGqsaxklSH21hxLg/YHkNSNLAcgAbu2qHSyUTVxljqDpaeskTRLAku3oMlWaNFgSww5Y+kgDSB9KtPbVFsK/gbSUc6YkWX+bC73i/to5lfx/uBG7rlimYbGn7DqplpeCLOtd29Cq2Ibluk8gzHuEC/81qWN+RIsFaXmZT1ElkoqnW7exMArzxMB0+RgFJ1yIuReZvXO4r/apBd4NkoacY1VirI5Uz1wy5F5Y572CQcTLX9Q1jid4gniVuQmEWcuIdJKVlrtUpCr2+a1+3p2cChXrYrgUoXFI3/RBkoBSHRrDnULYCPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QMPcRmrFkau2t35H7sV8qsEndWIa3//HDcOguCMl7WY=; b=xT8DILekkTMRupmkXXZKciRFPVbVPVRoi+jFRuUWaplC9JQc1F0zM9ywN+Xx/ZKk7ZDEPwoIGfyn7eRG2iCIuVwuvWa84r9zQe8hN4KznrDEfG6FOA2x5XhZ8L11XafYHlSdoCmd+scwk/D/MdLVjH9yO6YLxjbiPc629Cvlfes= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CY8PR12MB8065.namprd12.prod.outlook.com (2603:10b6:930:73::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.28; Tue, 19 Sep 2023 11:27:27 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8%4]) with mapi id 15.20.6792.026; Tue, 19 Sep 2023 11:27:26 +0000 Message-ID: Date: Tue, 19 Sep 2023 12:27:19 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] net/mana: add 32 bit short doorbell Content-Language: en-US To: Wei Hu , "dev@dpdk.org" , Long Li Cc: "stable@dpdk.org" , Kevin Traynor , Luca Boccassi References: <20230909122347.2043969-1-weh@microsoft.com> <9f6cc71e-b5d3-4d9f-9ca8-37baf839017e@amd.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJjb9DJBQkC+3/YAAoJEFRTPtCK Km/6d94P/irGq3mPa7LamXMIioQ8i6ppMSjpr8g+SxH9RnzbmoUjUY6hVzCpXYxEejiJHubg 7lwD+bOocYpiU8Pe0UncVBhIPNk/dIWQAyH0IWK1nd+hOnjxHv3AQpP80Be2o1mUn3oq/b+B QYiyvvre2gIugYq0hzLcG7z4zREeT+Nl0DMDfnLx+Tj2FAOHrOfudUqjdr/VjF5PoTK0bxnb Brqulp0I0ft7hNsufhzf+TlqaB5l0eQO4gDo5xGTP97TT1cGYsXVMsyDhHqW6P3cuj8kkLkO Ch4oq8OLL8GElgRy5y5svU6CJu3f8hT9aiqIoaRpfNv6N8iEk6g4/HNN+uydb9YCA+1pbwBx skmDhtxQrmXpI+Fmfq0aX2NmqHcy6JR8Ekm/nfwLAW/aDpwoMImVN5pPXtOBSjYi4pj7hiJk UA0ZFi8HCW+fic85p8MXn1GPDmbO82Mm3JVJ1uJNAzGsBbW5SP1ol6+XTeaSxcmzFlrDs8vL XQJMRTpcG6Pti7GbbsOtldvmxRQpq9PmCgQg9IrPXpMoaKE3WwtiSiCALs0kYj4F+hhgAfjI RsOuaAJTnKYW31pC/QdroMNAEqIpLveql03jj+xD9ntJIVAsXiCitsLIXzKP0L5tcHkoVLC3 NAjVYq6XkAEssPF4mMRLoEwpvxOytHe1BCJoRl0YA0aQzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmNv0PAFCQL7f/8ACgkQVFM+0Ioqb/oU9hAAisAJJ09j/kiEeA1HGKUg3DyFnYW22zRL z1IHYmcHQanMx4+FAwsb1bonVldQMIYNJ9z69UNIU16zIqLZt3D5QK7Je5F5q4NZgfP2jtjX rc3jyu0PuDerFZQyxNcYhhmlF9JO9NV976WYbBAM3AAr0TDohUk+YicYTKab+ZHYOABXbqHX qi+bzDCH1vKBDfpJviprthhK1tIABUK5lsp9aFwFU2jfu2J3XX3pwQhPMjtn2C4v37XUnOqM SJPr2HLU27IW5I3BBpJn7dZE/BkmDmnceHF8E4tRlXCQ/cf81+eErL832sfhVJo1MpubKh3B j89ZLmw0cDXZP2hqlC9vdXnoWWHI8PDPkiw9z11yLrT9Wd4cTJTjFV49Z9G96rgnOtWDcZ1J xHBAnXYQ7V2k9abY+ZqY1PtAPr/smqzQfPHXyTAhRVZp2f3yQmj7UqB07FJuLQjJ4CGk97Qx ///qeSg7D8x/sGEA8Yp2jgIj6u7tspuz+RgBYrWpfI0VIHhWED0jNXzqztrVX18CzA6r0ReY SG+CSyycKkco6UI9ZeUrXFwnoUJqIJY9wTJo5gD9EgGIbItv3qWTq29dihLYpzd6dqB708k7 4RBz9051oLaFVGkguFw/tXmA17nx+c2uR5jx8wb4j68umG2X++0dSta5eHAVhmtXvrqPW6Ku 3FQ= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0218.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:33a::19) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CY8PR12MB8065:EE_ X-MS-Office365-Filtering-Correlation-Id: cb16811c-8357-4142-9cc4-08dbb90366a1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sO4/NUWj4OwPzlzfAexY37pgeSxJlA76Fe6sC8nF2joom+OjlSaE7ihz7iJyfdl18WbxHZ8DNiOnHd4c0uaSMZIw2dVdsXskV00VVlmylHmzM/B6SD2kfCI/dzIzv5n5QRJWBJS8yB/mTzjZK1U5v2nTQNMkhiSDiYDhlYgoD3NX1HQglDBxF6Jppe5M0BchwTGMVMuwjbWu3ebFiKFmR4dXmcmu/8qbSxMqszU3T+42txUru4XeE5aq7J5oVQf3yoZvu7YGKJUYrsfuvfSebOp/ptFBTnrtNN9fCoysHSJXjERTwIJCHXVFp+zYsUkVXV9p1zJZQR2hoA07yfOkD86T/VeWQI0gluQiqOdh5rXsJ9qqHop+0PTXyR3dgHNrW4zQw8tmfYklpB0Tqq3zmWmCNCKpT15L98b5Jj5OSRa40fO0BnLLv6B+TeBqhS3A/4ta5tcHAq81hi1X6MJ6VG8L82bhFcLyVdMQl8i2qSrotQ8EaTxTadbSj/QHgt4Ftd/yOxYH5s6oK20UQF70lmfDs89sWQbQ6TIxSXK9As/a05vKnBgzfwfu9SMs5ODMFflfbtZOwA1hGmi6Q0QqlkTUK2W2N5u5/mrruOO/LVpN2PbA0oAtzI6PWE2Q2deEQSE641RPcEtRrQmi1gjkVg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(396003)(376002)(346002)(39860400002)(136003)(1800799009)(186009)(451199024)(2906002)(44832011)(5660300002)(4326008)(8676002)(31686004)(8936002)(41300700001)(316002)(54906003)(26005)(110136005)(66946007)(66476007)(66556008)(478600001)(45080400002)(53546011)(6506007)(6666004)(6486002)(6512007)(83380400001)(2616005)(36756003)(31696002)(86362001)(38100700002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cFBNQnVteHlHbE1vMWlXRXQza0o5aExENHJCc2hFb2twcFRySmhHSkp4ZXF0?= =?utf-8?B?NlB0WVJGbXZueTJuWCtLM1BXenBBVUx4RUdGR2dYSjRpNUw2Wk82L2hSQlFv?= =?utf-8?B?R2o0R1lSUnJlbnQ1SXo0R2pEMFhhSkt1dHRrYUNoYzZpSVVDSW5QSkpqcHU0?= =?utf-8?B?Z1owQmk4WGkzaVpMYmVoZUZqZTB4RGlJeHAzU0JDMm1DWG1ZZ3QwcnBFTDY1?= =?utf-8?B?STdDakdzeUdRU2VVUi9GakFSWndpaHIydVlOQWV0STcySzBWNU9Jd2pHS29l?= =?utf-8?B?bDd0Z1Y2RUgxUFMraWJnMy9ULzF2ZnhOb2V5K1dBQW5lYzBlS1FuTFd2MDA1?= =?utf-8?B?WlpaYUxtMm9ldVo2OXBOTW1lOU9SMndJWkZUT1ZPY205aGxPbk0vV2pvb1I1?= =?utf-8?B?RzFHZmU0NjkwajM1OUZYQzRvSGZjeUtCOFc2ZysxZCszS0syRFZ2TUhjdFgy?= =?utf-8?B?RjFPSU5iMFNTUEVTTUVSQXV3cEw1QmcrM2F3dnIxZ2VNYlMyMW1HT1ZYTGM5?= =?utf-8?B?TW5zUjRNK2RabGhtelBjWFAxYlFoTGRvTkRNZUtiQm1aQjJrV1ZUWFFPeEZo?= =?utf-8?B?ZkdhMVVxOXc4dnBGbnhEUHpSMS9jY2I1MitSbGxaaTlSR1c3ZXNRNVIrMHpN?= =?utf-8?B?cmZzaWtxTWN1dk43NC9NKzJPb1RCa3BOOVdTZEhNenRVMWdRYVJ2ajJQMldw?= =?utf-8?B?eVRtK1U0ZDFaOXdzTXRWUFAyWm5vd3U4OFVKNCtvc0syTUlRSTRzTERtSDBC?= =?utf-8?B?NktNV0lNeHVESSt5bVR6akFEV0M2MXZRZGZxbnY4My81WWtHU0dpSU1nR0FM?= =?utf-8?B?Tmo1SWNuZFZkN2wzRnQ1ajB3ditrbWd4SVZmenVuTWEyeFh5cENZeEFXUGky?= =?utf-8?B?aUNQUTh1cnUwMFZ2cjFlK04wcXRpL1RwamQxVGIvZHJWVk9sSXFJdUFmRlJz?= =?utf-8?B?bGpvTFNyOWN3c2VpRHY1eHg5YVNMVDh0N0ZMRUFTTmxHenZHUFNncjFjRXNS?= =?utf-8?B?M09XNUxJcjcvaUN6eUFVRmZDZDRnc0Znc3U3OUt3UDVOT0Y0Tld6NU9EU3Zt?= =?utf-8?B?c1RpMmVDUWVCVlM4U081bTFzYWFIZFo2WWNicjY2NVlUaUJvYmhqVkk3cm5U?= =?utf-8?B?a3MrOXJHSVlkZ2lzSVdPTkowMjFjdHlRcm5mQUV2M3dWNzJ3eGZ0U2VPUHJ2?= =?utf-8?B?VGl3L2hCN0hKeTI2Rmx6UTdNRFhtbnkzREN1MzVha0FVbXc1MWwvT211VEtY?= =?utf-8?B?dTRQbWpvRy9RT2czVDJyRVY5bTBnU1JaRlpNcnExb0FabXg1R1hUb2F4TUsz?= =?utf-8?B?UzZXcDVKVTFxWUE2NjM1VUEvS1pIV1FBcFo3Zk11UlVLRm0zLzhiR2g4ejZ3?= =?utf-8?B?bXM1T1pncGhid0t5Q1I0WTgzQy80S1VaSS81ZE15UjV1WFowelB3bks5YzZ2?= =?utf-8?B?TDI2clJoU0J4L1VydkU3c3EzOFB2alVJWGJBS0h5ZXV1T2xlK1RIekhlOFZl?= =?utf-8?B?U2l4TkNpanZHWFZYMEdmWlJEay9lckJ2RHJhYk5WdFgwWmR5bTZ1RTROUmlp?= =?utf-8?B?b0NURkVFZ3NMQWQ3ditPSWYrdUhWSkQvQjBiVlFMT3NnTnZNVGRhdUtyUjkw?= =?utf-8?B?WllNeEtWai8rY3dDSjlMVEtMLzd6V2N4Ny9PWEc4Qnkzc1lUWWF0aVZBdTZz?= =?utf-8?B?eWE5MFEyWStySG02c21GQzdrNzRzR2tKc0RTS2JYZzFRV2MybVBhYUlnM3pi?= =?utf-8?B?bWFWRHRZSUEvY1Z2YzFmVnJaTEpoWnVEUmdSK01EdjYyakdiY3M1bEV2c2hp?= =?utf-8?B?aVQxUHFoa3dUWkJVY1RRS3c4T1ZqMm1jcG1QVWpGNkVHb1ZlL2RuYVZtNExt?= =?utf-8?B?eEJDOWhSU2xORGpQbVYwTlU2V0dQWVllOGwvaWc5NU90SG1Xd0xjQ1k4blpH?= =?utf-8?B?ZVVWemw1ZWVDK0IvYnpBYzZuUGQ5QUd6WCsvTnladmIyWDBXaFFaZnpFSUVy?= =?utf-8?B?UjlmTGgxb05hT2lzOElLVi9GRnQwTU9uRjUzZ3lZTUppNDBnNm82aHg3dk1K?= =?utf-8?B?WEsvVnV1RHNWUm41aUpOSGZVeGNrR09Wa2RRdzA3aXRqTDdsck91RHhEcGwv?= =?utf-8?Q?44YpVq4vMHOF2+xvWQaVn47z4?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: cb16811c-8357-4142-9cc4-08dbb90366a1 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Sep 2023 11:27:26.3088 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AZF/iH3ImjJe6tVivUERXWOusonmrjXHQp5Rmg3QkWRyyi5FUK0HGjMgSM25d9Ri X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB8065 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 9/19/2023 4:38 AM, Wei Hu wrote: > > >> -----Original Message----- >> From: Ferruh Yigit >> Sent: Tuesday, September 19, 2023 2:03 AM >> To: Wei Hu ; dev@dpdk.org; Long Li >> >> Cc: stable@dpdk.org; Kevin Traynor ; Luca Boccassi >> >> Subject: Re: [PATCH 1/1] net/mana: add 32 bit short doorbell >> >> On 9/9/2023 1:23 PM, Wei Hu wrote: >>> Add 32 bit short doorbell support. Ring short doorbell when running in >>> 32 bit applicactions. >>> >> >> Hi Wei, >> >> Is this performance improvement for 32 bit, or is short doorbell support >> required for 32 bit support? >> >> > Hi Ferruh, > > This it not a performance improvement patch. Without this patch, 32 bit applications > do not function. > OK >> This patch is using RTE_ARCH_32 compile time macro to enable short doorbell >> support, so need to decide to support 32 bit or 64 bit in compile time. >> >> Also I guess 32 bit driver can run on 64 bit arch, what will be the result in that >> case? > > The patch is for those applications compiled in 32 bit, but running on a 64 bit Linux > kernels. There is no 64 bit mana kernel driver available. So the kernel still needs to be > in 64 bit. >> >> My point is, instead of using compile time flag, what do you think to detect >> execution platform on runtime and use preferred doorbell according platform? >> >> I can see short descriptor support touches multiple functions, can the support >> be abstracted to let to use it based on runtime detection? > > The 32 bit support request is from a specific customer who only has 32 bit applications. > The customer needs to build and link its applications into 32bit libraries and drivers. > Therefore, the DPDK mana driver needs to be in 32 bit anyway. > > 32bit applications cannot use 64bit doorbells. 64bit applications can use 32bit doorbells, > however the performance would suffer and it definitely not recommended. > OK, can you please add this detail to the commit log? > IMHO, there is not much difference between compile time flag and "if...then...else" statement > at runtime, except for in the latter case, a few more extra runtime instructions and maybe > some branch overhead in either 64bit or 32bit case. Given we have limited 32bit use > cases, I chose to just use the compile time flag, which seems to be simpler to implement > and less work for our verification team. > You are right, I was thinking it can help on deployment, but need to compile separate binaries for 32bit and 64bit anyway, so not much gain. >> >>> Cc: stable@dpdk.org >>> >> >> Similar comment as previous patch, this patch is not a fix but adding new >> support, not sure about backporting it. >> > The customer who needs 32bit support wants it to be on 22.11.x. That is why > I put "Cc: stable@dpdk.org" in it. > >>> Signed-off-by: Wei Hu >>> >> >> <...> >> >>> @@ -97,6 +110,7 @@ mana_alloc_and_post_rx_wqe(struct mana_rxq *rxq) >>> /* update queue for tracking pending packets */ >>> desc->pkt = mbuf; >>> desc->wqe_size_in_bu = wqe_size_in_bu; >>> + rxq->wqe_cnt_to_short_db += wqe_size_in_bu; >>> >> >> This variable always used within RTE_ARCH_32 block, but set here without >> RTE_ARCH_32 ifdef, is this intentional? > > No, it is not intentional. Thanks for pointing this out. I will add ifdef in next > round. > > Thanks, > Wei >