From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: "Eugenio Pérez" <eperezma@redhat.com>, dev@dpdk.org
Cc: David Marchand <david.marchand@redhat.com>,
Chenbo Xia <chenbox@nvidia.com>,
stable@dpdk.org
Subject: Re: [PATCH] vhost: fix net control virtqueue used length
Date: Fri, 13 Jun 2025 10:07:47 +0200 [thread overview]
Message-ID: <f4fd1522-7721-486e-9c24-fca88052679d@redhat.com> (raw)
In-Reply-To: <20250605113534.917903-1-eperezma@redhat.com>
On 6/5/25 1:35 PM, Eugenio Pérez wrote:
> By the standard this is the number of bytes written.
>
> Fixes: 474f4d7840ad ("vhost: add control virtqueue")
> Cc: stable@dpdk.org
>
> Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
> ---
> lib/vhost/virtio_net_ctrl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/vhost/virtio_net_ctrl.c b/lib/vhost/virtio_net_ctrl.c
> index 63c0a06b4f..603a8db728 100644
> --- a/lib/vhost/virtio_net_ctrl.c
> +++ b/lib/vhost/virtio_net_ctrl.c
> @@ -229,7 +229,7 @@ virtio_net_ctrl_push(struct virtio_net *dev, struct virtio_net_ctrl_elem *ctrl_e
>
> used_elem = &cvq->used->ring[cvq->last_used_idx & (cvq->size - 1)];
> used_elem->id = ctrl_elem->head_idx;
> - used_elem->len = ctrl_elem->n_descs;
> + used_elem->len = sizeof(*ctrl_elem->desc_ack);
>
> cvq->last_used_idx++;
>
Applied to next-virtio/for-net-next.
Thanks,
Maxime
prev parent reply other threads:[~2025-06-13 8:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-05 11:35 Eugenio Pérez
2025-06-12 15:44 ` Maxime Coquelin
2025-06-13 8:07 ` Maxime Coquelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4fd1522-7721-486e-9c24-fca88052679d@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=chenbox@nvidia.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=eperezma@redhat.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).