From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 02624A0547
for <public@inbox.dpdk.org>; Mon, 22 Feb 2021 10:53:23 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id E34CE1CC560;
Mon, 22 Feb 2021 10:53:22 +0100 (CET)
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
by mails.dpdk.org (Postfix) with ESMTP id 1F4C54003C;
Mon, 22 Feb 2021 10:53:19 +0100 (CET)
IronPort-SDR: KtmfdDM1SKPAtvwubT7GJFa7MotUU9EX5ooYOjVIS6UzVscQPctDlEwCancBPKc1MiIRhWLH2F
pNwK9R2/jhPQ==
X-IronPort-AV: E=McAfee;i="6000,8403,9902"; a="181890570"
X-IronPort-AV: E=Sophos;i="5.81,196,1610438400"; d="scan'208";a="181890570"
Received: from orsmga008.jf.intel.com ([10.7.209.65])
by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
22 Feb 2021 01:53:18 -0800
IronPort-SDR: Mx9gyk2wiXGmjsl37lYA6RlE/h5lXYhLqh4jcRsdP0hXsvtCr4ziVzwDkEEZBeCXKWa6trl8d9
r8AMX1pEfAdw==
X-IronPort-AV: E=Sophos;i="5.81,196,1610438400"; d="scan'208";a="402511523"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.232.118])
([10.213.232.118])
by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
22 Feb 2021 01:53:17 -0800
To: David Hunt <david.hunt@intel.com>, dev@dpdk.org
Cc: stable@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
Anatoly Burakov <anatoly.burakov@intel.com>,
David Marchand <david.marchand@redhat.com>,
Thomas Monjalon <thomas@monjalon.net>
References: <20210120135556.33763-2-david.hunt@intel.com>
<20210121172201.22582-1-david.hunt@intel.com>
<20210121172201.22582-3-david.hunt@intel.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
X-User: ferruhy
Message-ID: <f5415cb1-e033-a598-eaa2-1f197f268564@intel.com>
Date: Mon, 22 Feb 2021 09:53:13 +0000
MIME-Version: 1.0
In-Reply-To: <20210121172201.22582-3-david.hunt@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-stable] [PATCH v4 2/6] power: make channel msg functions
public
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
Sender: "stable" <stable-bounces@dpdk.org>
On 1/21/2021 5:21 PM, David Hunt wrote:
> From: Bruce Richardson <bruce.richardson@intel.com>
>
> Move the 2 public functions into rte_power_guest_channel.h
>
> Fixes: 210c383e247b ("power: packet format for vm power management")
> Fixes: cd0d5547e873 ("power: vm communication channels in guest")
> Cc: stable@dpdk.org
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> Signed-off-by: David Hunt <david.hunt@intel.com>
<...>
> index ef3b064a8..c500c0cda 100644
> --- a/lib/librte_power/rte_power_guest_channel.h
> +++ b/lib/librte_power/rte_power_guest_channel.h
> @@ -116,6 +116,56 @@ struct channel_packet_caps_list {
> uint8_t num_vcpu;
> };
>
> +/**
> + * @internal
> + *
> + * @warning
> + * @b EXPERIMENTAL: this API may change without prior notice.
> + *
> + * Send a message contained in pkt over the Virtio-Serial to the host endpoint.
> + *
> + * @param pkt
> + * Pointer to a populated struct channel_packet.
> + *
> + * @param lcore_id
> + * Use channel specific to this lcore_id.
> + *
> + * @return
> + * - 0 on success.
> + * - Negative on error.
> + */
> +__rte_experimental
> +int rte_power_guest_channel_send_msg(struct channel_packet *pkt,
> + unsigned int lcore_id);
> +
> +/**
> + * @internal
> + *
> + * @warning
> + * @b EXPERIMENTAL: this API may change without prior notice.
> + *
> + * Receive a message contained in pkt over the Virtio-Serial
> + * from the host endpoint.
> + *
> + * @param pkt
> + * Pointer to channel_packet or
> + * channel_packet_freq_list struct.
> + *
> + * @param pkt_len
> + * Size of expected data packet.
> + *
> + * @param lcore_id
> + * Use channel specific to this lcore_id.
> + *
> + * @return
> + * - 0 on success.
> + * - Negative on error.
> + */
> +__rte_experimental
> +int rte_power_guest_channel_receive_msg(void *pkt,
> + size_t pkt_len,
> + unsigned int lcore_id);
> +
As far as I can see these function are public, so why they have '@internal' tag?