From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 90770A04DB for ; Sat, 17 Oct 2020 05:30:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7F1E2E2D7; Sat, 17 Oct 2020 05:30:10 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 5CF8AE2D7 for ; Sat, 17 Oct 2020 05:30:08 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20201017032958euoutp0131ffe6620b0659ccb1023396cc262b1f~_qfeQC6mJ3000330003euoutp01R for ; Sat, 17 Oct 2020 03:29:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20201017032958euoutp0131ffe6620b0659ccb1023396cc262b1f~_qfeQC6mJ3000330003euoutp01R DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1602905398; bh=XOtkduGbkyAb79PE7mgHKHv7YReFKWv79o/jbKov/9k=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=qdBrrxAcWrUicLaIIOc89CyJQj5v1fnde7c5TNP8SnJknay+i4vyKKe5G+9xno6cZ onFppLpHS3FjlTgBFPZiQLfXt+vNMHQPVXmTTDFIzHFCWQsC87BaWXWQQPpv9TBQsW puJlMx96PlOxhqi/3l1xB4k6sV2Wz3PStcjNWQG4= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20201017032952eucas1p26acd06137404a83b96e29ba4225cac74~_qfZMHAHw1904819048eucas1p2w; Sat, 17 Oct 2020 03:29:52 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 7A.F5.06318.0356A8F5; Sat, 17 Oct 2020 04:29:52 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20201017032951eucas1p1da64db5328a255964ed2ae175383383f~_qfYeK5MP0363603636eucas1p1q; Sat, 17 Oct 2020 03:29:51 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20201017032951eusmtrp266f1ea1d2043d2b3e46188c463df23a3~_qfYdo-5a2813028130eusmtrp2N; Sat, 17 Oct 2020 03:29:51 +0000 (GMT) X-AuditID: cbfec7f5-371ff700000018ae-ff-5f8a65309671 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 78.A9.06314.F256A8F5; Sat, 17 Oct 2020 04:29:51 +0100 (BST) Received: from [106.210.88.70] (unknown [106.210.88.70]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20201017032951eusmtip195d691eacd1ef16e03eccc82a283b4a5~_qfX0EMbF0424404244eusmtip17; Sat, 17 Oct 2020 03:29:51 +0000 (GMT) To: Honnappa Nagarahalli , David Hunt , Bruce Richardson Cc: "dev@dpdk.org" , "stable@dpdk.org" , nd , "\"'Lukasz Wojciechowski'\"," From: Lukasz Wojciechowski Message-ID: Date: Sat, 17 Oct 2020 05:29:50 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: Content-Transfer-Encoding: 8bit Content-Language: en-US X-Brightmail-Tracker: H4sIAAAAAAAAA02SbUhTcRTG+e/eueto9ncqHtQKVkILfAmDBmqpSAhqakFE4MvSi5pu2r1q GVGaFmpLRLDcNF2GTZYWmu8u31FCxfpQjkn2wZcwUvMVTJm5XUd++53nnIfzHDgUIX7Dd6NS lVk0o5SnS+yEZPvI9qSXL10S79vWelJm1F+UlZav8mTLax08mXq+UCBbUL1DsnGdipCZi3YF QYKwxppGFPZXW88Pe21Y5IUNLBt40eQNYUASnZ6aQzM+FxKEKUtTzXaZ3fjuRtcjlIeaRSXI ngJ8Dl7lGwQWFuMGBGPTHiVIuM8bCPb26nhcsY5g1aQnbY7WhRXEOXQI5gaiuaElBOp+HWFp OOEYKDDUkpaGM36KoHxiHFkKAr9E0PU832q3w4EwrN7klyCKEuFL0LPlZ5FJ7Anff8xaM7ng OChrLrRuFmFH+KSes7I9joX+LS3fwgQ+AQVtVQTHrmCaq7XGBtwigFJd20HsUDD16PgcO8Gv 0VYBxx6w12UztCP4urONuKIPwdSzhoMpfxgy79hZkhJYCu+7fTg5GPSrX5BFBuwAxiVHLoQD lLe/IDhZBEVPxNy0N8yrKpBt7W7THFmGJJpDp2kOnaM5dI7m/14tIvXIlc5mFck066ek73iz cgWbrUz2TsxQtKD97xkzj252ot7dm4MIU0hyRETVF8eL+fIcNlcxiIAiJM6ikImxOLEoSZ57 j2Yy4pnsdJodRO4UKXEV+dUtxopxsjyLTqPpTJqxdXmUvVse+og/r3Qxt4rzHbRBAYEza1rP 8OOR108PhJofdNCVV2QevSb/o57u96OMprQPTF9FNc/rWJM01KnJSRpS7dZatVI/st6bepkf c7V2p7FqJqqiKH/oT+FieOek8XykqpIZ+uZCqK8518z+DA6J0MDtAH/q4eOI1FNS9dvh34nT CRKSTZGfPUMwrPwfQLp+GjkDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrBIsWRmVeSWpSXmKPExsVy+t/xu7r6qV3xBmceGVncWGVv0TfpI5PF u0/bmSxmPm1ht3jWs47R4szyHmaLfx1/2B3YPdbMW8Po8WvBUlaPxXteMnkcfLeHKYAlSs+m KL+0JFUhI7+4xFYp2tDCSM/Q0kLPyMRSz9DYPNbKyFRJ384mJTUnsyy1SN8uQS/j7fWNbAW7 BCq+7GxibGDcyNvFyMkhIWAiseXZe8YuRi4OIYGljBL3FrewdjFyACVkJD5cEoCoEZb4c62L DcQWEnjNKHFjjyOILSwQKNG8Zz4LSK+IQC+jxPauuUwgDrPAXEaJqY1PoaY+ZZKYdWo1C0gL m4CtxJGZX8E28Aq4Sez+ZgwSZhFQlbh7/zE7iC0qECfxY2Iv2DZeAUGJkzOfgLVyCsRKHPi2 gBXEZhYwk5i3+SEzhC0v0bx1NpQtLnHryXymCYxCs5C0z0LSMgtJyywkLQsYWVYxiqSWFuem 5xYb6hUn5haX5qXrJefnbmIExtq2Yz8372C8tDH4EKMAB6MSD++GRZ3xQqyJZcWVuYcYJTiY lUR4nc6ejhPiTUmsrEotyo8vKs1JLT7EaAr03ERmKdHkfGAayCuJNzQ1NLewNDQ3Njc2s1AS 5+0QOBgjJJCeWJKanZpakFoE08fEwSnVwBgQrNuu77jUdxJ7etVBJYM6jbkexbcPzwkuPSIS VaRbUZv+JOnkh21W7Sv3MXsKlYYtZZ8fwXf9WsLX8NepWUqNKlLi53yu9q7cNf2g3DKmLv3r xar11kXzJzmIxift0To9534Qrwf7yet9ojfm7V6n2Gyn03z7JY/IV2nfgu6/Tyfs2fMuUoml OCPRUIu5qDgRAGkTC2TLAgAA X-CMS-MailID: 20201017032951eucas1p1da64db5328a255964ed2ae175383383f X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20201010160538eucas1p19298667f236209cfeaa4745f9bb3aae6 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20201010160538eucas1p19298667f236209cfeaa4745f9bb3aae6 References: <20201009220202.20834-1-l.wojciechow@partner.samsung.com> <20201010160508.19709-1-l.wojciechow@partner.samsung.com> <20201010160508.19709-10-l.wojciechow@partner.samsung.com> Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v7 09/16] test/distributor: collect return mbufs X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi Honnappa, W dniu 16.10.2020 o 07:13, Honnappa Nagarahalli pisze: > >> During quit_workers function distributor's main core processes some packets >> to wake up pending worker cores so they can quit. >> As quit_workers acts also as a cleanup procedure for next test case it should >> also collect these packages returned by workers' > nit ^^^^^^^^ packets Fixed in v8 > >> handlers, so the cyclic buffer with returned packets in distributor remains >> empty. >> >> Fixes: c3eabff124e6 ("distributor: add unit tests") >> Cc: bruce.richardson@intel.com >> Fixes: c0de0eb82e40 ("distributor: switch over to new API") >> Cc: david.hunt@intel.com >> Cc: stable@dpdk.org >> >> Signed-off-by: Lukasz Wojciechowski >> Acked-by: David Hunt >> --- >> app/test/test_distributor.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/app/test/test_distributor.c b/app/test/test_distributor.c index >> 06e01ff9d..ed03040d1 100644 >> --- a/app/test/test_distributor.c >> +++ b/app/test/test_distributor.c >> @@ -590,6 +590,7 @@ quit_workers(struct worker_params *wp, struct >> rte_mempool *p) >> const unsigned num_workers = rte_lcore_count() - 1; >> unsigned i; >> struct rte_mbuf *bufs[RTE_MAX_LCORE]; >> + struct rte_mbuf *returns[RTE_MAX_LCORE]; >> if (rte_mempool_get_bulk(p, (void *)bufs, num_workers) != 0) { >> printf("line %d: Error getting mbufs from pool\n", __LINE__); >> return; >> @@ -605,6 +606,10 @@ quit_workers(struct worker_params *wp, struct >> rte_mempool *p) >> rte_distributor_flush(d); >> rte_eal_mp_wait_lcore(); >> >> + while (rte_distributor_returned_pkts(d, returns, RTE_MAX_LCORE)) >> + ; >> + >> + rte_distributor_clear_returns(d); >> rte_mempool_put_bulk(p, (void *)bufs, num_workers); >> >> quit = 0; >> -- >> 2.17.1 -- Lukasz Wojciechowski Principal Software Engineer Samsung R&D Institute Poland Samsung Electronics Office +48 22 377 88 25 l.wojciechow@partner.samsung.com