From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id C37E13B5; Fri, 31 Mar 2017 18:18:41 +0200 (CEST) Received: from pure.maildistiller.com (unknown [10.110.50.29]) by dispatch1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTP id E2A406005B; Fri, 31 Mar 2017 16:18:40 +0000 (UTC) X-Virus-Scanned: Proofpoint Essentials engine Received: from mx3-us4.ppe-hosted.com (unknown [10.110.49.251]) by pure.maildistiller.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 66B676004C; Fri, 31 Mar 2017 16:18:40 +0000 (UTC) Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx3-us4.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 17E6A600A6; Fri, 31 Mar 2017 16:18:36 +0000 (UTC) Received: from [192.168.38.17] (84.52.89.52) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Fri, 31 Mar 2017 17:18:27 +0100 To: Sergio Gonzalez Monroy References: <1490975813-6700-1-git-send-email-arybchenko@solarflare.com> CC: Anatoly Burakov , , , Thomas Monjalon From: Andrew Rybchenko Message-ID: Date: Fri, 31 Mar 2017 19:18:21 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [84.52.89.52] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.100.1062-22976.003 X-TM-AS-Result: No--13.002100-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-MDID: 1490977121-PRJ3k9SM05xQ Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] vfio: do not use memcmp() to compare PCI address X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Mar 2017 16:18:42 -0000 On 03/31/2017 07:09 PM, Sergio Gonzalez Monroy wrote: > On 31/03/2017 16:56, Andrew Rybchenko wrote: >> PCI address structure has padding which may have garbage. >> >> Fixes: 2f4adfad0a69 ("vfio: add multiprocess support") >> Cc: stable@dpdk.org >> >> Signed-off-by: Andrew Rybchenko >> --- >> It is a real bug which I've hit during multi-process debugging. >> >> lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c >> b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c >> index 5f478c5..7d8b9fb 100644 >> --- a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c >> +++ b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c >> @@ -355,7 +355,8 @@ pci_vfio_map_resource(struct rte_pci_device *dev) >> } else { >> /* if we're in a secondary process, just find our tailq >> entry */ >> TAILQ_FOREACH(vfio_res, vfio_res_list, next) { >> - if (memcmp(&vfio_res->pci_addr, &dev->addr, >> sizeof(dev->addr))) >> + if (rte_eal_compare_pci_addr(&vfio_res->pci_addr, >> + &dev->addr)) >> continue; >> break; >> } > > Different commit, same patch :) > https://urldefense.proofpoint.com/v2/url?u=http-3A__dpdk.org_dev_patchwork_patch_21828_&d=DQICaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=flTOx6Av679My7o_iScb5sOlLD68bpUyE2RUtfW3SWQ&m=uvsF8SJaLsRNp3l01Ji5iD4EB1hkHVPOX_dFKqTu_mU&s=HYxvqVvNsbEzQgMJmwQuH6G7vqOkyg7vJ1PrzsxKr5c&e= True, sorry, lost your patch from my view. I'm not sure which state should be set on my patch in the patchwork. Thomas, please, resolve it properly. Thanks, Andrew.