From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Andrew Rybchenko <arybchenko@solarflare.com>,
Tiwei Bie <tiwei.bie@intel.com>,
Zhihong Wang <zhihong.wang@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH] net/virtio: fix broken Tx checksum offloads
Date: Fri, 25 Oct 2019 10:30:25 +0200 [thread overview]
Message-ID: <f5e1b993-763f-4c3d-2f66-09a8b66dc940@redhat.com> (raw)
In-Reply-To: <1571939170-19998-1-git-send-email-arybchenko@solarflare.com>
On 10/24/19 7:46 PM, Andrew Rybchenko wrote:
> Missing parenthesis around expression before type cast to struct
> virtio_net_hdr pointer makes the arithmetic to be in
> sizeof(struct virtio_net_hdr) units.
>
> Use rte_pktmbuf_mtod_offset() to fix the problem.
>
> Type of head_size is changed to signed since some compilers bark
> on unary minus applied to unsigned.
>
> Fixes: 1ae55ad38e5e ("net/virtio: fix mbuf data and packet length mismatch")
> Cc: stable@dpdk.org
>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> ---
> drivers/net/virtio/virtio_rxtx.c | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
Thanks Andrew!
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Ferruh, do you want to apply it directly for -rc1?
Maxime
next prev parent reply other threads:[~2019-10-25 8:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 17:46 Andrew Rybchenko
2019-10-25 6:37 ` Tiwei Bie
2019-10-25 8:30 ` Maxime Coquelin [this message]
2019-10-25 8:48 ` Maxime Coquelin
2019-10-25 10:22 ` [dpdk-stable] [dpdk-dev] " Ferruh Yigit
2019-10-25 14:41 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5e1b993-763f-4c3d-2f66-09a8b66dc940@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=tiwei.bie@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).