From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: "Eugenio Pérez" <eperezma@redhat.com>, dev@dpdk.org
Cc: Chenbo Xia <chenbox@nvidia.com>, stable@dpdk.org
Subject: Re: [PATCH 2/2] vhost: search the packed vq driver area in RO areas
Date: Fri, 13 Jun 2025 10:07:17 +0200 [thread overview]
Message-ID: <f7688cbc-8194-478f-b6fc-3ddb35479db5@redhat.com> (raw)
In-Reply-To: <20250605113552.918120-3-eperezma@redhat.com>
On 6/5/25 1:35 PM, Eugenio Pérez wrote:
> QEMU's shadow virtqueue and VDUSE exposes this as read-only. If we
> don't change it, vhost_iova_to_vva do not consider them as valid and
> returns that they're not found.
>
> Fixes: 2d1541e2b6b3 ("vhost: add vring address setup for packed queues")
> Cc: stable@dpdk.org
>
> Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
> ---
> lib/vhost/vhost.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/vhost/vhost.c b/lib/vhost/vhost.c
> index 95a99bace6..a2e3e2635d 100644
> --- a/lib/vhost/vhost.c
> +++ b/lib/vhost/vhost.c
> @@ -544,7 +544,7 @@ vring_translate_packed(struct virtio_net *dev, struct vhost_virtqueue *vq)
> size = req_size;
> vq->driver_event = (struct vring_packed_desc_event *)(uintptr_t)
> vhost_iova_to_vva(dev, vq, vq->ring_addrs.avail_user_addr,
> - &size, VHOST_ACCESS_RW);
> + &size, VHOST_ACCESS_RO);
> if (!vq->driver_event || size != req_size)
> return -1;
>
Squashed into patch 1.
Thanks,
Maxime
next prev parent reply other threads:[~2025-06-13 8:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-05 11:35 [PATCH 0/2] Search the split vq desc and avail " Eugenio Pérez
2025-06-05 11:35 ` [PATCH 1/2] vhost: search " Eugenio Pérez
2025-06-12 13:55 ` Maxime Coquelin
2025-06-12 14:39 ` Eugenio Perez Martin
2025-06-05 11:35 ` [PATCH 2/2] vhost: search the packed vq driver area " Eugenio Pérez
2025-06-13 8:07 ` Maxime Coquelin [this message]
2025-06-05 11:50 ` [PATCH 0/2] Search the split vq desc and avail " David Marchand
2025-06-05 14:54 ` Eugenio Perez Martin
2025-06-06 14:20 ` David Marchand
2025-06-06 15:10 ` Maxime Coquelin
2025-06-13 8:07 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7688cbc-8194-478f-b6fc-3ddb35479db5@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=chenbox@nvidia.com \
--cc=dev@dpdk.org \
--cc=eperezma@redhat.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).