From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A050B425EF for ; Wed, 20 Sep 2023 13:22:33 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9A30040ED3; Wed, 20 Sep 2023 13:22:33 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 751AB4027B for ; Wed, 20 Sep 2023 13:22:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695208952; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BhU9Lfc9zXYsIjxjVPNI3k+xtXMR/HCTw6iqrNtWgcQ=; b=N2pYErQWrIdy/qwn0dsVYAL58TTWcXotMMUdH18mKo81YgvsjpIoyPjbtHrh6mICpl8lYT 44GHy+roXNDRu2sp36dmLrY6bJZFUnBgKtMIPUZcUjB2N6xF2aeipNiNarO7kp4fN2M/qH 1l4Jl+H/yRi9H9c91PV3Y95ZfPDeR2o= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-655-Pyc0nQIRNOCplXBzLT64yg-1; Wed, 20 Sep 2023 07:22:31 -0400 X-MC-Unique: Pyc0nQIRNOCplXBzLT64yg-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-3fbdf341934so51613305e9.3 for ; Wed, 20 Sep 2023 04:22:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695208949; x=1695813749; h=content-transfer-encoding:in-reply-to:subject:from:references:cc:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BhU9Lfc9zXYsIjxjVPNI3k+xtXMR/HCTw6iqrNtWgcQ=; b=qvKzEITxlLyv72sVdEFx9KP5ohkNgRDLonI1Rt8wiizGv9hvV+i9qvftBoO1qZdktc RY4TgYS+oqPUPnXUUWlYQ89pS/k5GuRoPfkStqmnOwZHU9peJWHMFsTmY6Pi41J8PWZk IJqz1gL7MwZW6SwD8xVYvWyzlqA+4TqjMmbALeyb0mRXbmRAYPQnzy9FC3O+gaQTiAVt 7QHCJ9dvQiu3wgdjM/hOgQcZuJX23vfVYBjra3CkfCRtlgn1GL44CGS19FAsiazl+I1G M88DymZH0u6vWOD6/eYSYy8kilUJuyssQOcGbZlxWa76Dyao+2fWhDUiWC0DosYU3cu4 Y/sA== X-Gm-Message-State: AOJu0YyjDDi6vRGBK4XO7p8Qi9W95VFLLgmmZwcmGyQ8Jqx+D4gRpzsg XMllimP5MmoqkTFnpIWMxUpBgRSoL1Ro6RLqO2oTPgmtr5xpyxqwWo01hq1wiBAIzZLxsGrVkYs jpSSRDF+SSwwcCFo= X-Received: by 2002:a1c:4c09:0:b0:401:bf87:989c with SMTP id z9-20020a1c4c09000000b00401bf87989cmr2232219wmf.34.1695208949661; Wed, 20 Sep 2023 04:22:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFNyWaElRFlqktJlfAQgSYhR1DqaOPARiVVldMdi9o9rBRzQPK5tOnMzPvw2fbIwisqHm83SA== X-Received: by 2002:a1c:4c09:0:b0:401:bf87:989c with SMTP id z9-20020a1c4c09000000b00401bf87989cmr2232204wmf.34.1695208949329; Wed, 20 Sep 2023 04:22:29 -0700 (PDT) Received: from [192.168.0.36] ([78.17.182.90]) by smtp.gmail.com with ESMTPSA id z25-20020a05600c221900b003fbdbd0a7desm1683941wml.27.2023.09.20.04.22.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Sep 2023 04:22:28 -0700 (PDT) Message-ID: Date: Wed, 20 Sep 2023 12:22:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 To: Ferruh Yigit , Wei Hu , "dev@dpdk.org" , Long Li , "Xueming(Steven) Li" Cc: "stable@dpdk.org" , Luca Boccassi References: <20230913122338.2068475-1-weh@microsoft.com> <0505477b-36ed-4b6a-9970-d94858bdf59d@amd.com> <5ed8cb6c-70da-401a-a15c-d21f80f4583f@amd.com> From: Kevin Traynor Subject: Re: [PATCH v2 1/1] net/mana: enable 32 bit build for mana driver In-Reply-To: <5ed8cb6c-70da-401a-a15c-d21f80f4583f@amd.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 20/09/2023 11:03, Ferruh Yigit wrote: > On 9/20/2023 4:06 AM, Wei Hu wrote: >>> -----Original Message----- >>> From: Ferruh Yigit >>> Sent: Tuesday, September 19, 2023 7:05 PM >>> To: Wei Hu ; dev@dpdk.org; Long Li >>> >>> Cc: stable@dpdk.org; Kevin Traynor ; Luca Boccassi >>> >>> Subject: Re: [PATCH v2 1/1] net/mana: enable 32 bit build for mana driver >>> >>> On 9/19/2023 3:44 AM, Wei Hu wrote: >>>>> -----Original Message----- >>>>> From: Ferruh Yigit >>>>> Sent: Tuesday, September 19, 2023 1:41 AM >>>>> To: Wei Hu ; dev@dpdk.org; Long Li >>>>> >>>>> Cc: stable@dpdk.org; Kevin Traynor ; Luca >>>>> Boccassi >>>>> Subject: Re: [PATCH v2 1/1] net/mana: enable 32 bit build for mana >>>>> driver >>>>> >>>>> On 9/13/2023 1:23 PM, Wei Hu wrote: >>>>>> Enable 32 bit build on x86 Linux. Fixed build warnings and errors >>>>>> when building in 32 bit. >>>>>> >>>>>> Cc: stable@dpdk.org >>>>>> >>>>> >>>>> This is not a fix, but adding 32bit support to the driver, so not >>>>> sure about backporting. cc'ed Kevin & Luca for guidance. >>>>> >>>>> I will drop the tag while merging unles otherwise suggested by LTS >>>>> maintainers. >>>> >>>> Hi Ferruh, >>>> >>>> We have a customer who needs it to be on 22.11.x. That is why I put "Cc: >>> stable@dpdk.org" in it. >>>> >>> >>> Got it, lets get comment from the LTS maintainers. >>> >>>>> >>>>>> Signed-off-by: Wei Hu >>>>>> >>>>> >>>>> Hi Wei, >>>>> >>>>> Patch looks good, but it basically fixes the format specifiers that >>>>> will cause build error for 32 bit. >>>>> >>>>> Is there any other change required to make driver functional for 32 >>>>> bit, or does it become functional with this change? >>>>> And if it does can you please confirm explicityly that driver tested >>>>> on >>>>> 32 bit with this patch? >>>> >>>> Another patch, " net/mana: add 32 bit short doorbell", is required to >>>> make mana fully functional with 32 bit applications. This patch is to >>>> fix some build time errors and warnings when build in 32 bit. These >>>> patches can be independently built and they are addressing two different >>> issues. So, I put them into two independent patches. >>>> >>>> I have tested it on 32 bit applications. They can run with this patch. >>>> Just mana would not work as the applications still use 64 bit long door bells, >>> which do not work for 32 bit apps. >>>> >>> >>> Thanks Wei, for clarification. >>> >>> As this patch enables the 32bit build of driver in meson, can you please add >>> comment log that 32bit driver is not functional yet? >>> >>> Or maybe meson update can be moved to short doorbell patch, where driver >>> becomes functional for 32 bit, this patch can mention in commit log that is >>> preparation for 32 bit support, what do you think? >> >> Thanks Ferruh. I would like to add comment log that 32bit driver is not fully >> functioning yet until short doorbell support is added. Meanwhile still keep >> the meson update in within this patch to keep it complete. Hope this works >> for you. >> > > I think it will do. > Can you please send those two patches in a same patchset, that gives > some context if we need to back trace it later? > +1 Adding 22.11 maintainer Xueming. The main thing is that it would not cause a regression to 64 bit. That is something that would need to be tested by Microsoft.