From: Aaron Conole <aconole@redhat.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, stephen@networkplumber.org, stable@dpdk.org,
Michael Santana <maicolgabriel@hotmail.com>
Subject: Re: [PATCH] ci: fix race on container image name
Date: Wed, 02 Aug 2023 08:44:18 -0400 [thread overview]
Message-ID: <f7t4jlh8vh9.fsf@redhat.com> (raw)
In-Reply-To: <20230802065404.3807143-1-david.marchand@redhat.com> (David Marchand's message of "Wed, 2 Aug 2023 08:54:04 +0200")
David Marchand <david.marchand@redhat.com> writes:
> We had a race on the container image name when the prepare job was
> running a day before the build job was triggered.
>
> Example:
> - a prepare job generated image name on 2023/08/01:
>
> 2023-08-01T23:59:32.9711845Z ++ date -u +%Y-%m-%d
> 2023-08-01T23:59:32.9713485Z + echo image=image-fedora:37-2023-08-01
>
> - a few seconds later, the build jobs later tried to use a different
> image name on 2023/08/02:
>
> 2023-08-02T00:01:29.9103180Z ++ date -u +%Y-%m-%d
> 2023-08-02T00:01:29.9113486Z + echo image=image-fedora:37-2023-08-02
>
> Fix this by directly reusing the prepare job output.
>
> Fixes: b35c4b0aa2bc ("ci: add Fedora 35 container in GHA")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
Acked-by: Aaron Conole <aconole@redhat.com>
The dangers of dates... :-)
next prev parent reply other threads:[~2023-08-02 12:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-02 6:54 David Marchand
2023-08-02 12:44 ` Aaron Conole [this message]
2023-08-04 13:02 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7t4jlh8vh9.fsf@redhat.com \
--to=aconole@redhat.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=maicolgabriel@hotmail.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).