From: Aaron Conole <aconole@redhat.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, thomas@monjalon.net, stable@dpdk.org,
John McNamara <john.mcnamara@intel.com>
Subject: Re: [dpdk-stable] [PATCH] doc: fix sphinx rtd theme import in GHA
Date: Thu, 01 Apr 2021 16:37:10 -0400 [thread overview]
Message-ID: <f7teeftspvt.fsf@dhcp-25.97.bos.redhat.com> (raw)
In-Reply-To: <20210401195842.13044-1-david.marchand@redhat.com> (David Marchand's message of "Thu, 1 Apr 2021 21:58:42 +0200")
David Marchand <david.marchand@redhat.com> writes:
> If the rtd theme is available, passing it by name is enough to select
> it. Sphinx itself recognises the "sphinx_rtd_theme" name as a special
> case and tries to find its path automatically.
>
> On the other hand, passing a html_theme_path makes sphinx parse all
> themes availables in this path, which in some environment (like GHA) is
> /usr/share and makes sphinx error on the first zipfile it finds (in GHA,
> some Azure CLI thingy) that has no sphinx theme in it.
>
> Fixes: 46562be65094 ("doc: import sphinx rtd theme when available")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
https://github.com/ovsrobot/dpdk/tree/series_16066
https://github.com/ovsrobot/dpdk/actions/runs/709682570
Acked-by: Aaron Conole <aconole@redhat.com>
> doc/guides/conf.py | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/doc/guides/conf.py b/doc/guides/conf.py
> index aceeb62a4f..ec59aeae7e 100644
> --- a/doc/guides/conf.py
> +++ b/doc/guides/conf.py
> @@ -20,7 +20,6 @@
> import sphinx_rtd_theme
>
> html_theme = "sphinx_rtd_theme"
> - html_theme_path = [sphinx_rtd_theme.get_html_theme_path()]
> except:
> print('Install the sphinx ReadTheDocs theme for improved html documentation '
> 'layout: https://sphinx-rtd-theme.readthedocs.io/',
next prev parent reply other threads:[~2021-04-01 20:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 19:58 David Marchand
2021-04-01 20:37 ` Aaron Conole [this message]
2021-04-01 23:59 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7teeftspvt.fsf@dhcp-25.97.bos.redhat.com \
--to=aconole@redhat.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).