From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id 925D098; Wed, 25 Jul 2018 22:27:18 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B95C2808255B; Wed, 25 Jul 2018 20:27:17 +0000 (UTC) Received: from dhcp-25.97.bos.redhat.com (unknown [10.18.25.61]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 593862156701; Wed, 25 Jul 2018 20:27:17 +0000 (UTC) From: Aaron Conole To: Moti Haimovsky Cc: thomas@monjalon.net, jasvinder.singh@intel.com, dev@dpdk.org, stable@dpdk.org, Bala Sankaran , Reshma Pattan References: <1532529621-5171-1-git-send-email-motih@mellanox.com> <1532532609-16216-1-git-send-email-motih@mellanox.com> Date: Wed, 25 Jul 2018 16:27:16 -0400 In-Reply-To: <1532532609-16216-1-git-send-email-motih@mellanox.com> (Moti Haimovsky's message of "Wed, 25 Jul 2018 18:30:09 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Wed, 25 Jul 2018 20:27:17 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Wed, 25 Jul 2018 20:27:17 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'aconole@redhat.com' RCPT:'' Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v3] app/testpmd: removed softnic CLI modifications X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Jul 2018 20:27:19 -0000 Moti Haimovsky writes: > This patch reverts the testpmd CLI prompt routine modifications done > in order to support softnic. > The reason of doing so is due to testpmd abnormal exit observed on > several setups caused by the softnic modifications to this routine, > for example: When running testpmd with tap interface > (/app/testpmd > -n 4 --vdev=net_tap0,iface=tap0,remote=eth1 -- --burst=64 > --mbcache=512 -i --nb-cores=7 --rxq=2 --txq=2 --txd=512 > --rxd=512 --port-topology=chained --forward-mode=rxonly) > testpmd crashes seconds after presenting its prompt with the following > error: > testpmd> PANIC in prompt(): > CLI poll error (-1) > > Thread 1 "testpmd" received signal SIGABRT, Aborted. > 0x00007ffff668e0d0 in raise () from /lib64/libc.so.6 > (gdb) bt > #0 0x00007ffff668e0d0 in raise () from /lib64/libc.so.6 > #1 0x00007ffff668f6b1 in abort () from /lib64/libc.so.6 > #2 0x0000000000468027 in __rte_panic () > #3 0x00000000004876ed in prompt () > #4 0x000000000046dffc in main () > > When running testpmd with bare-metal device > (app/testpmd -n 4 --socket-mem=1024,1024 -w 04:00.0 -- > --burst=64 --mbcache=512 -i --nb-cores=7 > --rxq=64 --txq=4 --txd=16 --rxd=16) > and pressing CTRL+D right after testpmd prompt is presented then > the program crashes while presenting the same messages as above. > > Needless to say that this behavior is not observed when using the > previous CLI prompt routine. > > Fixes: 0ad778b398c6 ("app/testpmd: rework softnic forward mode") > Cc: stable@dpdk.org > > Signed-off-by: Moti Haimovsky > --- Thanks for the fix - I was just writing to explain that I observe this on master but see that folks are busy fixing it up. I've applied this patch, and no longer see the panic. Acked-by: Aaron Conole