From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 81F31A054F for ; Wed, 24 Feb 2021 16:48:01 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 635DF40040; Wed, 24 Feb 2021 16:48:01 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id CCAE840040 for ; Wed, 24 Feb 2021 16:47:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614181679; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xH1mmydBTW2v1XPYaWwgDuHupLON9rFx0AjVb6T3nvY=; b=M+MDw5zTluPJNYyypTpXqtz5Ly2sGWeiIxDhC3eR2M+2lqGXDLrKos7tHL8Cm9O5D0Aqvh UiHo91yvR6qNW69gBTtSCXsPk4aajkDUj7CjQvWUlEsHrCJczoQ2Od/1nWRzaTejquYahJ 1hN0JCRFFK5955XiMeznmL+noTuWhwU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-497-oh9-3PzYN0mAFsAeHJKChg-1; Wed, 24 Feb 2021 10:47:50 -0500 X-MC-Unique: oh9-3PzYN0mAFsAeHJKChg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5ABE78E47BF; Wed, 24 Feb 2021 15:25:04 +0000 (UTC) Received: from dhcp-25.97.bos.redhat.com (ovpn-114-166.rdu2.redhat.com [10.10.114.166]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 443E75D6AD; Wed, 24 Feb 2021 15:25:00 +0000 (UTC) From: Aaron Conole To: Ferruh Yigit Cc: David Hunt , Ray Kinsella , Neil Horman , Bruce Richardson , Anatoly Burakov , stable@dpdk.org, David Marchand , Juraj =?utf-8?Q?Linke=C5=A1?= References: <20210121172201.22582-1-david.hunt@intel.com> <20210224131651.3103065-1-ferruh.yigit@intel.com> Date: Wed, 24 Feb 2021 10:24:59 -0500 In-Reply-To: <20210224131651.3103065-1-ferruh.yigit@intel.com> (Ferruh Yigit's message of "Wed, 24 Feb 2021 13:16:51 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=aconole@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Subject: Re: [dpdk-stable] [PATCH] power: remove duplicated symbols from map file X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Ferruh Yigit writes: > This is also causing build error, like: > https://travis-ci.com/github/ovsrobot/dpdk/jobs/482121104 > > Also '@internal' marker removed from doxygen comment, since public API > should not be internal. > > Fixes: 4d3892dcd77b ("power: make channel message functions public") > Cc: stable@dpdk.org > > Signed-off-by: Ferruh Yigit > --- Hi Ferruh, Thanks for taking a stab at this. I think there isn't such a simple solution, because this change causes an ABI failure (for some reason) like: [D] 'function int rte_power_guest_channel_send_msg(channel_packet*, unsigned int)' {rte_power_guest_channel_send_msg@@DPDK_21} I guess we might need the full type of aliasing solution documented in Ulrich Drepper's paper https://www.akkadia.org/drepper/dsohowto.pdf That will really need someone who knows what the symbols should look like based on the ABI / API for the different versions. WDYT?