From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id 45249CFD8; Fri, 18 May 2018 15:11:57 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BF36840200A6; Fri, 18 May 2018 13:11:56 +0000 (UTC) Received: from dhcp-25.97.bos.redhat.com (unknown [10.18.25.61]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 33FA62166BAD; Fri, 18 May 2018 13:11:56 +0000 (UTC) From: Aaron Conole To: Ferruh Yigit Cc: stable@dpdk.org, Alejandro Lucero , Luca Boccassi , Eelco Chaudron , Yuanhan Liu , dev@dpdk.org References: <20180514144658.9671-1-aconole@redhat.com> Date: Fri, 18 May 2018 09:11:55 -0400 In-Reply-To: (Ferruh Yigit's message of "Fri, 18 May 2018 10:48:16 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Fri, 18 May 2018 13:11:56 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Fri, 18 May 2018 13:11:56 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'aconole@redhat.com' RCPT:'' Subject: Re: [dpdk-stable] [PATCH] nfp: restore the unlink operation X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 May 2018 13:11:57 -0000 Ferruh Yigit writes: > On 5/14/2018 3:46 PM, Aaron Conole wrote: >> For the stable versions of DPDK, the NFP driver's NSP user space >> driver was modified to account for non-root usage. When that >> happened, commit 515933ad8385 ("nfp: allow for non-root user") >> inadvertently removed the unlink() call. > > This patch is for stable tree. > > Which stable branches are effected? Only 18.02? At this time, just 18.02 > > And a generic stable tree question, is there a easy way to find out which stable > versions has a fix? For this example which versions get "nfp: allow for non-root > user" fix? I'm not sure if there is something in http://dpdk.org/browse/tools/stable-scripts/ that might automatically find the dependency? >> >> Fixes: 515933ad8385 ("nfp: allow for non-root user") >> Cc: Alejandro Lucero >> Cc: Luca Boccassi >> Cc: Eelco Chaudron >> Cc: Yuanhan Liu >> Signed-off-by: Aaron Conole >> --- >> drivers/net/nfp/nfp_nfpu.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/net/nfp/nfp_nfpu.c b/drivers/net/nfp/nfp_nfpu.c >> index ae2e07220..c003640c7 100644 >> --- a/drivers/net/nfp/nfp_nfpu.c >> +++ b/drivers/net/nfp/nfp_nfpu.c >> @@ -121,5 +121,6 @@ nfpu_close(nfpu_desc_t *desc) >> close(desc->lock); >> >> nspu_get_lockfile_path(lockname, sizeof(lockname), desc); >> + unlink(lockname); >> return 0; >> } >>