From: Aaron Conole <aconole@redhat.com>
To: hgovindh <hariprasad.govindharajan@intel.com>
Cc: Remy Horton <remy.horton@intel.com>,
Marko Kovacevic <marko.kovacevic@intel.com>,
Ori Kam <orika@mellanox.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Pablo de Lara <pablo.de.lara.guarch@intel.com>,
Radu Nicolau <radu.nicolau@intel.com>,
Akhil Goyal <akhil.goyal@nxp.com>,
Tomasz Kantecki <tomasz.kantecki@intel.com>,
dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] examples/l3fwd: fix unaligned memory access
Date: Thu, 25 Jul 2019 09:27:56 -0400 [thread overview]
Message-ID: <f7ty30mp7kz.fsf@dhcp-25.97.bos.redhat.com> (raw)
In-Reply-To: <20190724164354.18811-1-hariprasad.govindharajan@intel.com> (hgovindh's message of "Wed, 24 Jul 2019 17:43:54 +0100")
hgovindh <hariprasad.govindharajan@intel.com> writes:
> Fix unaligned memory access when reading IPv6 header which
> leads to segmentation fault by changing aligned memory read
> to unaligned memory read.
>
> Bugzilla ID: 279
> Fixes: 64d3955de1de ("examples/l3fwd: fix ARM build")
> Cc: maciej.czekaj@caviumnetworks.com
> Cc: stable@dpdk.org
> Signed-off-by: hgovindh <hariprasad.govindharajan@intel.com>
> ---
> examples/l3fwd/l3fwd_em.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/examples/l3fwd/l3fwd_em.c b/examples/l3fwd/l3fwd_em.c
> index fa8f82be6..f0c443dae 100644
> --- a/examples/l3fwd/l3fwd_em.c
> +++ b/examples/l3fwd/l3fwd_em.c
> @@ -285,7 +285,7 @@ em_get_ipv6_dst_port(void *ipv6_hdr, uint16_t portid, void *lookup_struct)
> * Get part of 5 tuple: dst IP address lower 96 bits
> * and src IP address higher 32 bits.
> */
> - key.xmm[1] = *(xmm_t *)data1;
> + key.xmm[1] = _mm_loadu_si128((xmm_t *)data1);
Nak. Please use a generic unaligned load, rather than an intel specific
one. Otherwise, supported platforms like arm64 will have broken builds.
Additionally, which chip and compiler did you use to get this error?
>
> /*
> * Get part of 5 tuple: dst port and src port
next prev parent reply other threads:[~2019-07-25 13:28 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 16:43 [dpdk-stable] " hgovindh
2019-07-25 7:01 ` [dpdk-stable] [dpdk-dev] " Ruifeng Wang (Arm Technology China)
2019-07-25 9:05 ` [dpdk-stable] " Bruce Richardson
2019-07-25 13:27 ` Aaron Conole [this message]
2019-07-25 14:01 ` [dpdk-stable] [dpdk-dev] " Burakov, Anatoly
2019-07-25 14:08 ` Govindharajan, Hariprasad
2019-07-25 14:01 ` Lipiec, Herakliusz
2019-07-25 14:23 ` Burakov, Anatoly
2019-07-25 16:29 ` [dpdk-stable] [PATCH v2] " hgovindh
2019-07-25 16:46 ` Bruce Richardson
2019-07-25 17:14 ` [dpdk-stable] [dpdk-dev] " Jerin Jacob Kollanukkaran
2019-07-25 18:56 ` David Christensen
2019-07-25 22:06 ` David Christensen
2019-07-26 10:58 ` [dpdk-stable] [EXT] " Jerin Jacob Kollanukkaran
2019-07-26 13:27 ` [dpdk-stable] [PATCH v3] " hgovindh
2019-07-26 13:37 ` [dpdk-stable] [dpdk-dev] " Burakov, Anatoly
2019-07-26 13:58 ` [dpdk-stable] [PATCH v4] " hgovindh
2019-07-30 8:50 ` Thomas Monjalon
2019-07-30 9:47 ` Bruce Richardson
2019-07-30 11:03 ` [dpdk-stable] [dpdk-dev] " Jerin Jacob Kollanukkaran
2019-07-30 17:45 ` David Christensen
2019-07-31 1:27 ` Ruifeng Wang (Arm Technology China)
2019-07-30 13:26 ` [dpdk-stable] [PATCH v5] Examples/l3fwd: " Hariprasad Govindharajan
2019-07-30 15:48 ` [dpdk-stable] [dpdk-dev] " Lipiec, Herakliusz
2019-07-30 19:58 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7ty30mp7kz.fsf@dhcp-25.97.bos.redhat.com \
--to=aconole@redhat.com \
--cc=akhil.goyal@nxp.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=hariprasad.govindharajan@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=orika@mellanox.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=radu.nicolau@intel.com \
--cc=remy.horton@intel.com \
--cc=stable@dpdk.org \
--cc=tomasz.kantecki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).