From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 26319A0093 for ; Mon, 25 Apr 2022 16:28:28 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 00A9F40E78; Mon, 25 Apr 2022 16:28:28 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 355CF40E78 for ; Mon, 25 Apr 2022 16:28:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1650896905; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TL7sAC4DMIMunsSWmVBkTJy159i4ZedGi9aUuxIZQEQ=; b=UYp1pP9iepQ8MsY+Sb3JiI4d0K+4EXFHvKJGnJ0JdBjpGZPrE0Cr9hgWI02nDBuLQuSsgm qVXpRY2gDt1SKXs4HpMV3PbFxSE5WI+F/gC5D4eapm12+AdCV942yFQM7Ef6SNuU70FIne JnxuZPXd7Et1/4MW0Rj0Bf+GLPnghso= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-216-zlbKb9tzNp6mJ1LSG-GQeA-1; Mon, 25 Apr 2022 10:28:23 -0400 X-MC-Unique: zlbKb9tzNp6mJ1LSG-GQeA-1 Received: by mail-wr1-f71.google.com with SMTP id n17-20020adfc611000000b0020a7e397ccaso3428996wrg.23 for ; Mon, 25 Apr 2022 07:28:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:to:cc:references:from:subject:in-reply-to :content-transfer-encoding; bh=TL7sAC4DMIMunsSWmVBkTJy159i4ZedGi9aUuxIZQEQ=; b=ISPSF4Ma1nF5PxW2iytszeVBqHijl/NyjoWs3Hi45+xnQM7pvc3C21c2VJG3XfKuzr NuJDHxIVspfslGDXIBp8lYesG2W6uvIEcppQyGspDKuGpjiy1gvIm6NFKsZVp51p3tL2 prLLzflajtwkKQyO/oW6u8YsRlp2i8uXKWjCfBM3J/w2+C6d/YJSPIQ+ayM1o0L41PwL A28CibNGF7J3tyBtTZZlJ2/30QRwf24cKsuSOGyhADkCca9yw/KlX72i9imft9O6ooyi ggHN1kmETxq9hQzoKRBYp+zYRzAn0W1d8rO6LLiAqjnJY1oNxU6pPYLbq1HIsie7Rgen KkYA== X-Gm-Message-State: AOAM53112Y70Umxhlxwh43KXmXnXkJhnKGWUY3ugmGXgsTQfgr6Cvv5r rfkHXVvvn4iTqbRlYCxDieBjmYYHsOnJdvbXuLBo6aTG6PU5+bYlH+URb4Xp6wklatNeuueNoxQ 4yPIbGCs= X-Received: by 2002:a7b:c153:0:b0:38e:c1a6:453e with SMTP id z19-20020a7bc153000000b0038ec1a6453emr26552196wmi.131.1650896902107; Mon, 25 Apr 2022 07:28:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw2lf6p3rGV08HECE3FxpDUrLMwKLpqDLlRY6j0KKI1uBYthwFWs3yxZwQEkK+Era8I59lYNQ== X-Received: by 2002:a7b:c153:0:b0:38e:c1a6:453e with SMTP id z19-20020a7bc153000000b0038ec1a6453emr26552190wmi.131.1650896901977; Mon, 25 Apr 2022 07:28:21 -0700 (PDT) Received: from [192.168.0.36] ([78.19.99.101]) by smtp.gmail.com with ESMTPSA id k23-20020adfb357000000b0020ad7c36332sm4811038wrd.110.2022.04.25.07.28.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Apr 2022 07:28:21 -0700 (PDT) Message-ID: Date: Mon, 25 Apr 2022 15:28:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 To: Kai Ji , stable@dpdk.org Cc: hemant.agrawal@nxp.com References: <20220414172353.19105-1-kai.ji@intel.com> From: Kevin Traynor Subject: Re: [PATCH 21.11.1 v1] test/crypto: skip oop test for raw api In-Reply-To: <20220414172353.19105-1-kai.ji@intel.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 14/04/2022 18:23, Kai Ji wrote: > Add in api test type check to skip unsupported aead OOP testcase > in raw API test. > > Fixes: cd8166c28cd1 ("test/crypto: add raw API test for dpaax") > Cc: hemant.agrawal@nxp.com > > Signed-off-by: Kai Ji > Tested-by: Poczatek, Jakub > --- > app/test/test_cryptodev.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c > index 16431efc88..4eedc8e198 100644 > --- a/app/test/test_cryptodev.c > +++ b/app/test/test_cryptodev.c > @@ -10547,9 +10547,16 @@ test_authenticated_encryption_oop(const struct aead_test_data *tdata) > rte_cryptodev_info_get(ts_params->valid_devs[0], &dev_info); > uint64_t feat_flags = dev_info.feature_flags; > > + /* not supported with CPU crypto and raw data-path APIs*/ > + if (gbl_action_type == RTE_SECURITY_ACTION_TYPE_CPU_CRYPTO || > + global_api_test_type == CRYPTODEV_RAW_API_TEST) > + return TEST_SKIPPED; > + > if ((global_api_test_type == CRYPTODEV_RAW_API_TEST) && > - (!(feat_flags & RTE_CRYPTODEV_FF_SYM_RAW_DP))) > + (!(feat_flags & RTE_CRYPTODEV_FF_SYM_RAW_DP))) { > + printf("Device does not support RAW data-path APIs.\n"); > return TEST_SKIPPED; > + } > > /* not supported with CPU crypto */ > if (gbl_action_type == RTE_SECURITY_ACTION_TYPE_CPU_CRYPTO) The first if() means that the next two are dead code, and that means there is a log added that never gets printed. So need to remove duplicate and decide on order of checks and whether you want the log.