From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A24E4A0A0B for ; Fri, 22 Jan 2021 06:33:56 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 87B52140E54; Fri, 22 Jan 2021 06:33:56 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id E7F7B140E48; Fri, 22 Jan 2021 06:33:53 +0100 (CET) IronPort-SDR: ijpSzQrg6zeZbfMl6kvmieW8HkmQrv7DowKo0UVhzmGsEQ7pszCXKvmIICkfb5l2oRdqT5zYBy xu5GnxdDNFtQ== X-IronPort-AV: E=McAfee;i="6000,8403,9871"; a="198141718" X-IronPort-AV: E=Sophos;i="5.79,365,1602572400"; d="scan'208";a="198141718" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jan 2021 21:33:52 -0800 IronPort-SDR: ILZ5kUouDjUCJ/4JYUBJ5DAR330FFTEiy8z3Q44mqHMEWYur3FqydFyF9fbFczdM6R/591r9n6 uuW6TXwpmVZA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,365,1602572400"; d="scan'208";a="348155782" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga007.fm.intel.com with ESMTP; 21 Jan 2021 21:33:52 -0800 Received: from shsmsx603.ccr.corp.intel.com (10.109.6.143) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 21 Jan 2021 21:33:51 -0800 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX603.ccr.corp.intel.com (10.109.6.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 22 Jan 2021 13:33:50 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.1713.004; Fri, 22 Jan 2021 13:33:50 +0800 From: "Guo, Jia" To: "Yu, DapengX" , "Wang, Haiyue" , "Yang, Qiming" CC: "dev@dpdk.org" , "Yu, DapengX" , "stable@dpdk.org" Thread-Topic: [PATCH] net/ixgbe: disable NFS filtering Thread-Index: AQHW7w5y6Z3lgxaACkijVhSnWJr+SaozHw7w Date: Fri, 22 Jan 2021 05:33:49 +0000 Message-ID: References: <20210120092700.105207-1-dapengx.yu@intel.com> In-Reply-To: <20210120092700.105207-1-dapengx.yu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH] net/ixgbe: disable NFS filtering X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, dapeng > -----Original Message----- > From: dapengx.yu@intel.com > Sent: Wednesday, January 20, 2021 5:27 PM > To: Guo, Jia ; Wang, Haiyue ; > Yang, Qiming > Cc: dev@dpdk.org; Yu, DapengX ; stable@dpdk.org > Subject: [PATCH] net/ixgbe: disable NFS filtering >=20 > From: Dapeng Yu >=20 > Disable NFS header filtering whether NFS packets coalescing are required = or > not. >=20 > This behavior is aligned with ixgbe kernel driver. >=20 > Fixes: b826efba6de4 ("net/ixgbe: align register setting when RSC is disab= led") I suggest to add one more fix line which related with the patch, since belo= w patch is what you most change the behaviors. the Fixes: 8eecb3295aed ("ixgbe: add LRO support ") And I saw prior fixed patch are also said it would flow the datasheet, coul= d you explain why you bring this change? Is it anything change about that i= n kernel driver prior with currently? > Cc: stable@dpdk.org >=20 > Signed-off-by: Dapeng Yu > --- > drivers/net/ixgbe/ixgbe_rxtx.c | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) >=20 > diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxt= x.c > index cc8f70e6d..3fb55c675 100644 > --- a/drivers/net/ixgbe/ixgbe_rxtx.c > +++ b/drivers/net/ixgbe/ixgbe_rxtx.c > @@ -4923,15 +4923,11 @@ ixgbe_set_rsc(struct rte_eth_dev *dev) > /* RFCTL configuration */ > rfctl =3D IXGBE_READ_REG(hw, IXGBE_RFCTL); > if ((rsc_capable) && (rx_conf->offloads & > DEV_RX_OFFLOAD_TCP_LRO)) > - /* > - * Since NFS packets coalescing is not supported - clear > - * RFCTL.NFSW_DIS and RFCTL.NFSR_DIS when RSC is > - * enabled. > - */ > - rfctl &=3D ~(IXGBE_RFCTL_RSC_DIS | IXGBE_RFCTL_NFSW_DIS > | > - IXGBE_RFCTL_NFSR_DIS); > + rfctl &=3D ~IXGBE_RFCTL_RSC_DIS; > else > rfctl |=3D IXGBE_RFCTL_RSC_DIS; > + /* disable NFS filtering */ > + rfctl |=3D (IXGBE_RFCTL_NFSW_DIS | IXGBE_RFCTL_NFSR_DIS); I thinks the "()" is no need, right? > IXGBE_WRITE_REG(hw, IXGBE_RFCTL, rfctl); >=20 > /* If LRO hasn't been requested - we are done here. */ > -- > 2.27.0