From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 4A714A0C4D
for <public@inbox.dpdk.org>; Tue, 5 Oct 2021 17:10:55 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 3EB57413CB;
Tue, 5 Oct 2021 17:10:55 +0200 (CEST)
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
by mails.dpdk.org (Postfix) with ESMTP id ED216413BD;
Tue, 5 Oct 2021 17:10:51 +0200 (CEST)
X-IronPort-AV: E=McAfee;i="6200,9189,10128"; a="225708445"
X-IronPort-AV: E=Sophos;i="5.85,349,1624345200"; d="scan'208";a="225708445"
Received: from orsmga008.jf.intel.com ([10.7.209.65])
by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
05 Oct 2021 08:06:23 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.85,349,1624345200"; d="scan'208";a="488071191"
Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81])
by orsmga008.jf.intel.com with ESMTP; 05 Oct 2021 08:06:18 -0700
Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by
fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2242.12; Tue, 5 Oct 2021 08:06:15 -0700
Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by
fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2242.12 via Frontend Transport; Tue, 5 Oct 2021 08:06:15 -0700
Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.107)
by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.1.2242.12; Tue, 5 Oct 2021 08:06:15 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=PEGqdTw09lfjbFbbhF3/Qrr/ms92ZYp867mGAy+CKyQmv+kpJhLhcWwUV1wXpvJFccwSgUzIiQ4O7n3kuwlVSOr1vkprAlixS4By2YtP3ohyo1+Akoe9XyGPeNAqwu8sHae4FTXu7Tfln4084SEjnyOyi7bq656aZEQ7N5v6PZn4FKX8nZ/nZ08LegJz4ZyCu2nLEC4RM0oCZBnCILNbdD9hFGTRyyKZIVXnfWsCE3Ah2WOGLe43/BWWEIsJBnNIFbVTR7+XWfp5xSQWrIfcVMYsoIoofdERPQPVE7UkO99iLhLb/Kw+0z8hZoaNoPgY1aBn96FBPZe8UcKXS29zcA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=w8Z6coCAi2Guzn0NEiAJwf69i8EmytLblEK9Tcf8uzQ=;
b=DvxIrBYULsp9pSWzofaZiKwXEgUEXRVxkEByoub0EHfcMPucyL0U64pZ70UcjPjEqWVpkqiBOT6tS+8IoeUmbiSzK25JdQZmozeR+VQ94ePJFARsUw0o0K+xc32glXATbK1GOn0vLgVXE6n82UBEpowghpoQkKaSmukorPMXC4e3U8pk/a72tCtmfOlDibo/C0v/pKQ5if4ifLaiZpjHzP15H9TbX9oYPMeJg6ZRdxXNG+CA9R3Mcz9gxX5oblbBc8dO+9/HmFD8lkS/NCK7Gjt+BSIErH1sDcwCt5iv4Qa2N8kCO6hl56VCBhfNJgnT4nKc1m0/L3VAaLWvgZ60TQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
dkim=pass header.d=intel.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com;
s=selector2-intel-onmicrosoft-com;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=w8Z6coCAi2Guzn0NEiAJwf69i8EmytLblEK9Tcf8uzQ=;
b=hgRI886+WuxkFJZPTOhFSiUxfi46LVee3zby2OHGn+uotpxTXMPjQfS5K3ioBZ+VLGFRzuvPqZWyGEAHwNF9Eyh3PTO7x+4QqDenzgjeEEb9ylQCsBrXjEPmAIXIIhsADyxoX93bDWt/dAx2Vq9RpfiPZy4eEHVwGiZzbBMA5kc=
Authentication-Results: intel.com; dkim=none (message not signed)
header.d=none;intel.com; dmarc=none action=none header.from=intel.com;
Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19)
by PH0PR11MB5077.namprd11.prod.outlook.com (2603:10b6:510:3b::17)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Tue, 5 Oct
2021 15:06:14 +0000
Received: from PH0PR11MB5000.namprd11.prod.outlook.com
([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com
([fe80::747b:3a08:d1ec:31fc%4]) with mapi id 15.20.4566.022; Tue, 5 Oct 2021
15:06:13 +0000
Message-ID: <fc6d818c-d2d2-c329-322c-5beff170efdc@intel.com>
Date: Tue, 5 Oct 2021 16:06:08 +0100
Content-Language: en-US
To: Ciara Loftus <ciara.loftus@intel.com>, <dev@dpdk.org>
CC: <stable@dpdk.org>, <stephen@networkplumber.org>
References: <20210930134604.32585-1-ciara.loftus@intel.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
X-User: ferruhy
In-Reply-To: <20210930134604.32585-1-ciara.loftus@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: DB6PR0301CA0047.eurprd03.prod.outlook.com
(2603:10a6:4:54::15) To PH0PR11MB5000.namprd11.prod.outlook.com
(2603:10b6:510:41::19)
MIME-Version: 1.0
Received: from [192.168.0.206] (37.228.236.146) by
DB6PR0301CA0047.eurprd03.prod.outlook.com (2603:10a6:4:54::15) with Microsoft
SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.20.4566.21 via Frontend Transport; Tue, 5 Oct 2021 15:06:12 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4dd892bc-18b1-41e8-3330-08d98811ac3e
X-MS-TrafficTypeDiagnostic: PH0PR11MB5077:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <PH0PR11MB50770B21C0DA8B444C38563B95AF9@PH0PR11MB5077.namprd11.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3968;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 3JoFjVLVNDqwgOw6P1kR8tGStDco9eeawUMz5Nrm8gZXxR8snGdwzolPRAkeQ07MLZKdfYSIbW5bbHaa2zqGMDELrvfRXFbDSBrwna4Fe9l6lu8Ul96amPXkf+o+qoKLi+Qvn3anjqaSdyj7oxm6BXubgSnwjHESr8G+k0HaE8iaoNVQ3q0mHm4GjJw4GLWtdQJkpEkTKJMOdO6SUQsJwXE4hTZm3ZRvWVVPsle/IMi5aHv5k17y3OKtGZicK4TGeG4gL/yDtJUdQcXKzKvbSdYzTpzlNsD0HdDXyZZ02DGuFyTliSFbXPeRg6433F63E+q7F2CyzVNHFgZJvZ5YQ7S6HBtJkE+0nqrXRixZ7xH/rCVgRHKn/+rZU/5bGajPKl1FDUOdJvHjyknL1rcspfKrGgaoBb4KlZRU+f9HVptS+K8Qexa+FCAuPQFW6R1LOCbfaE015p5rpeAzexdbjqDZc8bhVYdP4oYpQEleaCwLg1HTF8QZFCtUppxPwtEOEXu43+R/pG/QwAJt7+Rk8HIN2r/z+egFUCfByONuVYeCOu+IvBDd0al48/+X4ca9O+RbkGT8rcvteLLnYF+rPKpMWoL2NvVN7eQWkFtr2rwMtDPJVyZmukk1WGnvyM6gFNxCqsqYgUZVBZM3YjCeG+s5pqdQZRn3YSOf7ZQiCVaUSHNzOJ8UQBKwWpDjvQMzx+F0DLUJ6CZVm1aUIGCcAg==
X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE;
SFS:(4636009)(366004)(31696002)(66476007)(66556008)(6666004)(66946007)(5660300002)(44832011)(86362001)(508600001)(53546011)(26005)(186003)(2616005)(956004)(38100700002)(83380400001)(2906002)(36756003)(4326008)(6486002)(31686004)(16576012)(8676002)(316002)(8936002)(45980500001);
DIR:OUT; SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U20vVFFRQkJqWXU2NFozQWlrQUcvNTZQWkJNVE9XSXVKM1NBME5LMzh1NG9B?=
=?utf-8?B?bmJ5RGd3K3NDZFZsa1NaMlpON2J5L284ODZCZTV6dVdJTUpVRjB2WjFucEhG?=
=?utf-8?B?Mk1jVUZXUzFia3l5OXFOUDdWaERZUmNXRkVFdXdhU21MeUpqRnZRRGQ1bFkv?=
=?utf-8?B?Z0EzZ0NrT2JILzFRR2o3N3NTS0dFSFNvcjNyeWRrUjJQcDdGUXN4cUN3d3A5?=
=?utf-8?B?d05yVFRmcnpUS2JMRXpVVUNKdXNPWVl4Y3Z6dSs1SmRxT3RqTkdkdlg5MXhl?=
=?utf-8?B?QlZKOGRDU09ac1N4dms5OXBMRUlIZGwyMHRtbVdRSUhQVXltV29YcVFvZURL?=
=?utf-8?B?czJ0NVVkdktjVUpnUCt4WlQzY2REbXpWSjROajVzZkt0N1NlazZYZGxaU2Jl?=
=?utf-8?B?MUx4Qm9nTlFTQVdlRDE4cUoxclU5ODRBb2d3YVpqcEZ0SmNNVjE2UHB3Q0Fj?=
=?utf-8?B?S3JOMjYyYmZwblcwMFRTRkl0bUtNREQxTFYwTkFtUFMveWs2S0ROYTg0SGNY?=
=?utf-8?B?RXVPWGVsLzRHcUMzMHZ3MHdkcmVBb0dydFZ1NUFhV090Z3U4S1lHMUovZTVK?=
=?utf-8?B?a2kvK243TlVITzlJZE80cVhrV3p3ZDBTUStEeDIwUi9KVGh3WGlLSk5xNEhM?=
=?utf-8?B?NkdYNFdQTVprVWdqY3Zxbk9aejYrUW0raDRpbEYyaExvRUsyTUl6U0xwVnRM?=
=?utf-8?B?dnFOQzRVUHVHL2NFSXY1WTU5czNMRm9yRmZDYlg0SURpc3NIaGgzM1YwQUJu?=
=?utf-8?B?TGtnd2ozZHlrc0t6dlJCV0JOU2dMVm5QdDlsRkR5Z0xDUWtjaVl0VGxPa0c3?=
=?utf-8?B?NGRPRjRpUXFCU0xKWmMxbFJwR09ZbldVbHRXNFp1SDV0RHZWR0I1dzZFenA3?=
=?utf-8?B?Q0dHOXlLMVlLMlFaMm1scjlodDhSZ1Q4dy9JV3RhRFZXMUFrOWhpWHZsMldC?=
=?utf-8?B?RFpYb3dvSUlhOFNCV2o5aGVKM0k3NVVMeGhvRjZubHBXTmZRbU4ySmNHWmF4?=
=?utf-8?B?eWs4MW9kVUlGK1dnZmxlRk1rOXJIYTN1YkRWZ2xscG44dHd3Q1YwK1h1RnZZ?=
=?utf-8?B?QkdmYjdkOEhkb3hrSENWeXphQXVvdXd1ZjRMVHJKMVFVdnJWZmM2WFdLeTBF?=
=?utf-8?B?L09VcGw0OHBUb05xSVQ0cUhaR3luM2MweGM0dTNzdDlmakQ3Q2xDbmZLOSt0?=
=?utf-8?B?TlRDNWhMajdkcTF6YzloTE00cFBjOElydnc2bHpPWU9kS3I1ZjIvaXlpODJX?=
=?utf-8?B?dGpXTU1HWW1iaVh1MmQybUlTM1ZiTVVqVysxeGdRdWhkbmNUSFg0a2tvUUJQ?=
=?utf-8?B?RDZuQ3lnTncwVjNackh5dVQzY1lZTlZrcS85M1pmYTFJNTUxb0lGcDREQ1FJ?=
=?utf-8?B?UzhGNFFMcjFXTjNMb05wVWV4YzRzZk1WNGpVWDI2TitqY25kZXZDS3Z4QXcw?=
=?utf-8?B?RzhPbXR3Ukt3OTF2TUFha1ZidGtQMlhrcEFLV1FaUkE0dW9jb1ovbmdqZkhW?=
=?utf-8?B?bXlnZ1llbklpSmNoSGw0YVpPK1BwM0l2TUhxUDh1VEJ6QUJXN2ZnalZBQThv?=
=?utf-8?B?a3d0K1NVYytyd2ZxUVU1SkdrZDhDV2NCa2p6ajRocXJ0ZDRyUHIxNkgwK0lF?=
=?utf-8?B?Y3JGalliOVZqVEsxQVovbHA3SEQvMHFhVCtXMHBLZldBK0o2MytlK3dKN0kz?=
=?utf-8?B?cGY4RkxiU3FDd0hvNjVKaWxLTmtoOG1sWE1peXpqWEtoZmhYNFFCa3lvZ3FH?=
=?utf-8?Q?MqKw75jYB6s6b8kD7/1XU6H06Y7yjqhBSDR+3wH?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4dd892bc-18b1-41e8-3330-08d98811ac3e
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2021 15:06:13.8151 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ed1cvzFgFCoYauP//YwVzp5zNo6Z+Bo490yzfPUCIJj7g2gTUqo5ZXQr63sK60GOhtipTRsyBYxMIb0Oo7HOFA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5077
X-OriginatorOrg: intel.com
Subject: Re: [dpdk-stable] [PATCH] net/af_xdp: do not attempt probe for
secondary processes
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
Sender: "stable" <stable-bounces@dpdk.org>
On 9/30/2021 2:46 PM, Ciara Loftus wrote:
> Since the AF_XDP PMD does not work for secondary processes as reported
> in Bugzilla 805, check for the process type at the beginning of probe
> and return ENOTSUP if the process type is secondary.
>
Hi Ciara,
'Do not attempt probe for secondary process' practically means disabling the
secondary process support for af_xdp, what to you think highlight this in
the patch title?
Also can you please add a brief release notes update, for the possible
af_xdp secondary process users.
And would you mind putting the discussed plan to the commit log to record it,
to support the secondary process fully in 22.02 etc..
Thanks,
ferruh
> Bugzilla ID: 805
> Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
> Reported-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> drivers/net/af_xdp/rte_eth_af_xdp.c | 15 +++++----------
> 1 file changed, 5 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c b/drivers/net/af_xdp/rte_eth_af_xdp.c
> index 9bea0a895a..d61cb0aa7c 100644
> --- a/drivers/net/af_xdp/rte_eth_af_xdp.c
> +++ b/drivers/net/af_xdp/rte_eth_af_xdp.c
> @@ -1790,16 +1790,11 @@ rte_pmd_af_xdp_probe(struct rte_vdev_device *dev)
> rte_vdev_device_name(dev));
>
> name = rte_vdev_device_name(dev);
> - if (rte_eal_process_type() == RTE_PROC_SECONDARY &&
> - strlen(rte_vdev_device_args(dev)) == 0) {
> - eth_dev = rte_eth_dev_attach_secondary(name);
> - if (eth_dev == NULL) {
> - AF_XDP_LOG(ERR, "Failed to probe %s\n", name);
> - return -EINVAL;
> - }
> - eth_dev->dev_ops = &ops;
> - rte_eth_dev_probing_finish(eth_dev);
> - return 0;
> + if (rte_eal_process_type() == RTE_PROC_SECONDARY) {
> + AF_XDP_LOG(ERR, "Failed to probe %s. "
> + "AF_XDP PMD does not support secondary processes.\n",
> + name);
> + return -ENOTSUP;
> }
>
> kvlist = rte_kvargs_parse(rte_vdev_device_args(dev), valid_arguments);
>